From: Ricardo Wurmus <rekado@elephly.net>
To: Robert Vollmert <rob@vllmrt.net>
Cc: guix-devel@gnu.org
Subject: Re: on indentation
Date: Fri, 14 Jun 2019 21:59:11 +0200 [thread overview]
Message-ID: <87d0jgq6pc.fsf@elephly.net> (raw)
In-Reply-To: <ACC5984D-057F-4136-83C7-D986E45B495C@vllmrt.net>
Hi Robert,
> * I can run etc/indent-code.el by hand from the guix source
> repo, but it would be much nicer to have it available as a
> regular executable.
I would not package it. Isn’t it already usable as an executable? It
is a regular script after all.
> * Most source files aren’t indented according to etc/indent-code.el,
> presumably because guix import uses (ice-9 pretty-print) which does
> things differently. How to deal with this?
The importers produce expressions that don’t look the way we want them
to look. Usually we re-indent the code (with etc/indent-code.el or the
equivalent manual invocation in Emacs) before committing.
Some existing code, however, may predate our indentation refinements,
and yet other parts may have been overlooked. When we touch those
sections anyway we may also adjust the indentation, but making purely
cosmetic commits is discouraged.
> * Is anyone aware of a different command-line guile/scheme/sexp
> code formatter? etc/indent-code.el is a bit slow, and a tool that
> reformats stdin to stdout would be useful for calling from other
> editors.
I don’t think such a tool exists, also because we specify special
indentation rules for certain Guix-specific macros. Emacs allows us to
do that so etc/indent-code.el uses Emacs.
Perhaps we can speed it up a little?
--
Ricardo
next prev parent reply other threads:[~2019-06-14 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 16:41 on indentation Robert Vollmert
2019-06-14 19:59 ` Ricardo Wurmus [this message]
2019-06-15 11:23 ` Robert Vollmert
2019-06-15 12:15 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0jgq6pc.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=rob@vllmrt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.