From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."
Date: Thu, 27 Jun 2019 01:52:37 -0400
Message-ID: <87d0izr2vu.fsf@netris.org>
References: <20190626222130.32023.24888@vcs0.savannah.gnu.org>
 <20190626222130.F3AE520A01@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:35644)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <mhw@netris.org>) id 1hgNPr-0004RL-K3
 for guix-devel@gnu.org; Thu, 27 Jun 2019 01:57:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mhw@netris.org>) id 1hgNPn-0007cX-P8
 for guix-devel@gnu.org; Thu, 27 Jun 2019 01:57:51 -0400
Received: from world.peace.net ([64.112.178.59]:44132)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mhw@netris.org>) id 1hgNPn-0007QU-Ky
 for guix-devel@gnu.org; Thu, 27 Jun 2019 01:57:47 -0400
In-Reply-To: <20190626222130.F3AE520A01@vcs0.savannah.gnu.org> (guix-commits's
 message of "Wed, 26 Jun 2019 18:21:30 -0400 (EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org

Hi Tobias,

guix-commits@gnu.org writes:

> nckx pushed a commit to branch master
> in repository guix.
>
> commit 1ebb908d447fd7e641e800f970a0035ccd98deb7
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> Date:   Thu Jun 27 00:20:50 2019 +0200
>
>     Revert "gnu: openssh: Clean-up custom install phase."
>
>     This reverts commit 7754136e464e02284624ad05c196d9ec26099143.

and you reverted another commit related to openssh as well:

> commit ba912479e8481d69b699ce348b35d5d70f0c9367
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> Date:   Thu Jun 27 00:20:54 2019 +0200
>
>     Revert "gnu: openssh: Don't create the PRIVSEP_PATH directory."
>
>     This reverts commit 46475f72ab6127e7818fdea4a0ea9cc07c60a5f4.

I don't doubt that reverting these commits was the right thing to do,
but it would be good to know _why_ they were reverted.  Can you provide
a link to a relevant discussion, or else explain it here?

In general, when reverting commits, I think it would be useful to
include an explanation in the commit log.  What do you think?

    Regards,
      Mark