From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase." Date: Thu, 27 Jun 2019 08:16:49 +0200 Message-ID: <87d0izd032.fsf@nckx> References: <20190626222130.32023.24888@vcs0.savannah.gnu.org> <20190626222130.F3AE520A01@vcs0.savannah.gnu.org> <87d0izr2vu.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:39439) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgNiQ-0000a6-WE for guix-devel@gnu.org; Thu, 27 Jun 2019 02:17:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgNiP-0002wM-8E for guix-devel@gnu.org; Thu, 27 Jun 2019 02:17:02 -0400 Received: from tobias.gr ([2001:470:7405::1]:60728) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgNiL-0002mV-V4 for guix-devel@gnu.org; Thu, 27 Jun 2019 02:16:59 -0400 In-reply-to: <87d0izr2vu.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; format=flowed Mark, Mark H Weaver wrote: > I don't doubt that reverting these commits was the right thing > to do, > but it would be good to know _why_ they were reverted. Can you > provide > a link to a relevant discussion, or else explain it here? They remove .../var/empty which breaks ssh-daemon. > In general, when reverting commits, I think it would be useful > to > include an explanation in the commit log. What do you think? You're probably asking the wrong person. I'm all for it. It's not the done thing in Guix, tho'. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXRRfUQAKCRANsP+IT1Vt eQvCAP0cDzjAwGb69jbqbo5YUYg6Djlt/LfSW+Wl/8Adk3bIEwEA7TNouhdIk1Ox UT4bXfN26lQfKUcSfQIjP2VbtMl3VwQ= =GGGG -----END PGP SIGNATURE----- --=-=-=--