From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34517) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIs3f-0005V3-1B for guix-patches@gnu.org; Fri, 11 Oct 2019 06:22:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIs3e-0008OG-42 for guix-patches@gnu.org; Fri, 11 Oct 2019 06:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIs3e-0008O0-0a for guix-patches@gnu.org; Fri, 11 Oct 2019 06:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIs3d-0003FD-Qi for guix-patches@gnu.org; Fri, 11 Oct 2019 06:22:01 -0400 Subject: [bug#36477] [PATCH v4 18/23] gexp: Use cross extensions when cross-compiling. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20191002095904.6325-1-m.othacehe@gmail.com> <20191002095904.6325-19-m.othacehe@gmail.com> Date: Fri, 11 Oct 2019 12:21:12 +0200 In-Reply-To: (Mathieu Othacehe's message of "Wed, 2 Oct 2019 16:47:46 +0200") Message-ID: <87d0f3popz.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 36477@debbugs.gnu.org Hi Mathieu, Mathieu Othacehe skribis: > I forget the commit message. It would be: > > * guix/gexp.scm (load-path-expression): Use ungexp-splicing instead of > ungexp-native-splicing > so that the cross modules are used when target is set. This one LGTM because =E2=80=98load-path-expression=E2=80=99 is used in =E2= =80=98gexp->file=E2=80=99 and =E2=80=98gexp->script=E2=80=99, where, indeed, we want to use the target ex= tensions (and target modules too!). Please push to =E2=80=98master=E2=80=99 (I don=E2=80=99t think it triggers = a full rebuild, but I=E2=80=99d suggest double-checking anyway :-)). Thanks! Ludo=E2=80=99.