From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:41941)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMehm-0000qE-8w
 for guix-patches@gnu.org; Mon, 21 Oct 2019 16:55:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMehl-0003Fy-2c
 for guix-patches@gnu.org; Mon, 21 Oct 2019 16:55:06 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:49117)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iMehk-0003FR-Ga
 for guix-patches@gnu.org; Mon, 21 Oct 2019 16:55:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMehi-0002um-BL
 for guix-patches@gnu.org; Mon, 21 Oct 2019 16:55:04 -0400
Subject: [bug#37813] [PATCH] gnu: mingw-w64: Add -winpthreads variants.
Resent-Message-ID: <handler.37813.B37813.157169124211111@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <9ex2heUi-a_eFy92HaMuh0B33VewNqHzK6r5aayN566rDR-hlo78vAmX0vhMzY2_hzGQRXZvXRYustyKwDqmT2SK-KNEm2azpTeusxKMiv8=@carldong.me>
 <87imolmblu.fsf@gnu.org>
 <L1wRhWjTmpEwuUIPZmPwoG5YKra-1Icc6dzPMgsS0b5ezV1JF7rdXQ08M6l4DgrAup1zxiOGSExePpjN7ZwrC-Ik4fwNxDQzS7MK5Dpk9ss=@carldong.me>
 <87r236ymj7.fsf@gnu.org>
Date: Mon, 21 Oct 2019 22:53:50 +0200
In-Reply-To: <87r236ymj7.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Mon, 21
 Oct 2019 20:35:24 +0200")
Message-ID: <87d0epzuox.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: "37813@debbugs.gnu.org" <37813@debbugs.gnu.org>, Carl Dong <contact@carldong.me>

Hello!

Jan Nieuwenhuizen <janneke@gnu.org> skribis:

>> Thank you for your thorough review, definitely a lot to learn for me
>> still :-)
>
> You're welcome -- however my patches are no better than yours, I was
> very happy with its state.

Yes, the patch LGTM as well!

>>> As a general remark, in GNU we avoid the use the prefix `win' when we
>>> mean Microsoft Windows.  We either use `windows' in full, or `w' (or
>>> w32).  (https://www.gnu.org/prep/standards/html_node/Trademarks.html).
>>>
>>> So, what about using `-windows-pthreads' and `with-windows-pthreads',
>>> throughout?
>>
>> Actually, the library itself is called `winpthreads` according to
>> http://mingw-w64.org/ and as seen in the codebase here:
>> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-l=
ibraries/winpthreads/,
>> is that okay?
>
> Ah, I see.  That is unfortunate.  We would need a maintainer to decide
> then, I'm CC'ing Ludo'.  Personally I would still prefer
> `windows-pthreads' or `wpthreads'.

I=E2=80=99d lean towards keeping the upstream name, so =E2=80=9Cwinpthreads=
=E2=80=9D, as per the
current package naming policy (info "(guix) Package Naming").

Thanks,
Ludo=E2=80=99.