From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:47233) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPu2d-00064w-Es for guix-patches@gnu.org; Wed, 30 Oct 2019 15:54:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPu2c-0002LJ-A9 for guix-patches@gnu.org; Wed, 30 Oct 2019 15:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42709) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPu2c-0002KQ-6J for guix-patches@gnu.org; Wed, 30 Oct 2019 15:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPu2c-00084c-4x for guix-patches@gnu.org; Wed, 30 Oct 2019 15:54:02 -0400 Subject: [bug#37994] [PATCH] gnu: git: Add PCRE support to "git grep". Resent-Message-ID: From: Pierre Neidhardt In-Reply-To: <874kzqw3wc.fsf@nckx> References: <20191030161913.17691-1-mail@ambrevar.xyz> <874kzqw3wc.fsf@nckx> Date: Wed, 30 Oct 2019 20:53:23 +0100 Message-ID: <87d0ee6mdo.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 37994@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice writes: > Pierre, > > Pierre Neidhardt =E5=86=99=E9=81=93=EF=BC=9A >> * gnu/packages/version-control.scm (git)[inputs]: Add pcre2. >> [arguments]: Add "USE_LIBPCRE2" to make-flags. >> (git-minimal)[arguments]: Do not inherit "USE_LIBPCRE2" in=20 >> make-flags. > > What do you think of removing pcre2 from INPUTS as well? git-minimal's input is defined explicitly, no need to remove pcre2 since it's not there. > I'm a bit worried that upstream will grow auto-detection and/or=20 > change the default value of USE_LIBPCRE2 one day, and that would=20 > go unnoticed. Found this: https://stackoverflow.com/a/49826828 Looks like the compile flags are here to stay :) >> + ;; For PCRE support in git grep (USE_LIBPCRE2) > > Missing =E2=80=98.=E2=80=99. You mean the trailing period? Actually I just noticed that about half of those comments in Git have trailing periods. I can fix it. =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl256jMACgkQm9z0l6S7 zH9dyAgApT8lTYb7bet9WGsz6aH6pTyV7+dnMsWbJ28qfk9Bi9IOuQvFIFACSUbf cv1LboUE5S1ow3RcaOAqM2OBZOlSfib+ZFV1bJliDcmJ7qMFiEIf0kMbxffVGHnc hzxPYx7+Fm9K2UNqFqXlU0B1q/Kqlvcgvdaxgxowmis+hiRqDi6jYBMx7CqQK1Kb itGvTppRaVjEBWt53tVipUw6MvV2cMD5h6l+Ta7LRqemxPvocEwsKtlPSHV9TlRE Z12LbXtgxhaX0KCgmqgsqjD/nGL0eaTCmf19Pbb8s1KyCPEK1NzVlo+A6sNPjGBX KOCB0kTReptMzqH9u7WsCiql3qHkLw== =0BqG -----END PGP SIGNATURE----- --=-=-=--