From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:40015)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTD5t-0002Nw-1U
 for guix-patches@gnu.org; Fri, 08 Nov 2019 17:51:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTD5q-0004lJ-QD
 for guix-patches@gnu.org; Fri, 08 Nov 2019 17:51:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:39077)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iTD5q-0004lC-MN
 for guix-patches@gnu.org; Fri, 08 Nov 2019 17:51:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTD5q-0007VZ-IK
 for guix-patches@gnu.org; Fri, 08 Nov 2019 17:51:02 -0500
Subject: [bug#38110] [PATCH v2 2/2] gnu: rust: Bootstrap rust@1.29.0 by
 mrustc@0.9.
Resent-Message-ID: <handler.38110.B38110.157325341628803@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20191107223000.20242-1-dannym@scratchpost.org>
 <20191108024659.10138-1-dannym@scratchpost.org>
 <20191108024659.10138-3-dannym@scratchpost.org>
Date: Fri, 08 Nov 2019 23:50:02 +0100
In-Reply-To: <20191108024659.10138-3-dannym@scratchpost.org> (Danny
 Milosavljevic's message of "Fri, 8 Nov 2019 03:46:59 +0100")
Message-ID: <87d0e2c7ad.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 38110@debbugs.gnu.org

Hi,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/patches/rustc-1.29.0-src.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/rust.scm (rust-1.19): Delete variable.
> (rust-1.20): Delete variable.
> (rust-1.21): Delete variable.
> (rust-1.22): Delete variable.
> (rust-1.23): Delete variable.
> (rust-1.24): Delete variable.
> (rust-1.25): Delete variable.
> (rust-1.26): Delete variable.
> (rust-1.27): Delete variable.
> (rust-1.28): Delete variable.
> (rust-1.29): Bootstrap from mrustc.
> [source]: Add patch.
> (rust-1.30)[inputs]: Remove llvm 3.  Add llvm 6.
> (mrustc): Update rustc-version to 1.29.0.

This is really, really cool!  I stumbled upon
<https://lobste.rs/s/utgedg/mrustc_0_9_now_with_rust_1_29_0_support>
recently and felt a relief.  :-)

I wonder if there=E2=80=99d be any value in keeping a couple of old version=
s of
Rust.  Is that something useful to Rust developers?  If not, I=E2=80=99m ha=
ppy
to see them go!

> --- /dev/null
> +++ b/gnu/packages/patches/rustc-1.29.0-src.patch
> @@ -0,0 +1,86 @@
> +From mrustc 0.9.
> +# Add mrustc slice length intrinsics

Could you use a more meaningful name (why =E2=80=9C-src=E2=80=9D?) and add =
a link to the
upstream commit or upstream issue discussing this change?

Apart from that it looks great!

Thanks,
Ludo=E2=80=99.