From: Brett Gilio <brettg@gnu.org>
To: "Kasperi Keränen" <kasperi.keranen@outlook.com>
Cc: 38679@debbugs.gnu.org
Subject: [bug#38679] [PATCH] gnu: add geary.
Date: Fri, 20 Dec 2019 22:53:31 -0600 [thread overview]
Message-ID: <87d0ciqnxw.fsf@gnu.org> (raw)
In-Reply-To: <VI1PR0202MB350387069B2149803894ED67FD520@VI1PR0202MB3503.eurprd02.prod.outlook.com> ("Kasperi \=\?utf-8\?Q\?Ker\=C3\=A4nen\=22's\?\= message of "Thu, 19 Dec 2019 21:15:07 +0000")
Hi Kasperi,
I have a few helpful criticisms of your patch, if you do not mind! :)
Kasperi Keränen <kasperi.keranen@outlook.com> writes:
> From 3d3ff29798e203f6cf7861a3ecfbb3fd5834c10b Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Kasperi=20Ker=C3=A4nen?= <kasperi.keranen@outlook.com>
> Date: Thu, 19 Dec 2019 19:17:38 +0100
> Subject: [PATCH] gnu: add geary.
Usually, when using the GNU Emacs yasnippet form from /guix/etc/snippets
the "add" is capitalized like so, "gnu: Add geary."
>
> * gnu/packages/gnome.scm (geary): New variable.
> ---
> gnu/packages/gnome.scm | 63 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 0a9087eaff..7b3c337d60 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -168,6 +168,7 @@
> #:use-module (gnu packages xml)
> #:use-module (gnu packages xorg)
> #:use-module (gnu packages xorg)
> + #:use-module (gnu packages libunwind)
Would you mind adding this in its alphabetical order?
> #:use-module (gnu artwork)
> #:use-module (guix build-system cargo)
> #:use-module (guix build-system cmake)
> @@ -8684,6 +8685,68 @@ functionality.")
> license:openldap2.8 ; addressbook/gui/component/openldap-extract.h
> license:lgpl2.1+)))) ; smime/lib/*
>
> +(define-public geary
> + (package
> + (name "geary")
> + (version "3.32.2")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://gnome/sources/geary/"
> + (version-major+minor version) "/"
> + "geary-" version ".tar.xz"))
> + (sha256
> + (base32
> + "0sg53zq81v28hdqiy5d048skwfgsa8ck0z7ywsagdh7iaqin68gq"))))
> + (build-system meson-build-system)
> + (arguments `(#:tests? #f ;; Client tests require a wayland/X11
> display.
A single ; comment will suffice here since it exists on the same line. I
also wonder if it is possible to spoof that display variable in the
tests or just remove that singular test? I might look into this if I
have some time. Maybe mark this as a TODO:?
> + #:glib-or-gtk? #t
> + #:phases (modify-phases %standard-phases
> + (add-after 'unpack 'skip-gtk-update-icon-cache
> + (lambda _
> + (substitute* "build-aux/post_install.py"
> + (("gtk-update-icon-cache") "true"))
> + #t)))))
> + (native-inputs
> + `(("glib:bin" ,glib "bin")
> + ("gettext" ,gettext-minimal)
> + ("itstool" ,itstool)
> + ("pkg-config" ,pkg-config)
> + ("cmake" ,cmake)))
> + (inputs
> + `(("vala" ,vala)
> + ("sqlite" ,sqlite)
> + ("webkitgtk" ,webkitgtk)
> + ("gtk+" ,gtk+)
> + ("glib" ,glib)
> + ("gmime" ,gmime-2.6)
> + ("appstream-glib" ,appstream-glib)
> + ("libarchive" ,libarchive)
> + ("folks" ,folks)
> + ("libgee" ,libgee)
> + ("enchant" ,enchant)
> + ("gcr" ,gcr)
> + ("gnome-online-accounts:lib" ,gnome-online-accounts "lib")
> + ("gspell" ,gspell)
> + ("iso-codes" ,iso-codes)
> + ("json-glib" ,json-glib)
> + ;; ("libpeas" ,libpeas) ;; Required by a newer version of geary
> + ("libnotify" ,libnotify)
> + ("libsecret" ,libsecret)
> + ("libunwind" ,libunwind)
> + ("libcanberra" ,libcanberra)
> + ("glib-networking" ,glib-networking)
> + ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
> + (home-page "https://gitlab.gnome.org/GNOME/geary")
> + (synopsis "An email application built around conversations")
> + (description "Geary is an email application built around conversations, for the
> +GNOME 3 desktop. It allows you to read, find and send email with a
> +straightforward, modern interface.")
> + (license (list license:lgpl2.1
> + license:cc-by3.0 ;;
> + license:cc-by-sa3.0 ;; icons
> + license:public-domain ;;
> + license:bsd-2)))) ;; snowball
> +
> (define-public gthumb
> (package
> (name "gthumb")
Some of my other comments apply to other sections, name about the single
; for same-line comments. I will give this a build and test when I get a
moment. In the mean time, I would also look over some of the inputs some
more, because I wonder if things like "vala" should be native-inputs
instead? Just a thought, I could be wrong.
If you can reroll your patch for a V2 and send it to this tracker issue,
I would appreciate it :).
--
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg@gnu.org> <brettg@posteo.net>
next prev parent reply other threads:[~2019-12-21 4:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 21:15 [bug#38679] [PATCH] gnu: add geary Kasperi Keränen
2019-12-21 4:53 ` Brett Gilio [this message]
2020-01-12 6:43 ` Tobias Geerinckx-Rice via Guix-patches via
2020-01-10 18:52 ` Kasperi Keränen
2020-05-29 21:26 ` Arun Isaac
2020-11-19 9:28 ` bug#38679: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0ciqnxw.fsf@gnu.org \
--to=brettg@gnu.org \
--cc=38679@debbugs.gnu.org \
--cc=kasperi.keranen@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.