From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: Packaging Jami progress
Date: Sun, 22 Dec 2019 08:48:31 +0100
Message-ID: <87d0cgpzqo.fsf@elephly.net>
References: <20191215211230.66fea79e@interia.pl> <875zihclep.fsf@elephly.net>
 <20191222002815.4db8e9ca@interia.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:54992)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <rekado@elephly.net>) id 1iivym-0002Az-96
 for guix-devel@gnu.org; Sun, 22 Dec 2019 02:48:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <rekado@elephly.net>) id 1iivyl-0004sI-49
 for guix-devel@gnu.org; Sun, 22 Dec 2019 02:48:44 -0500
Received: from sender3-of-o51.zoho.com ([136.143.189.51]:21110)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <rekado@elephly.net>) id 1iivyk-0004kd-MQ
 for guix-devel@gnu.org; Sun, 22 Dec 2019 02:48:43 -0500
In-reply-to: <20191222002815.4db8e9ca@interia.pl>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
Cc: guix-devel@gnu.org


Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl> writes:

> The fragment of code I wrote looks like this:
>
> (add-before 'check 'skip-test
>   (lambda _
>     (substitute* "tests/Makefile"
> 	(("include $(SRC_PATH)/tests/fate/lavf-container.mak")
> 			"")) #t))
>
> I also made the git checkout writeable.
> Am I doing something wrong? Should I try deleting the test using
> snippet or just skip all tests using #:tests? #f?

The problem here is that =E2=80=9Csubstitute*=E2=80=9D expects regular expr=
essions and
=E2=80=9C$=E2=80=9D, =E2=80=9C(=E2=80=9D, =E2=80=9C)=E2=80=9D, and =E2=80=
=9C.=E2=80=9D all have special meaning in a regular expression
context, so they need to be escaped.  Escaping is done with a backslash,
but using a backslash in a string in Guile requires another layer of
escaping, so we end up with this expression:

    (add-before 'check 'skip-test
      (lambda _
        (substitute* "tests/Makefile"
          (("include \\$\\(SRC_PATH\\)/tests/fate/lavf-container.mak") ""))
        #t))

(I did not escap the dot here because it can only match a single
character, a literal dot in this case.)

--
Ricardo