From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4NaiCjKPrV5FDgAA0tVLHw (envelope-from ) for ; Sat, 02 May 2020 15:18:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gIDEHDuPrV5idwAAB5/wlQ (envelope-from ) for ; Sat, 02 May 2020 15:18:19 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D0E3094233F for ; Sat, 2 May 2020 15:18:18 +0000 (UTC) Received: from localhost ([::1]:41690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUtuF-000660-1Y for larch@yhetil.org; Sat, 02 May 2020 11:18:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUttv-000614-4d for guix-devel@gnu.org; Sat, 02 May 2020 11:17:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUttu-0004rZ-7c for guix-devel@gnu.org; Sat, 02 May 2020 11:17:58 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:49869) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUttt-0004pv-Fa for guix-devel@gnu.org; Sat, 02 May 2020 11:17:57 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id D3D454E3; Sat, 2 May 2020 11:17:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 02 May 2020 11:17:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=Tw2gTjfverZkDbUmdVguP8fUW/ 8UZaPIoeZ5UYSto7Y=; b=Ojsk2NreKTValrzw4l5/+T/tF+tyBOGFU3joqu6bQB iyKv8uANfhK9NwfPz+hbANEj3sOUyKuKWTHGSW+NOgepbPGJ4rf/CckjO9ZcFRp6 6tYpQBLcaUVt+pToo2a671gDgDhEer5R8sm0YZ/MFxvs+od6Cq/+7G4DQDX2o2N1 778qFpPYQzK8YVBUeJdixepjq+9iwRruyPGnaOdiMKs1y1Ykae81hDoQmwNZYHrx YnyzOEsh6G9GRSNSxjFJSzITWObHLpbogHasoLzN9bWB8tRTXWAykkt+yOMJXIQ9 PjPrTTRsxswF4X6LBVM5cblzNGr2M8HtV47W7II2TXGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Tw2gTj fverZkDbUmdVguP8fUW/8UZaPIoeZ5UYSto7Y=; b=emO1vtEiMtO6Wb05Dn889Y BNtF9i4nClbKylB0cmaN6rejo1QD7red9xFtOhUxdjP3KEfI2Ym4q3+UeXSOK75n qGBvSTRV+c2i215NAUlPTdhg1i2dfYTRnc+hyS8xVIy8JrCQTnUAfsPVETfo+wEl uETvU5Gl8w2wweVnhoCoAIGSZd6i4XLas1qJ2kcu6406r6nmBUjWcRE6+M3+t1On npaqkxfkgdPuE2YcqfdbPpXI+DzJj4OoxmsAqv90lGGF7s1gzgbhq0VYADR1E9oc grLpl9FCtY9ho7b0KBEIcAIS2i45vRGxg/hcnB5YOZH/q8C2gdalRgRAjx1a18Uw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieelgdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculddvfedmnecujfgurhephffvuf gjfhgffffkgggtsehgtderredtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcu oehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpedtvd fggeevgeeivdffueejiedttedvkedtudfggfdtgeefiedtieekffdugfeuffenucfkphep keegrddvtddvrdeikedrjeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 0E9923065FA3; Sat, 2 May 2020 11:17:54 -0400 (EDT) From: Marius Bakke To: Pierre Neidhardt , guix-devel@gnu.org Subject: Re: branch master updated: gnu: Add warsow-qfusion. In-Reply-To: <878siacrr1.fsf@ambrevar.xyz> References: <20200502135735.22136.31429@vcs0.savannah.gnu.org> <87ftci2y7p.fsf@devup.no> <878siacrr1.fsf@ambrevar.xyz> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 02 May 2020 17:17:52 +0200 Message-ID: <87d07m2wnz.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=64.147.123.25; envelope-from=mbakke@fastmail.com; helo=wout2-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/02 09:46:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.25 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 X-Spam-Score: -3.81 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=fastmail.com header.s=fm2 header.b=Ojsk2Nre; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=emO1vtEi; dmarc=pass (policy=none) header.from=fastmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Scan-Result: default: False [-3.81 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49510415617325]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; FREEMAIL_FROM(0.00)[fastmail.com]; DWL_DNSWL_FAIL(0.00)[fastmail.com:server fail,2001:470:142::17:server fail]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.15), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[fastmail.com,none]; DKIM_TRACE(0.00)[fastmail.com:+,messagingengine.com:+]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[mbakke@fastmail.com,guix-devel-bounces@gnu.org]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[fastmail.com:s=fm2,messagingengine.com:s=fm2]; URIBL_BLOCKED(0.00)[ambrevar.xyz:email,fastmail.com:dkim,messagingengine.com:dkim]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[8]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: lNkUB1Xpyqvm --=-=-= Content-Type: text/plain Pierre Neidhardt writes: > Hi Marius, > > Sorry, I rebased and edited a few things, some changes slipped through > and resulted in this terrible commit :( > >> + (let ((commit "c4de15df559410aff0ca6643724e24cddb0ecbbd") >> + (arch (match (or (%current-target-system) >> + (%current-system)) >> + ("x86_64-linux" "x86_64") >> + ("i686-linux" "i386") >> + (_ "")))) >> Don't do this if you just need to determine architecture at build time. > > Just to be sure, you suggest moving this inside the 'really-install > phase, right? Yes. Otherwise it gets needlessly evaluated by the Guix "front-end" every time one uses 'guix search' etc -- even on unsupported architectures. It's better to do it at build time, especially when it is only used within a single phase. On a related note, the 'ccl' package has a similar issue, and actually produces an invalid derivation on aarch64 and armhf. It can be seen by running e.g. 'guix weather -s armhf-linux'. I've been meaning to file a bug about it forever, but typically just comment the package and forget about it. :-/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6tjyAACgkQoqBt8qM6 VPohJwgAo1+v3VgQTeT/5LVv5rAj3t9fOt12iULGwvtkWLryTm+KVNiyx2IKbzmC za5j3IQCrs5s4bsEamgoFbYYZPKQaekppH1u920r6sKjCW6v7WhmrmBpyijFYvO/ YFCpvd1+nhxc4etUlymD93nTy1PB03dNSyL6RRypjVchJ2YN1LLJBuqAiEahApU5 5qIf5YjIjT7shbEjpN/i4pgGNWxCstLWwvsNrgxydFiit4Co2Zo9qBwtt+Q197yV yZRfQhDWeOfUUJwRQHasPDAHC6ybeFlHjmrw7GgMT++pM3FzNGFQAVOeLS0bkPBR x3I52Q10m7701pyP/LtU/XRC0FbMtQ== =P5+w -----END PGP SIGNATURE----- --=-=-=--