From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iBeUA6sTsV44AwAA0tVLHw (envelope-from ) for ; Tue, 05 May 2020 07:20:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mAnUILUTsV62EAAA1q6Kng (envelope-from ) for ; Tue, 05 May 2020 07:20:21 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8711D94456C for ; Tue, 5 May 2020 07:20:20 +0000 (UTC) Received: from localhost ([::1]:56066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVrsL-0002SW-1d for larch@yhetil.org; Tue, 05 May 2020 03:20:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVrs2-00026V-Oc for guix-patches@gnu.org; Tue, 05 May 2020 03:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVrs2-0005ol-Ey for guix-patches@gnu.org; Tue, 05 May 2020 03:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVrs2-0003MI-BA for guix-patches@gnu.org; Tue, 05 May 2020 03:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40677] [PATCH V3 07/15] gnu: Add ffmpeg-jami. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 May 2020 07:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40677 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Jan Cc: 40677@debbugs.gnu.org Received: via spool by 40677-submit@debbugs.gnu.org id=B40677.158866314812842 (code B ref 40677); Tue, 05 May 2020 07:20:02 +0000 Received: (at 40677) by debbugs.gnu.org; 5 May 2020 07:19:08 +0000 Received: from localhost ([127.0.0.1]:34648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVrrA-0003L3-9R for submit@debbugs.gnu.org; Tue, 05 May 2020 03:19:08 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVrr7-0003KZ-U9 for 40677@debbugs.gnu.org; Tue, 05 May 2020 03:19:06 -0400 Received: by mail-wm1-f68.google.com with SMTP id u127so1065159wmg.1 for <40677@debbugs.gnu.org>; Tue, 05 May 2020 00:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yCYCMTFcu4Bk/Eskt5RPY6lmY86uDmLPH/lserFcVJ4=; b=oNNgLtPpJnpM0ZrI0Wak4aN0oVeoe3edy8jAlVtUqBhGS8KvnvNOkyMTGGcGgkTJgi 0oS2qYCIBGehtoAVzZZVrajr5AK7VBmUrSXtaHNx8R33a2QIbXv80FLSzK3mJBX287DY Z28pNYbQSY5I/qtMjcNMemeU4ceW3wl4ysRMLpVDhfSdnb1jEk/WFuVenRrJRy0si+4F Kfq6cG3hp7kXhg+3bHspKd86Qll56lQHShIFkfJ9Imr5UcG4Yc5ieKwgnQ7KKCK5qxOb /l0818epkse6DpAi2RN+FDtTEvuvIPKKJANV7akCwN5s5VAKygI4oifZ4l3WnAJXkeaU 7+qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=yCYCMTFcu4Bk/Eskt5RPY6lmY86uDmLPH/lserFcVJ4=; b=KIWaSATdDc9nGXO8ayKMCMj+zbdAAIRFd17VpiJ/U3GxqyK1PozaVyXyaeDxhtmCdN HCR+MKmpYV+mh5o92/Q1Gw4T6WLR68hruZix6XD/tmmrF2tcX7nIwFDOjA8FiCfY1h3I 50VcobSSIkU/o5E/rmq3bjreMNFczQS7iwlHjhIWS4UiAmfVVBF1XYeRcGECK9I3U7Pv /X+i1GU8B5TYmNSLIRrMIfUq1AD0L+VtWMo5WarIp/bSgnoRsl6CM4i5hdzaLdftTDZW /+YwnSI9urkwnn3gxpDvqu9FDSMau5rbrTJ2retAYQJb4Bk6HARnN+unLHrhK8JhiH25 96Uw== X-Gm-Message-State: AGi0PuZ1w/8ibFy1ybxkYNhH0KH9FctkPT21QnnvHPxhznisoQDSwNU5 RqeW6cy7survN6ULjSVslfzlL+tF X-Google-Smtp-Source: APiQypK/NQEeZvC5fNSJcOmRAWmGAmq93Usk45NJxy7ZawDaRGpdSGvviOrzDPaVUBLnCZULVIGaGg== X-Received: by 2002:a7b:ce88:: with SMTP id q8mr1949440wmj.161.1588663139638; Tue, 05 May 2020 00:18:59 -0700 (PDT) Received: from meru ([2a01:cb18:832e:5f00:7097:5e4f:8b60:ade7]) by smtp.gmail.com with ESMTPSA id n7sm1593418wrm.86.2020.05.05.00.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2020 00:18:58 -0700 (PDT) From: Mathieu Othacehe References: <20200502011450.2676-1-tona_kosmicznego_smiecia@interia.pl> <20200502011450.2676-8-tona_kosmicznego_smiecia@interia.pl> <87368i1xwh.fsf@gmail.com> <20200504202631.1ebaf90b@kompiuter> Date: Tue, 05 May 2020 09:18:58 +0200 In-Reply-To: <20200504202631.1ebaf90b@kompiuter> (Jan's message of "Mon, 4 May 2020 20:26:31 +0200") Message-ID: <87d07ietnh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: 0.09 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=oNNgLtPp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [0.09 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49522575593313]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; R_DKIM_REJECT(1.00)[gmail.com:s=20161025]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; FREEMAIL_FROM(0.00)[gmail.com]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.13), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DKIM_TRACE(0.00)[gmail.com:-]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[interia.pl]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[mothacehe@gmail.com,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[40677@debbugs.gnu.org]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : SPF not aligned (relaxed),none] X-TUID: qn114GcBHJa9 Hello Jan, > So I compared the list of flags turned off by default with ffmpeg > package currently in guix with ffmpeg-jami package and I managed to > shorten the list from 107 to 95. It isn't worth the effort. Oh that's a disappointment indeed. Among those 95 flags I'm pretty sure most of them match the default, but going through all of them feels like a burden. > I prefer just copy the list from rules.mak. What I could do is defining > a separate "ffmpeg-configure-flags" variable somewhere near ffmpeg-jami > and use it, instead of having the bloated list inside the package > definition (if that's even possible). > Correct me if I'm wrong or suggest a reasonable solution, because I have > no idea how to deal with it right now. Ok, this seems fine. Don't hesitate to add a link to a Web view of the rules.mak file, so that it's clear where those flags come from. Another remark on this part, > "--enable-encoder=h264_nvenc" > "--enable-encoder=hevc_nvenc")) > ((string?= (%current-system) "aarch64-linux") '("--arch=aarch64")) > ((string?= (%current-system) "arm64-linux") '("--arch=aarch64")) "arm64-linux" is not a valid system, you can remove it. > ((string?= (%current-system) "arm") '("--arch=arm")) I think the right system here is "armhf-linux". However, you would also need to support cross-compilation when %current-target-system is set. In that case, the value looks like "aarch64-linux-gnu" and "arm-linux-gnueabihf". If you add support for those plaforms you need to test it by building ffmpeg-jami with "--system" and "--target" flags. As this is a complex package with a lot of dependencies (probably failing to cross-compile), it would be fine with me if you just drop support for other systems/targets. Thanks, Mathieu