From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mBKBOJg/317hFwAA0tVLHw (envelope-from ) for ; Tue, 09 Jun 2020 07:51:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kHE9NJg/316qdgAAB5/wlQ (envelope-from ) for ; Tue, 09 Jun 2020 07:51:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2BEE29401CB for ; Tue, 9 Jun 2020 07:51:52 +0000 (UTC) Received: from localhost ([::1]:42328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiZ30-0000zK-0d for larch@yhetil.org; Tue, 09 Jun 2020 03:51:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiZ1H-0000Xi-2G for guix-patches@gnu.org; Tue, 09 Jun 2020 03:50:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiZ1G-0001sX-OK for guix-patches@gnu.org; Tue, 09 Jun 2020 03:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jiZ1G-0004Wx-LI for guix-patches@gnu.org; Tue, 09 Jun 2020 03:50:02 -0400 Subject: bug#41720: [PATCH] store: Use buffered I/O for all protocol writes Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 09 Jun 2020 07:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41720 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 41720-done@debbugs.gnu.org Mail-Followup-To: 41720@debbugs.gnu.org, ludo@gnu.org, ldb@leibniz-psychology.org Received: via spool by 41720-done@debbugs.gnu.org id=D41720.159168900017398 (code D ref 41720); Tue, 09 Jun 2020 07:50:02 +0000 Received: (at 41720-done) by debbugs.gnu.org; 9 Jun 2020 07:50:00 +0000 Received: from localhost ([127.0.0.1]:58761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiZ1E-0004WX-8N for submit@debbugs.gnu.org; Tue, 09 Jun 2020 03:50:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiZ1C-0004WI-Bk for 41720-done@debbugs.gnu.org; Tue, 09 Jun 2020 03:49:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36616) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiZ16-0001re-Ud; Tue, 09 Jun 2020 03:49:52 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58658 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jiZ15-0007Ze-Ff; Tue, 09 Jun 2020 03:49:51 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200605091151.GB3225@zpidnp36> <875zc5xkoh.fsf@gnu.org> <20200608064228.GB3166@zpidnp36> Date: Tue, 09 Jun 2020 09:49:49 +0200 In-Reply-To: <20200608064228.GB3166@zpidnp36> (Lars-Dominik Braun's message of "Mon, 8 Jun 2020 08:42:28 +0200") Message-ID: <87d068oezm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: aIudWUFlEuuP Hi! Lars-Dominik Braun skribis: >> Nice, though the slowdown on Unix-domain sockets is annoying given that >> it=E2=80=99s the primary transport. Are the 10% significant and stable = over >> multiple runs? > I don=E2=80=99t want to blind your eyes with meaningless statistics here,= but let=E2=80=99s do > this properly then. So for `guix environment guix -- true` with 10 trials= these > are the results: > > ---snip--- > $ ministat -A -c 99 before_ssh after_ssh > x before_ssh > + after_ssh > N Min Max Median Avg Stdd= ev > x 10 7.63 10.635 10.1585 9.9382 0.855175= 85 > + 10 5.986 6.424 6.1755 6.1917 0.153984= 16 > Difference at 99.0% confidence > -3.7465 +/- 0.790815 > -37.698% +/- 5.0788% > (Student's t, pooled s =3D 0.614425) > > $ ministat -A -c 99 before_unix after_unix > x before_unix > + after_unix > N Min Max Median Avg Stdd= ev > x 10 1.528 1.624 1.5445 1.5636 0.0358428= 67 > + 10 1.576 1.701 1.6145 1.6229 0.0378695= 13 > Difference at 99.0% confidence > 0.0593 +/- 0.0474548 > 3.79253% +/- 3.08989% > (Student's t, pooled s =3D 0.0368701) > ---snap--- > > And the same for `guix environment --ad-hoc r-learnr`: > > ---snip--- > $ ministat -A -c 99 before_ssh after_ssh > x before_ssh > + after_ssh > N Min Max Median Avg Stdd= ev > x 10 20.104 21.629 21.082 21.0115 0.451424= 72 > + 10 16.082 16.713 16.292 16.3416 0.250182= 24 > Difference at 99.0% confidence > -4.6699 +/- 0.469719 > -22.2254% +/- 1.86734% > (Student's t, pooled s =3D 0.364949) > > $ ministat -A -c 99 before_unix after_unix > x before_unix > + after_unix > N Min Max Median Avg Stdd= ev > x 10 11.322 11.529 11.401 11.4127 0.0624678= 58 > + 10 11.249 11.469 11.3515 11.368 0.0786892= 62 > No difference proven at 99.0% confidence > ---snap--- Awesome, thanks a lot. Looks like the difference on Unix-domain sockets is not significant. Applied! What package provides =E2=80=98ministat=E2=80=99? Thanks, Ludo=E2=80=99.