bug#43078: linux-libre-arm64-generic lacks CONFIG_CGROUP_FREEZER=y

bug#43078: linux-libre-arm64-generic lacks CONFIG_CGROUP_FREEZER=y

[Vitaliy Shatrov]

Hello Guix.

I:
   1. had linux-libre-arm64-generic as my kernel.
   2. added only (elogind-service-type) to my Guix System's config.
   3. ran `guix system reconfigure`.
   4. get some errors: "///sys/something/freezer cannot be something".
   5. rebooted, and were unable to log-in (get no prompt).

The issue was solved by using the same linux-libre-arm64-generic, but
customized: i set a 'CONFIG_CGROUP_FREEZER=y' in kconfig.

As this is only one config related to logind that not enabled, i want us
to have it enabled by default on linux-libre-arm64-generic, or as Vagrant
wrote on IRC, "added to gnu/packages/linux.scm: %default-extra-linux-options".

I need logind for sway WM to work.. and probably for other things.

Thanks.

bug#43078: linux-libre-arm64-generic lacks CONFIG_CGROUP_FREEZER=y

[Leo Famulari]

On Fri, Aug 28, 2020 at 01:52:58AM +0700, Vitaliy Shatrov wrote:
> Hello Guix.
> 
> I:
>    1. had linux-libre-arm64-generic as my kernel.
>    2. added only (elogind-service-type) to my Guix System's config.
>    3. ran `guix system reconfigure`.
>    4. get some errors: "///sys/something/freezer cannot be something".
>    5. rebooted, and were unable to log-in (get no prompt).
> 
> The issue was solved by using the same linux-libre-arm64-generic, but
> customized: i set a 'CONFIG_CGROUP_FREEZER=y' in kconfig.

This option is enabled in all of our kernel configurations:

------
$ git grep CGROUP_FREEZER
gnu/packages/aux-files/linux-libre/4.14-arm.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/4.14-i686.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/4.14-x86_64.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/4.19-arm.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/4.19-arm64.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/4.19-i686.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/4.19-x86_64.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/4.4-i686.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/4.4-x86_64.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/4.9-i686.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/4.9-x86_64.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.4-arm.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.4-arm64.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.4-i686.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.4-x86_64.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.7-arm.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.7-arm64.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.7-i686.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.7-x86_64.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.8-arm.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.8-arm64.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.8-i686.conf:CONFIG_CGROUP_FREEZER=y
gnu/packages/aux-files/linux-libre/5.8-x86_64.conf:CONFIG_CGROUP_FREEZER=y
------

bug#43078: linux-libre-arm64-generic lacks CONFIG_CGROUP_FREEZER=y

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1.1: Type: text/plain, Size: 811 bytes --]

Leo, Vits,

Leo Famulari 写道：
> On Fri, Aug 28, 2020 at 01:52:58AM +0700, Vitaliy Shatrov wrote:
>> Hello Guix.
>> 
>> I:
>>    1. had linux-libre-arm64-generic as my kernel.
>>    2. added only (elogind-service-type) to my Guix System's 
>>    config.
>>    3. ran `guix system reconfigure`.
>>    4. get some errors: "///sys/something/freezer cannot be 
>>    something".
>>    5. rebooted, and were unable to log-in (get no prompt).
>> 
>> The issue was solved by using the same 
>> linux-libre-arm64-generic, but
>> customized: i set a 'CONFIG_CGROUP_FREEZER=y' in kconfig.
>
> This option is enabled in all of our kernel configurations:
>
> ------
> $ git grep CGROUP_FREEZER

Indeed, and the bug[0] reported here is that -generic doesn't use 
these configurations at all:


[-- Attachment #1.2: Type: text/plain, Size: 529 bytes --]

(define-public linux-libre-arm64-generic
  (make-linux-libre* linux-libre-version
                     linux-libre-source
                     '("aarch64-linux")
                     #:defconfig "defconfig"
                     #:extra-version "arm64-generic"
                     #:extra-options
                     (append
                      `(;; needed to fix the RTC on rockchip 
                      platforms
                        ("CONFIG_RTC_DRV_RK808" . #t))
                      %default-extra-linux-options)))

[-- Attachment #1.3: Type: text/plain, Size: 440 bytes --]


Note the missing #:configuration-file.

[0]: I don't know if this is really a bug--in fact I suspect it's 
the raison d'être of this variant--but this needs to be better 
documented and perhaps even renamed.  To me, ‘generic’ means 
‘distro default’, or perhaps ‘sanely minimal’, not ‘our own 
upstream's sometimes questionable defconfig that can't boot our 
own desktop’.

Allegedly.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#43078: linux-libre-arm64-generic lacks CONFIG_CGROUP_FREEZER=y

[Vagrant Cascadian]

[-- Attachment #1.1: Type: text/plain, Size: 1156 bytes --]

On 2020-08-28, Vitaliy Shatrov wrote:
>    1. had linux-libre-arm64-generic as my kernel.
>    2. added only (elogind-service-type) to my Guix System's config.
>    3. ran `guix system reconfigure`.
>    4. get some errors: "///sys/something/freezer cannot be something".
>    5. rebooted, and were unable to log-in (get no prompt).
>
> The issue was solved by using the same linux-libre-arm64-generic, but
> customized: i set a 'CONFIG_CGROUP_FREEZER=y' in kconfig.
>
> As this is only one config related to logind that not enabled, i want us
> to have it enabled by default on linux-libre-arm64-generic, or as Vagrant
> wrote on IRC, "added to gnu/packages/linux.scm: %default-extra-linux-options".

Given that this is present in all the "linux-libre" packages
(e.g. without arm-generic or arm64-generic ...), I think it makes sense
to add this to %default-extra-linux-options.

*Untested* patch attached.

I did at one point try to enable this on arm-generic and it required
additional features I couldn't track down... and at some point this was
enabled on arm64-generic (I tested on "pinebook" with arm64-generic a
while back).

live well,
  vagrant


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-default-extra-linux-options-Enable-CONFIG_CGROUP.patch --]
[-- Type: text/x-diff, Size: 1022 bytes --]

From d91a90a667262b6e0ab82542a28c48b70eee37fc Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@debian.org>
Date: Thu, 27 Aug 2020 14:47:43 -0700
Subject: [PATCH] gnu: %default-extra-linux-options: Enable
 CONFIG_CGROUP_FREEZER.

Fixes: https://issues.guix.gnu.org/43078

* gnu/packages/linux (%default-extra-linux-options): Enable
  CONFIG_CGROUP_FREEZER.
---
 gnu/packages/linux.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 26ce379568..1f6236163f 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -641,6 +641,8 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
     ("CONFIG_USER_NS" . #t)
     ("CONFIG_PID_NS" . #t)
     ("CONFIG_NET_NS" . #t)
+    ;; cgroup freezer needed for elogind: https://issues.guix.gnu.org/43078
+    ("CONFIG_CGROUP_FREEZER" . #t)
     ;; Modules required for initrd:
     ("CONFIG_NET_9P" . m)
     ("CONFIG_NET_9P_VIRTIO" . m)
-- 
2.20.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#43078: linux-libre-arm64-generic lacks CONFIG_CGROUP_FREEZER=y

[Vagrant Cascadian]

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

On 2020-08-27, Vagrant Cascadian wrote:
> On 2020-08-28, Vitaliy Shatrov wrote:
>>    1. had linux-libre-arm64-generic as my kernel.
>>    2. added only (elogind-service-type) to my Guix System's config.
>>    3. ran `guix system reconfigure`.
>>    4. get some errors: "///sys/something/freezer cannot be something".
>>    5. rebooted, and were unable to log-in (get no prompt).
>>
>> The issue was solved by using the same linux-libre-arm64-generic, but
>> customized: i set a 'CONFIG_CGROUP_FREEZER=y' in kconfig.
>>
>> As this is only one config related to logind that not enabled, i want us
>> to have it enabled by default on linux-libre-arm64-generic, or as Vagrant
>> wrote on IRC, "added to gnu/packages/linux.scm: %default-extra-linux-options".
>
> Given that this is present in all the "linux-libre" packages
> (e.g. without arm-generic or arm64-generic ...), I think it makes sense
> to add this to %default-extra-linux-options.
>
> *Untested* patch attached.

Tested and added some more kernel options needed for
linux-libre-arm-generic on armhf as well.

Pushed a fix as 450dcd1aff741c4f81cc9508ce33f19e62edefb7.

Thanks for reporting the issue!


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]