From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 5FGaH6efc1/bZAAA0tVLHw (envelope-from ) for ; Tue, 29 Sep 2020 20:57:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yIggG6efc1/1dQAAbx9fmQ (envelope-from ) for ; Tue, 29 Sep 2020 20:57:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 065189402A6 for ; Tue, 29 Sep 2020 20:57:11 +0000 (UTC) Received: from localhost ([::1]:54436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNMgP-0004iq-J7 for larch@yhetil.org; Tue, 29 Sep 2020 16:57:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNMgI-0004hV-7v for guix-patches@gnu.org; Tue, 29 Sep 2020 16:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNMgH-0000EC-UU for guix-patches@gnu.org; Tue, 29 Sep 2020 16:57:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNMgH-0000BL-U1 for guix-patches@gnu.org; Tue, 29 Sep 2020 16:57:01 -0400 Subject: bug#43699: [PATCH] guix: Fix argument order of fxbit-set? Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 29 Sep 2020 20:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43699 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 43699-done@debbugs.gnu.org Mail-Followup-To: 43699@debbugs.gnu.org, ludo@gnu.org, ldb@leibniz-psychology.org Received: via spool by 43699-done@debbugs.gnu.org id=D43699.1601412977641 (code D ref 43699); Tue, 29 Sep 2020 20:57:01 +0000 Received: (at 43699-done) by debbugs.gnu.org; 29 Sep 2020 20:56:17 +0000 Received: from localhost ([127.0.0.1]:57312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNMfZ-0000AH-KR for submit@debbugs.gnu.org; Tue, 29 Sep 2020 16:56:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNMfX-0000A4-Q2 for 43699-done@debbugs.gnu.org; Tue, 29 Sep 2020 16:56:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47615) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNMfS-00009V-Dt; Tue, 29 Sep 2020 16:56:10 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57494 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kNMfR-0004ug-JE; Tue, 29 Sep 2020 16:56:10 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200929082923.GA7294@zpidnp36> Date: Tue, 29 Sep 2020 22:56:08 +0200 In-Reply-To: <20200929082923.GA7294@zpidnp36> (Lars-Dominik Braun's message of "Tue, 29 Sep 2020 10:29:23 +0200") Message-ID: <87d024480n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.99 X-TUID: mjfx7tzmPZ6m Hello! Lars-Dominik Braun skribis: > * guix/openpgp.scm (port-ascii-armored?): Fix it here=E2=80=A6 > (get-packet*): =E2=80=A6and here=E2=80=A6 > (parse-subpackets): =E2=80=A6and also here. > * tests/openpgp.scm (%binary-sample): New test vector. > ("port-ascii-armored?, #t"): Add test. > ("port-ascii-armored?, #f"): Add another test. Good catch! The root problem is that the =E2=80=98fxbit-set?=E2=80=99 alias defined at = the top of openpgp.scm had the arguments swapped compared to =E2=80=98bit-set?=E2=80= =99. So I changed that alias instead of changing its users (=E2=80=98fxbit-set?=E2=80= =99 is defined in R6RS). Pushed as 680b80e37453d4e23ad8188d60894916e1c07162 along with the new tests. Thank you! Ludo=E2=80=99.