From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CAHrJIFFdl9MNwAA0tVLHw (envelope-from ) for ; Thu, 01 Oct 2020 21:09:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ID6QIIFFdl/dDgAAB5/wlQ (envelope-from ) for ; Thu, 01 Oct 2020 21:09:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ECD209402B2 for ; Thu, 1 Oct 2020 21:09:20 +0000 (UTC) Received: from localhost ([::1]:59012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO5pH-0000fq-CO for larch@yhetil.org; Thu, 01 Oct 2020 17:09:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO5p0-0000fc-J8 for bug-guix@gnu.org; Thu, 01 Oct 2020 17:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO5p0-00068X-AW for bug-guix@gnu.org; Thu, 01 Oct 2020 17:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kO5p0-0001It-6A for bug-guix@gnu.org; Thu, 01 Oct 2020 17:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 01 Oct 2020 21:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43746 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: "pelzflorian (Florian Pelz)" Received: via spool by 43746-submit@debbugs.gnu.org id=B43746.16015864844944 (code B ref 43746); Thu, 01 Oct 2020 21:09:02 +0000 Received: (at 43746) by debbugs.gnu.org; 1 Oct 2020 21:08:04 +0000 Received: from localhost ([127.0.0.1]:38579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO5o3-0001Hg-Ph for submit@debbugs.gnu.org; Thu, 01 Oct 2020 17:08:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO5o1-0001HD-HG for 43746@debbugs.gnu.org; Thu, 01 Oct 2020 17:08:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33629) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO5nw-000651-8d; Thu, 01 Oct 2020 17:07:56 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52582 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kO5nv-00045I-Sk; Thu, 01 Oct 2020 17:07:56 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> Date: Thu, 01 Oct 2020 23:07:54 +0200 In-Reply-To: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Thu, 1 Oct 2020 16:31:36 +0200") Message-ID: <87d021mz85.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43746@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: pjWL2i9enhR9 Hi, "pelzflorian (Florian Pelz)" skribis: > The new package transformation option --without-tests works by setting > #:tests? #f in the specified packages. But some packages replace > their 'check phase and no longer honor #tests?. glib for example. Oh, we should fix =E2=80=98glib=E2=80=99 in =E2=80=98core-updates=E2=80=99. > Attached is an attempt to document this current behavior. Shall I > push it? Alternatively, it should be documented to write a check > phase that honors #:tests?. Or the package transformation should be > changed to remove any check phase it finds. Hmm not sure, I think fiddling with phases is more risky or at least could lead to more obscure errors for example with build systems that don=E2=80=99t support phases, like =E2=80=98trivial-build-system=E2=80=99. I=E2=80=99m inclined to apply the patch you propose and leaving phases unchanged. >>>From b55e6ee01fe674b282e7ec75d0e4c8a839262261 Mon Sep 17 00:00:00 2001 > From: Florian Pelz > Date: Thu, 1 Oct 2020 15:35:52 +0200 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > Subject: [PATCH] doc: Explain why '--without-tests' may fail with modified > 'check' phase. > > * doc/guix.texi (Package Transformation Options): Explain. [...] > +Internally, @code{--without-tests} relies on changing the > +@code{#:tests?} option of a package's @code{check} phase (@pxref{Build > +Systems}). Note that some packages use a customized @code{check} phase > +that does not respect a @code{#:tests? #f} setting. Therefore there are > +some packages for which @code{--without-tests} cannot disable tests. I=E2=80=99d change the last sentence to: Therefore, @option{--without-tests} has no effect on these packages. Thanks, Ludo=E2=80=99.