From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 43261@debbugs.gnu.org
Subject: [bug#43261] [PATCH 2/2] lint: Add '--no-checkers' option.
Date: Wed, 28 Oct 2020 16:18:13 +0100 [thread overview]
Message-ID: <87d0121iru.fsf@gnu.org> (raw)
In-Reply-To: <20200907180415.30140-2-zimon.toutoune@gmail.com> (zimoun's message of "Mon, 7 Sep 2020 20:04:15 +0200")
Hi,
zimoun <zimon.toutoune@gmail.com> skribis:
> * guix/scripts/lint.scm (%options, parse-options): Add '--no-checkers' option.
> * doc/guix.texi: Document it.
Please mention the section name (in the manual) and variable names.
> +(define (option-checker short-long)
> + (option short-long #t #f
Indentation is off. Also please add a docstring.
> + (lambda (opt name arg result)
> + (let ((names (map string->symbol (string-split arg #\,)))
> + (checker-names (map lint-checker-name %all-checkers)))
> + (for-each (lambda (c)
> + (unless (memq c checker-names)
> + (leave (G_ "~a: invalid checker~%") c)))
> + names)
> + (alist-cons (string->symbol (cadr short-long))
Use ‘match’ instead of ‘cadr’, or maybe make it a parameter of this
procedure?
Thanks!
Ludo’.
next prev parent reply other threads:[~2020-10-28 15:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 18:02 [bug#43261] [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options zimoun
2020-09-07 18:04 ` [bug#43261] [PATCH 1/2] lint: Fix '--no-network' option zimoun
2020-09-07 18:04 ` [bug#43261] [PATCH 2/2] lint: Add '--no-checkers' option zimoun
2020-10-28 15:18 ` Ludovic Courtès [this message]
2020-10-28 16:58 ` zimoun
2020-09-08 7:56 ` [bug#43261] [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options Efraim Flashner
2020-09-08 9:16 ` zimoun
2020-10-28 15:13 ` Ludovic Courtès
2020-10-09 20:39 ` zimoun
2020-10-28 16:51 ` [bug#43261] [PATCH v2 1/2] scripts: lint: Fix '--no-network' option zimoun
2020-10-28 16:51 ` [bug#43261] [PATCH v2 2/2] scripts: lint: Add '--exclude' option zimoun
2020-10-29 23:28 ` bug#43261: " Ludovic Courtès
2020-10-29 23:25 ` [bug#43261] [PATCH v2 1/2] scripts: lint: Fix '--no-network' option Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0121iru.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43261@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.