From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sPSXJ065S2DOTwAA0tVLHw (envelope-from ) for ; Fri, 12 Mar 2021 18:56:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mCtpI065S2DfIwAA1q6Kng (envelope-from ) for ; Fri, 12 Mar 2021 18:56:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03C7A2272B for ; Fri, 12 Mar 2021 19:56:13 +0100 (CET) Received: from localhost ([::1]:57324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKmxJ-0005tq-12 for larch@yhetil.org; Fri, 12 Mar 2021 13:56:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKmjk-0005rT-Lp for guix-devel@gnu.org; Fri, 12 Mar 2021 13:42:12 -0500 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:34455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKmji-0003yP-MC; Fri, 12 Mar 2021 13:42:12 -0500 Received: by mail-pg1-x52c.google.com with SMTP id l2so16434721pgb.1; Fri, 12 Mar 2021 10:42:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ir9YuM8VL3YKZFEckfEH5sIoJgVR6T/PP8mbLEQzeq4=; b=ZkZeEr44xhCFUfLon3B843uIfRVKv9ggNpHu22IAdt0NnJ5dQG5QyCp91Jqoy9rCpH VJCX0+Cocf9/S2fIJFMbIBJpMj+dx8UHQJEtElUr0HDVJVc3y1XQjlxBhaR06gZm4kDM vO+quMyuT99n3TL/6cvJ+OpBH5TpDZw7XoZS674sqJzGgJhRprK6QwNRXTntLEubKl1D dkIt/91xnIVeRu0dhiG9EtKFH6NEKH0taUOdDlpA9O2p7lw0z4EoMDiu/qoWwuwrMVJ2 1n24/84PXIjsfbWHSlAkX+D2DgrKfdkb/9c/5zGbkFTzWAuLGnXUbk9PVvrmRw0aEpBm 2cNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ir9YuM8VL3YKZFEckfEH5sIoJgVR6T/PP8mbLEQzeq4=; b=pNRaIY5dCuh7ne2dFhI9o5ETdbCWw9K6omOl16/Ny4X38peQxhVkMiG5xxiNWdtjh2 DidNWvJYI/I7FDjJg0sWsowykx587IhAnBBLldxkj8KjwyvhI9JlJiCF3ov1luNXUIYL ZRZHWdUuEmC8nMfzwJC/SOT6nMtQd3i49+2bTLaDAFGs2sd8VVTTMbviFXGDVf7z5GAp +EIKuzcPpPOSCAmtunIPiDCX2lwKjhnssDxOkVcHm72EFVEcVesFXoak96jgN9Db46EO 4UgJ9hHkpKualHS9L+1VzMUqTHL3ZSsLAJ0VY6m+JSDIlz94IAcvbEcJmdRQX0rrnLo9 jfMA== X-Gm-Message-State: AOAM533WU0ro00SoYrBrl0GKdXH7Ljmv0HwY87z1xWUH4uthKETREwdV evL2yy26kAcHNGSml4Czt2yd1khRWIyTukzu X-Google-Smtp-Source: ABdhPJwzhELzzWNjD+cMaxdOWUyMaUhdbEkWS+1S7JV4bCTWSv7m360NmX035GkxnH1IDE47gdOzPg== X-Received: by 2002:a63:2948:: with SMTP id p69mr12996415pgp.15.1615574527904; Fri, 12 Mar 2021 10:42:07 -0800 (PST) Received: from garuda-lan (c-24-18-44-142.hsd1.wa.comcast.net. [24.18.44.142]) by smtp.gmail.com with ESMTPSA id x14sm6358516pfm.207.2021.03.12.10.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 10:42:06 -0800 (PST) From: Chris Marusich To: Vincent Legoll , Andreas Enge , Efraim Flashner Subject: Re: Release on April 18th? References: <87im6042fr.fsf@gmail.com> <875z1y3vj0.fsf@gmail.com> <87im6042fr.fsf@gmail.com> <86sg53cf58.fsf@gmail.com> <87a6ra3w39.fsf@gmail.com> <87h7lgzs8h.fsf@gmail.com> <87im6042fr.fsf@gmail.com> <86sg53cf58.fsf@gmail.com> <87a6ra3w39.fsf@gmail.com> <87h7lgzs8h.fsf@gmail.com> Date: Fri, 12 Mar 2021 10:42:02 -0800 In-Reply-To: (Vincent Legoll's message of "Fri, 12 Mar 2021 09:02:02 +0100, Fri, 12 Mar 2021 11:11:39 +0100, Fri, 12 Mar 2021 15:43:26 +0200") Message-ID: <87czw4z01x.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=cmmarusich@gmail.com; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615575374; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ir9YuM8VL3YKZFEckfEH5sIoJgVR6T/PP8mbLEQzeq4=; b=Ezqm0+nK+EDhcIlRnkbTtj23/K94Z/n1AcYJ0FRuKXvkizvswxX6F0loDmTdhBBSDagD4l r4p3sx5JXEwnuT3ZIc50w1H0e7ZqeOO+cRURmgr+2y24YYJisSTZHM4q3XIz1oW0qkVHgr CEwqmJYPFcFQvp8+DKT1YleWHeYFkO83S1BWxDNTbnYe7V0rjEuGY5jkmqzN4FIRouQy+U cVEaa+P0yXeyglxdKq6kRaPujYWFHdcsLm9qNmy4RkcYx+DJ9ptRhVsk1lOvp5aeaeocsQ dWGlK539AhxxdYAvAWiVkHfeuACVC/O4HlDqdOYRIwsNW88UYdTUlChOzEmBrQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615575374; a=rsa-sha256; cv=none; b=ipfH8iNw3PCGt2RizzapPUbWT1pAB1RJadFz2/eV5G9f2OTmMN8Ov6zOnOWn19B7uJvNoX EkfM/yxtPMVV52Nx5CcM4+UCtVcFQhV1ylte8RzbAwQk7m5EIl6+U3YshDzpUz0MIG9MxI aWL7YebhR//VBXqcap93L3GQPl5ZTPanzSneFeqerqm76/eqsmMkgdUwjKV+ihy3LwPc5+ e5Ghu+KNv0v7S9eWhQylkmurn/h9V3Bw6HSOtWzJUd7Tda7abZ3Lxbg8VJz6R9az9GhhXp qvwyXTB5bq0m9pbDnKtbvxiGHJriQPpAEp86MloO9vsPEbD/V3cd2wLK3CXU+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ZkZeEr44; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.89 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ZkZeEr44; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 03C7A2272B X-Spam-Score: -0.89 X-Migadu-Scanner: scn0.migadu.com X-TUID: 0ymXlc8LiMAv --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hi, Vincent Legoll writes: > I rebuilt guix on core-updates with gcc-8 succesfully > I'll now try the same above wip-ppc64le. Awesome! Thank you for doing this. I'm sure there will be some bumps, and the sooner we can fix them, the easier it will be to integrate later. I'm still working on getting you access to ppc64le hardware or a VM. Andreas Enge writes: > Am Fri, Mar 12, 2021 at 12:33:18AM -0800 schrieb Chris Marusich: >> The proc man page has this to say about column 7: >> (7) optional fields: zero or more fields of the form "tag[:value]" > > And it goes on like this: > (8) separator: the end of the optional fields is marked > by a single hyphen. > > So it looks like it is enough to search for a hyphen surrounded by spaces. > The hyphen is apparently there also when there is no optional field (7), > as can be seen from your examples and also my own system, where both occur > in parallel: > 34 26 253:0 /gnu/store /gnu/store ro,noatime - ext4 /dev/mapper/cryptroot rw > 51 26 253:0 /var/lib/docker /var/lib/docker rw,relatime shared:1 - ext4 /dev/mapper/cryptroot rw > > Alternatively, one can also count from the back to get the fields labelled > (9) to (11) (which may be (8) to (10) in case there are no optional fields). > (I was momentarily confused by "(12) super option*s*"; but these are > apparently separated by commas and not whitespace.) That's true. How about the following patch? It fixes the issue for me on my systems, and I manually tried out the new match pattern with some lines from Leo's output, and it seems to behave correctly. If nobody has concerns, I'd like to apply it to master directly, since the tests are already failing there on some systems, like mine. Here's the patch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-syscalls-mount-Fix-a-matching-bug.patch Content-Transfer-Encoding: quoted-printable Content-Description: [PATCH] syscalls: mount: Fix a matching bug. From=205417f68ee5892f6a587895105854cadf29eb7297 Mon Sep 17 00:00:00 2001 From: Chris Marusich Date: Thu, 11 Mar 2021 23:19:30 -0800 Subject: [PATCH] syscalls: mount: Fix a matching bug. On some systems, the columns in /proc/self/mountinfo look like this: 23 28 0:21 / /proc rw,nosuid,nodev,noexec,relatime shared:11 - proc proc rw Before this change, the mount procedure was written with the assumption that the type and source could always be found in columns 8 and 9, respectively. However, the proc(5) man page explains that there can be zero or more optio= nal fields starting at column 7 (e.g., "shared:11" above), so this assumption is false in some situations. * guix/build/syscalls.scm (mount): Update the match pattern to use ellipsis= to match zero or more optional fields followed by a single hyphen. Remove the trailing ellipsis, since multiple ellipses are not allowed in the same leve= l. The proc(5) man page indicates that there are no additional columns, so it = is probably OK to match an exact number of columns at the end like this. =2D-- guix/build/syscalls.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm index 552343a481d..726c8e86d06 100644 =2D-- a/guix/build/syscalls.scm +++ b/guix/build/syscalls.scm @@ -621,8 +621,9 @@ current process." (if (eof-object? line) (reverse result) (match (string-tokenize line) + ;; See the proc(5) man page for a description of the colum= ns. ((id parent-id major:minor root mount-point =2D options _ type source _ ...) + options _ ... "-" type source _) (let ((devno (string->device-number major:minor))) (loop (cons (%mount (octal-decode source) (octal-decode mount-point) =2D-=20 2.26.2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Efraim Flashner writes: >> Something about the way in which we are searching for the patch is off, >> but I don't have time just now to investigate. Efraim, if you can >> figure it out, that'd be nice, but I'll look into it more tomorrow. >> It's probably something simple and related to commit 2712703. > > Leo told me about it yesterday and I pushed a second commit that fixed > it. We needed to make sure the patch file was included as an input, > that's why it got #f instead of a string. In any case, commit > 710cfc330a7ed06934a193583b159fbdf07bf2fe takes care of it; it's the > combination of 2712703 and the squash commit. > > I'm now running make guix-binary.powerpc64le-linux.tar.xz and so far > it's made it past the initial building stages, we're on to building the > grafts now. Thank you. This fixed the patch-related problem for me, too. I'm currently running "make guix-binary.powerpc64le-linux.tar.xz", also, on my Debian ppc64le machine. We'll see how far it gets - fingers crossed! =2D-=20 Chris --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmBLtfoACgkQ3UCaFdgi Rp1Avw//XFWm3HeTAOJKfpDR+l0iPjUWoFGYM2kvgF8ILoEQyur2x6O6AjhAnh7O uwUwbfuBYEDDI+KFBAygJM33eb5EViBSPtI2bhHJeKDQaA6gEaO0MJGD21O45pnD 6LdiJ2tK4kVj48SbVzFJzmlUh9RvqIc2cBlNjPcsfBp9ujTpUKdcdVvuGjeW2MMO 7wKvKBt7GD7PQIdho6DrN/3PGHAp7jgnJ+71S68ztuK9TzJItAYt0mGP+cQOsjvE xRV7ZAfp482g9KBXqmBiXub63c+06J8oqEanrIFk3o0gjiOZ5NvPS97TMum/UuHP 72x5cb6Exkbhb8w/kxIB1K9ptAJRi9y2Knqo6ugU+1cF+6LpZ8IKk6sJW5emznrw J4E6TVbDAHJJfvEsToyyZDra0o3SND9JJkQoRyP+moAq6qnYq2ordu858mt7AcnJ O/Jr+NwCGYTBctzThKJXk9FODaj+KcOpyge0/L05JwYFrH+Yva3XJ8cA/P+bPRDw ChiS7Fz+9506jqwztz5eGJOQCI7/0UYv0Z8fIxgcIvIEuKQLwN9nAXld5oPoPfJi kZfvuUV4D375vj28IctttALDprzLJNZSNXnHXh++OFjkgm9ewlq11puC4bYE/hXb +x3oIxuiLj4OJ8/E/UzX9fn/PbdEAVsPg+HMmy7gnoC0bMRM4QY= =mV7V -----END PGP SIGNATURE----- --==-=-=--