From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8Eg/I7FbZWEM5wAAgWs5BA (envelope-from ) for ; Tue, 12 Oct 2021 11:56:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2NIjHbFbZWFLLgAAB5/wlQ (envelope-from ) for ; Tue, 12 Oct 2021 09:56:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F1CF62F1AA for ; Tue, 12 Oct 2021 11:56:00 +0200 (CEST) Received: from localhost ([::1]:57998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maEVs-0001Dg-1O for larch@yhetil.org; Tue, 12 Oct 2021 05:56:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maEOA-0002dp-V0 for bug-guix@gnu.org; Tue, 12 Oct 2021 05:48:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maEOA-0000Nv-BG for bug-guix@gnu.org; Tue, 12 Oct 2021 05:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maEOA-0000ub-2N for bug-guix@gnu.org; Tue, 12 Oct 2021 05:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#51021: detect loops in module/package graph Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 12 Oct 2021 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51021 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun Received: via spool by 51021-submit@debbugs.gnu.org id=B51021.16340320703487 (code B ref 51021); Tue, 12 Oct 2021 09:48:02 +0000 Received: (at 51021) by debbugs.gnu.org; 12 Oct 2021 09:47:50 +0000 Received: from localhost ([127.0.0.1]:33526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maENy-0000uB-48 for submit@debbugs.gnu.org; Tue, 12 Oct 2021 05:47:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maENx-0000th-E7 for 51021@debbugs.gnu.org; Tue, 12 Oct 2021 05:47:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59932) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maENr-00009w-M3; Tue, 12 Oct 2021 05:47:43 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=50950 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maENo-0002bQ-L5; Tue, 12 Oct 2021 05:47:41 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20211005025819.3f7756d7@riseup.net> <87czojkilc.fsf@netris.org> <87o881c6b3.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 21 =?UTF-8?Q?Vend=C3=A9miaire?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 12 Oct 2021 11:47:39 +0200 In-Reply-To: (zimoun's message of "Mon, 11 Oct 2021 09:49:00 +0200") Message-ID: <87czoawp50.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 51021@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634032561; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=cdPmkofWEnUubVLwb2lapzMhj5Gb0/l02y2HLUa0a0k=; b=SdgLbANsnN/OO4LJEaadbiWbUEj7GbKJXNkg4w/XdRpX8dI6oA1YKrpRbtblMS4LrEjjlI 5oPymmkdJFad4sv21bj5pR6S6QGglL3CC4YLRREydUCm2dDS6t90+8HZ9cY6yWw7+3odXb jhhF5If1YjiCUKtRztta90XfWTfaFJZHhOaXBpLdyCmqDAMAhXe1S8u8vT7D0jt+e2UzyJ vR6Jr8m9DajLQ0TjUzDLVWtTWO+KwEsbEuHGUMdCArzqFweuep4G33Rkjgi08KUT2kYW6A VMWDMl7E1oCRMIN4fAWdALtPetfHlSDDxzVbQ9AMcpOSVLjz6g5ws91XVouQGQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634032561; a=rsa-sha256; cv=none; b=ZSjQJo2U7liyLfBVB4A1uSjBeHZ5pf3/D6WnMIkMhYSI5vLJfmBTLKbmiz8P+FNd5Z4Va3 W+vSmKL9bsxX+q3mlwmJgP3Vi2cpXS2TjrCqvLueK5i4OGdmQz+qc0REl7H4WV/J1jyfo9 jsAht3oCqcMSdVi8sGVZe5XmYxT9axrzUV4d8pKhmWihlH18J1MnPQE0asFfhqO/dUlMVb 3flve0cWaQML+MdPJX+VsPf/MHI+E2gych4OA4+vrqe9YuKMYV+dRDKq19/9kSSwNvi0+X O+FiAKfLbIAXJpm+kwJBs+HINBiSTy4kCAe/CENL2s8pcx1LJqbjCDsdAqUuaA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: F1CF62F1AA X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6CiFmVralROU Hi, zimoun skribis: > What Mark had implemented [1] works for any directed graph. What do > you mean by "top-level references"? Reference to variables coming from one module of an SCC that appear at the top level of another module in the SCC. >> Chris Baines proposed a patch a while back to report those, though I >> can=E2=80=99t find it anymore. IIRC, the difficulty was in making sure = cycle >> detection would not be too expensive, and in keeping a readable style. > > From my memories about Graph Theory, the algorithm Mark is proposing > is an efficient way to detect cycles What I meant is that =E2=80=98package-derivation=E2=80=99 traverses the pac= kage graph, so it=E2=80=99s a natural place to add cycle detection. But since =E2=80=98package-derivation=E2=80=99 is so central, care must be = taken about the performance hit and about its readability. Thanks, Ludo=E2=80=99.