From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EPxyMLBYnWH+FAAAgWs5BA (envelope-from ) for ; Tue, 23 Nov 2021 22:10:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uNX6K7BYnWFkFgAAbx9fmQ (envelope-from ) for ; Tue, 23 Nov 2021 21:10:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 83133DA72 for ; Tue, 23 Nov 2021 22:10:08 +0100 (CET) Received: from localhost ([::1]:49532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpd3G-0005ZV-JH for larch@yhetil.org; Tue, 23 Nov 2021 16:10:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpd3C-0005ZK-TL for guix-patches@gnu.org; Tue, 23 Nov 2021 16:10:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40851) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpd3C-0007g6-L7 for guix-patches@gnu.org; Tue, 23 Nov 2021 16:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpd3C-00067r-6X for guix-patches@gnu.org; Tue, 23 Nov 2021 16:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 23 Nov 2021 21:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timothy Sample Cc: 51838@debbugs.gnu.org, Pierre Langlois , Philip McGrath , Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163770179523528 (code B ref 51838); Tue, 23 Nov 2021 21:10:02 +0000 Received: (at 51838) by debbugs.gnu.org; 23 Nov 2021 21:09:55 +0000 Received: from localhost ([127.0.0.1]:52397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpd35-00067Q-CL for submit@debbugs.gnu.org; Tue, 23 Nov 2021 16:09:55 -0500 Received: from mout.gmx.net ([212.227.17.20]:41233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpd31-000677-KP for 51838@debbugs.gnu.org; Tue, 23 Nov 2021 16:09:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1637701779; bh=yOPHf0Dkn7OLFqAaFEaiZZ90ybOW5WFtI0oOUu0e/n0=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=Y5ubfdoM0M5OqVtWgC5JmAfieOVQnEz0/4suZXZ9N47UqKUB8GrmYMmrbqbV99Z9c XHgnBQ44F8YKaLg6JbMaj/RS7/9DRIBDHkcq5MvGEIcaVP7vjWN6RJjQkMDYsOW8mr 6ydZcJQLQ+LAlpb3i1MFkPK8qD3hLCUv8/fJXstU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mxm3K-1mQvgj0K2I-00zDD2; Tue, 23 Nov 2021 22:09:39 +0100 References: <20211114125830.45427-1-philip@philipmcgrath.com> <20211114130409.49241-1-philip@philipmcgrath.com> <20211114130409.49241-2-philip@philipmcgrath.com> <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@gmail.com> <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <87tug6bnen.fsf@ngyro.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Pierre Langlois Date: Tue, 23 Nov 2021 20:54:26 +0000 In-reply-to: <87tug6bnen.fsf@ngyro.com> Message-ID: <87czmqk29d.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:jHm32sgjaI+KguHwQBpbxAGPYWGnZEQDhuAGfzT43xZQP11p95a GOVvh0q7cL4IN/6rUvO8FWk9M/PYdJOGQQSYgk0TfeBeXo5apJOHgy+J1voTPT5sN1ugS+f 5N/qinX89fWGxp9TCdqHNACivGwLcPcQ52W7Q4Ki5q46tX6lnd65Wb40yPkWW37XmhL01pA cnGYztzcOCdgt4tsm+jjg== X-UI-Out-Filterresults: notjunk:1;V03:K0:Wp8yutE+c7I=:Q+SOXaP0rdK0l4RuPi7Rss eeFwBwpMbqa6AOCBrFLeWw9CNEqqg0xtIWunbvO4hZgmqWCKTg6fRppKsRgB9qd5Zhw4qehoi Py4XJnh7Yz2lXS6//idwNSZI1KKesRYvs04fkS9VqmyJUxtXoxmBNVmWP5qik4w4Y+L95hVIb vWkM0XIB06D0T9edoAKqKqxtE7Xba0iiHYNf8i/XmrSb5ZehCnir2XwE+XH5zOVlT6RokyR8m m1iBNwqZO6PCkAwrzloKwMxsNTDhGwR1blsg4qENOWmU6Hfxi3ppv/qG5bH2kryelBZkNYOg5 2qXDbfaNvouROpizjkjtJI9DkvRrRpBj2XL8CbqL6bN0AwtJza9V2/2trVTzFikqN7aLNUHVL NbMZ+k5Per28bddOGxhw/uThAC7C05gNx9DtSqQgzapAWLkHaDPj360sap4eR/U3DoulOgiy5 i0gKdtcj3li+6CDJeeTiH4LIGSLqmMydi74g9Dzje5Rc2Q0dXaEzlhDCpg2rU5lkobfNexVOp YpJw6e43460xItPR29CUa8u0y1vUoU/oTLoQvbCmJUIj92oDGfaS0+sZf5vW3pgBLS+MWEelc tLQiQPugRH3WVun4nK0QOVU3WZDUAF8ce+EVObDFnOB3FdkAqSxU2sluQeSv/lvUsra9F+ZD2 1oN+X/ePfjkTO0DuhTIT07mPUeYtLj7QwWKd3JAXRMEtVhW38uXNvE/zlhfhHX8s7QZxU1ZeR C9efUGjLO2HIu9jMxa2Nf7mEC7YuUL+1pB5pnYsVaAVRTAV95eXl3iSPo5jXgNq3+XAHFwt+7 llT9yvA/7LMybomD/pgW3PUD5FOLA9bDpRjIrXd/53MGhcWm+CUiJS7bwIsQAhd5yR7kcI1cY yFXhXVQDUc826eEMO5IoFvyhmGUwDnC+2dlV1VzvxoEqvhxLUz3Da0rO9na76jV7x0rjnFMWI PKbUhjyVdLFSQHpx/+Krh4pU70tp6kfsr0sKxIQTnXdIpCB4lMuRSLbOzTtgF9TwUZv/7UePe M1WgOoOTYuQv8+wCIYnEvX1IZZmXtMecYhKN+oxF3Qqs9pSxblz13r5hMyNcda/V5bp1z90Tr xS7EPAXMxNvWU4= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637701808; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Z9To3cKO63maLkqnCGUmrytDQByMHcJd4mMTgDfVVQE=; b=JkS6A2/yBclfbZsXFtVtL5ykk2CGCaUjcMwck5J1/dOXfj6Lfn4NFc2vMIb3NP33aWCK02 XZhyJQChlMJaRXfbyJSxoLqkJFpecXUBbbH/2+RCiLbfp70jP/36+U75ebp7ZcwrQ2RMti 6SzttsOko08/q7+wHMp4ESYCbOuXkmQlj1Tt4V6DrEvrnBt8vEkAmWxFhwwBj6mOS5HYdc XuWWp3h50qR2oNuRix72CZaapydpEPezGsdWUF063ZPFiC+WE7qpAsoxMnRXm7xNd1nhMv XxWDSBgYBlbt64TalPzPwiZU5LLyI2cieh6it3vE9zoKVZA/U+X25SYrszK1IQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637701808; a=rsa-sha256; cv=none; b=qiGj/TafxzefeT+6uTqscmZkUbbTQVclgPUwwYhDnPlO0XrgQczgbyPa1nibDcQBNMBSPw caigoftunq4NRBo80gUZ1ezgaHxpP3y0ZN8tN8DzLntykJkheCCymXLUmWJW1/zFRJlTAo d9pYifmvxpCqJqZwGfiPghJWzQNakBkSDRULiZdk0j/6vu9qbpGCOGcZW28mX2pTUMygpw qf+LN3axD/GunMkb03oKNiSOlqHfy5CFVA3EHWEjzZCIcvrD6TPKOGUB1v6m9AsA3jXbJt gRy9614cFdB2e20q+XTHJ6K4aRrLPRSKP0Bvtpb9PaSZCT4+dgXEph3CQLDfiw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=Y5ubfdoM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=Y5ubfdoM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 83133DA72 X-Spam-Score: -2.39 X-Migadu-Scanner: scn1.migadu.com X-TUID: ylGPl+rtM5Ic --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Timothy, Timothy Sample writes: > Hi Philip, > > There are some really valuable changes in here, thanks! I would like to > start understanding and reviewing the changes so that we can get some of > this good stuff merged in. However, I have one question that I couldn=E2= =80=99t > answer from reading here or at : is > there an agreement between you and Pierre that these patches are the > =E2=80=9Cright=E2=80=9D way to do native addons for Node.js. More import= antly, is the > general plan that we merge these changes, and then Pierre rebases their > Tree-sitter changes on top these? > > Pierre, maybe you could weigh in here? The overall approach looks good to me, it's better than what I originally proposed for sure :-). That being said, I'm not very familiar with the Node.js ecosystem so I don't know if it's necessarily the right way, but I suspect the correct way for node isn't very Guix-y so I'm not too worried about that. It's on my TODO list to take another look at the patches as well :-), then yes, I'm planning on rebasing my tree-sitter series on top. > Sorry if I missed something. I assume everything is OK, but I want to > be sure before I start digging into the details of the patches =E2=80=93 > especially those first few more complicated ones. :) Thanks for taking a look! Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmGdWI4YHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UeigH/27lKcqCARHJuK4pZ6W1nT9M Jn3dN6+VYNp2MZHlQ2OVQopytBCxMKuQoBnmakt9ifanZknzHWo1E5qOMuAJH16S mV8/rmZphJTafMuq2ZVhE5iibt4ICgnDwtGi5s0jsl0Ku75I6AFImcC88NpXmkWC PlesI3gG6IpSV5uMJ/Fk4ufCSzXA8V+zpTHmQo0fayplEVfLGYySdluLP3H3+LIV 4s+3L2zaIhl1jUNO1djieBOCXYHqXuBMEiDyNLqVGQqCRbW+CYb8odB0QfRPG544 pJSg04xhclJkhkfsbOX1+7UzsmWHB0kgHPJELEZnwzN0aCgh/YcXL8awHFUa/Jc= =9JOK -----END PGP SIGNATURE----- --=-=-=--