From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AG9xM/kktmGKHwEAgWs5BA (envelope-from ) for ; Sun, 12 Dec 2021 17:36:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cJn0LvkktmF9MAAAbx9fmQ (envelope-from ) for ; Sun, 12 Dec 2021 16:36:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3CF671E0FA for ; Sun, 12 Dec 2021 17:36:09 +0100 (CET) Received: from localhost ([::1]:34068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwRpY-0003P2-Ef for larch@yhetil.org; Sun, 12 Dec 2021 11:36:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwRpU-0003Ok-7w for guix-patches@gnu.org; Sun, 12 Dec 2021 11:36:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41444) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwRpS-000540-Ol for guix-patches@gnu.org; Sun, 12 Dec 2021 11:36:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwRpS-0000vA-9H for guix-patches@gnu.org; Sun, 12 Dec 2021 11:36:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v3 32/43] gnu: Add node-segfault-handler. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Dec 2021 16:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath Cc: 51838@debbugs.gnu.org X-Debbugs-Original-Cc: 51838@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16393269323502 (code B ref -1); Sun, 12 Dec 2021 16:36:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Dec 2021 16:35:32 +0000 Received: from localhost ([127.0.0.1]:52990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwRoy-0000uO-93 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 11:35:32 -0500 Received: from lists.gnu.org ([209.51.188.17]:35696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwRow-0000uF-M3 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 11:35:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwRow-0003I6-0S for guix-patches@gnu.org; Sun, 12 Dec 2021 11:35:30 -0500 Received: from mout.gmx.net ([212.227.17.20]:35077) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwRol-0004uE-Ce for guix-patches@gnu.org; Sun, 12 Dec 2021 11:35:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1639326910; bh=eBRGxrEcXetCglfw9WYznu6HQN8xBJYsDoHmqJX25IM=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=kUpsc01PTt+0/H2aiNZv6jVxNClVNML0qTcmPq7bLBo7LFhyY+mdHKxQSIKKQQ6E9 RT5wjXRYhqqjOrnPqP9amOsR+TTMKV5+UnJUNEZ19TkyGaBWtdyrRcv7kjZTq0pI+t RjcJ7cJYQYFs2uRLOCTEvmM0+BDdpJvRf5E+625A= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MvK0X-1mfKZT0L1l-00rLRl; Sun, 12 Dec 2021 17:35:10 +0100 References: <46a042bc08eb72a068b1e8c69bfe28cf2d4b2e53.camel@gmail.com> <20211208202838.752542-1-philip@philipmcgrath.com> <20211208202838.752542-33-philip@philipmcgrath.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Pierre Langlois Date: Sun, 12 Dec 2021 16:31:45 +0000 In-reply-to: <20211208202838.752542-33-philip@philipmcgrath.com> Message-ID: <87czm1wzlv.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:zC+4WKsYg3PHJojbCm+E3jp5tLH7I5IQEJ/m0hGtQSoePWiLDOY jioLzqJE/agl5NtnTeSSPeb3UduG8PTpxskicja92fhRSL1pXR0xvv3a2KZ0xxBPkWAqVIh YFnWFQ37M/Au/uxxCKpJlQusSms92Gw2Ms7WWhxFT78uDOhx06ODbd72iAmJEIoU8m3wQBO Z37ajdWNxopj9SuPE2WzA== X-UI-Out-Filterresults: notjunk:1;V03:K0:hW3thuBTAWQ=:9zGThu7+VB8tONCAywt7gX 8odZTJTLcP2GHdB+qSdcDH0hbuHt8zOPN6vzjJZK8qPJkIpxaxjcTiUFco08I/juErQGC/TmV UgTgQ1t7fq9Se5Cjwpv5+kY2KHy23ytyUV+I4xM0DfvA1VCki4pkSeZflYxv+QtJoKRXDbdT4 iuX8BQhtic1SxfsUfY67OtIBnQWg6jJEmYwn1d/D6qvpPQ5hKwmeQiBk8vysUEB8Mf2z1Wgl9 1c5NEW8mwpI1Cu4GYWQYzGGuhu2Vtv3JybZsy1Kn9gieCeyHowG/Wghe/gLnHivWg54aWZU9d nDoLP2aRhrl+AxsrDy1Jp/aGKE/3bTWDqDxVC8UuEzmEkrsCk5Zp5r4Il0u0m0k0Djn80fW/F QKm36rZRldBqCYAcVP9S2cwBRt2iaCmZh8ErZiTGZ8oDji7ct3ptlsgzUaabPZAkwjtMatB9g SL2HybrZ1GXFiKmhPUivS+Lvu9Z0W+pyJTWzoMxPejXnLTFKh6Gcq4qb5Siy9/G7VCBQfzRjM FU4AbYBQthnCwgcfo1uMmCGYwWmaMwlgmxJajdF6Ar1r1o/fBl3mRCrABvrJqhDZjCX8hvlwC wOiiZbC5zyV3sa9aYByaXss23tN0inZ8Pzj6BOGPBoSiD40hgEeSvOZGdwphN99buF2J5zphg aeoIOnbzeH5YbQrU0PEVXZ3Q9Bf8UjZa9I2Y9wXO/db/OgRYYEXRSUhcIzEZAL3rktaoPocS+ 6sfGAimCe20INmNXYSa7Vcz9lgNTOghaiN1GVnxrDHcYCWpsG+3pmVQdBuDlECJkA3TQTrZ6d eqj3buOsCItYQ4qQwmN7T1amwOeQSv1e7k038Hod5dR+E184YEqiczth2jDHae0DmoMDJkIZq 0bNhZvaDNC/c+VvbKY6G/S7GLLOwm+o9Ipx2cz1+Qa1fS6wvw57GYKVs93k4Hwf8KX3ZGQr+s TTqkZ8HzfbBhw72b/rSoFwlaEBguXijQx5/C2EWPqB+H7feg/OvZGkWpe5sEPWO6b7F4eAyhB pllBYTI3Q9KAp/y0XDjYvV0ON0jPAZTrE2qWhzCsad89op+paj7lnEkp4v+2awwUzJY2S0mfT ucQm69aoLg8Vw4= Received-SPF: pass client-ip=212.227.17.20; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639326969; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=JF1wh0hJHRFKDdpekP8j8jN2fsQy+7g+KtNnchwwY1Q=; b=EjUdaRYXRAy9MASFrOreNlg9aqCaJywGTYoqtNa7HXNAjF97bHKBGC9ZzFIhW8XdeTCc3j UyclheE7LxjxhbOMwIChJXpN0UCJ98HqbaJWIctSWrsgyBAzzKX2oED8TXxi+KRM9PZGAw tanE+PuQbfIY9toGKeMJX7JFGuyf8coFGPHC9L3+1Vl1otjDiPViAVIpI/SfZKN9UGTfPP GUcooNApzP8FWMPgt7kFI5Q2HuIqff36gxeV0lo0WMgiNNq9mo7HPv2z3uwvYj7vJDJgL/ DL6Et/yzi6NLzX+3Tzmmo+i/E6uvHwXrEctYQqXeL0BvAL28gYkSnY6Ht43lEw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639326969; a=rsa-sha256; cv=none; b=oyie+ioOYTlxuOKJxQsLxY1saQJKlR86Xi7DvRCkD3kiHEl/wpEjLLQNSr/P9UlGytVvyt D5RNV6aYOri820p4/uwpP0n7BtA8jlOpdqqu7a7X+QzZOJXNfC8Mx3PIoLH5eE1jw6pdJj qvqJWrKdvyut8/fOQCEWScDlaG3v7B/cx0q8yg84wSomcXg2XRYR6E2+AdASMjTjVw/N4I zwQWrY776WWYc3g5Ep9YppMCnjEvwcC/NCqCnAZQiSMEjQUNBu9j9a1LRa4jTYYoWd6HCB VWYD2Xx+hFj7QBrop1e0xQPoIw3yIgZ31GasUpMM+4+fdodn+U5ik/ybcviTbg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=kUpsc01P; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=kUpsc01P; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3CF671E0FA X-Spam-Score: -4.17 X-Migadu-Scanner: scn1.migadu.com X-TUID: lHz3N6fxtqgO --=-=-= Content-Type: text/plain Philip McGrath writes: > * gnu/packages/node-xyz.scm (node-segfault-handler): New variable. > --- > gnu/packages/node-xyz.scm | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm > index 196fa55a39..27506062ba 100644 > --- a/gnu/packages/node-xyz.scm > +++ b/gnu/packages/node-xyz.scm > @@ -856,3 +856,38 @@ (define-public node-bindings > checks @emph{all} the possible locations that a native addon would be built > at, and returns the first one that loads successfully.") > (license license:expat))) > + > +(define-public node-segfault-handler > + (package > + (name "node-segfault-handler") > + (version "1.3.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ddopson/node-segfault-handler") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "07nbw35wvrr18kmh8f388v4k5mpjgyy0260bx0xzjdv795i3xvfv")))) > + (native-inputs > + `(("python" ,python))) > + (inputs > + `(("node-bindings" ,node-bindings) > + ("node-nan" ,node-nan))) > + (build-system node-build-system) > + (arguments > + ;; there are no tests > + `(#:tests? #f)) > + (home-page "https://github.com/ddopson/node-segfault-handler") > + (synopsis "Catches @code{SIGSEGV} and prints diagnostic information") > + (description "This package is a tool for debugging Node.js C/C++ native > +code modules, and is safe to use in production environments. Normally, when a > +bug is triggered in native code, the @code{node} process simply ends with no > +helpful information. In production, this can manifest as worker processes > +restarting for seemingly no reason. Running @code{node} in @code{gdb} is > +messy and infeasible for a production environment. Instead, this module will > +sit unobtrusively doing nothing (zero perf impact) as long as Node.js is > +well-behaved. If a @code{SIGSEGV} signal is raised, the module will print a > +native stack trace to both STDERR and to a timestamped file.") I'd suggest for the description to be a little more succint, maybe just: --8<---------------cut here---------------start------------->8--- This package is a tool for debugging Node.js C/C++ native code modules and getting stack traces when things go wrong. --8<---------------cut here---------------end--------------->8--- Otherwise LGTM! Thanks, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmG2JLwYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31U7tUIAK3HAE9LGpexjWIda+O7UP90 X2OUR6xT1j0DSoBrXwk0fwYPeb35gcjAb/LKmaRduTv7dFWZ30HEeX+W/1YJYPXJ eQD0yiB9rHVjcv3Ed6aMkm1gF+nDtLjdiEAfmPw5KGPh8KxVivnpMrED6ivdyQGC uHCvk1JUVlrfqPTMCwOHo0j3zusEQfkk/A4jV5QjRRT6kd/4pKQBziv4mVA4FgYI qk7hKpCDOidqSEqdtS6dhsaXKa9iHdtvNA4sVij2d4cHNv/e/29kEzpmFO3k6OWP h5kOsEvlLZ3ymDN348hiiy4XTfH8tlFRgt3Jp7tQxTvA51GkTug6pdGdcWiTTzI= =Nha2 -----END PGP SIGNATURE----- --=-=-=--