From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sB56Fu+AHGL9tQAAgWs5BA (envelope-from ) for ; Mon, 28 Feb 2022 08:59:43 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4BH1E++AHGIrOwAA9RJhRA (envelope-from ) for ; Mon, 28 Feb 2022 08:59:43 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C1EA53BC62 for ; Mon, 28 Feb 2022 08:59:42 +0100 (CET) Received: from localhost ([::1]:40468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOawW-0006xP-Jp for larch@yhetil.org; Mon, 28 Feb 2022 02:59:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOar4-00031f-Fi for guix-patches@gnu.org; Mon, 28 Feb 2022 02:54:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOar3-0003es-Nz for guix-patches@gnu.org; Mon, 28 Feb 2022 02:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOar3-0000Pk-KB for guix-patches@gnu.org; Mon, 28 Feb 2022 02:54:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54180] [PATCH 00/12] Home: Clarify and better test symlink-manager.scm Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Feb 2022 07:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54180 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 54180@debbugs.gnu.org Cc: Oleg Pykhalov , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Xinglu Chen Received: via spool by 54180-submit@debbugs.gnu.org id=B54180.16460348101544 (code B ref 54180); Mon, 28 Feb 2022 07:54:01 +0000 Received: (at 54180) by debbugs.gnu.org; 28 Feb 2022 07:53:30 +0000 Received: from localhost ([127.0.0.1]:59911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOaqX-0000Oq-RY for submit@debbugs.gnu.org; Mon, 28 Feb 2022 02:53:30 -0500 Received: from mail-lj1-f169.google.com ([209.85.208.169]:40493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOaqW-0000Ob-4z for 54180@debbugs.gnu.org; Mon, 28 Feb 2022 02:53:28 -0500 Received: by mail-lj1-f169.google.com with SMTP id v22so16185845ljh.7 for <54180@debbugs.gnu.org>; Sun, 27 Feb 2022 23:53:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=86JE2JeCzzwWza+hHdX3zaGzNCJabsTk0GbxjZswVZ0=; b=2bOsfkO25DyBPdxnFqZ+vrpP294BxIBZ+RN+4jlHvo7GFlr1MHx+thlkF1wFDd0C14 jQItR3KCmZws6f4hGU8Or/G2X6x/KyFCBbCLqdRWpGGzSJxNDwL+C+vWnGNglTQQs8JS PF5CnNZxACZ5D/9kN3mQjY2vlTm3rGHKXS5cVACpVoCAi78vlccsqinbo7O5wYa6qcDC rVzjZx9vTNPqn1EsQRVmzPjFjb3oRIfmTWlUO4M2nXoMH3E386cyakiPwZhY5J9r+V28 2C2T/WQ/8Xg0rNsVeMWgbEFj9CnhxemwuXXc4Uk6qA4mASZ3Q/qG85tmFId7qgyci+1q YPHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=86JE2JeCzzwWza+hHdX3zaGzNCJabsTk0GbxjZswVZ0=; b=O2HNeRMOgV/liuLYVaek3EZpUcB7iuncr6lUeQrn+bilAU4O1vAGPMk8AVt8pZ6dJ1 Cr15wgYZ5LOBmQk+7UHVXgetUYzIQQTqjVYz9tIgiB6p30+ZstX/WxhrppO3cbFF3Kto dgXviengwNcUrxdH9lKCNBT0N7KYOowY+KTXKc2P0soJ2Tc/0Ty1m1gffUv7r4hxBryl ZaFY6xi6eNfZslhesJiBUlh1sLxaMxV6qNn40ttaq/xhCUkBo2MBMXwCNxO2TKNCWcuD +gQCQI/uDalTYu+DW4uDzfPduoV3HaDR5r9iNaM9H02DZDTVLR/LNceoPrH8c9LMqSvh NjFQ== X-Gm-Message-State: AOAM5337HbgqwLKX8jTxCyYWTL4jxbWfA8GNM7WL8rgFf0tDfJdr5gqa uwiTNdM0Ry8VGiiNlAAOOO+nrw== X-Google-Smtp-Source: ABdhPJzzzddQQ+xINdwgWXurqx2qrFs4f5re0SVQ3YFOgxyIgjrZ6zyc1pwfRtRPmR7UiO0vWfqXEg== X-Received: by 2002:a2e:b604:0:b0:246:652c:854 with SMTP id r4-20020a2eb604000000b00246652c0854mr13669313ljn.517.1646034801800; Sun, 27 Feb 2022 23:53:21 -0800 (PST) Received: from localhost (109-252-135-33.dynamic.spd-mgts.ru. [109.252.135.33]) by smtp.gmail.com with ESMTPSA id bf31-20020a2eaa1f000000b0024637000209sm1178196ljb.10.2022.02.27.23.53.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 23:53:21 -0800 (PST) From: Andrew Tropin In-Reply-To: <20220227134006.9860-1-ludo@gnu.org> References: <20220227134006.9860-1-ludo@gnu.org> Date: Mon, 28 Feb 2022 10:53:18 +0300 Message-ID: <87czj7e8b5.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646035183; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=86JE2JeCzzwWza+hHdX3zaGzNCJabsTk0GbxjZswVZ0=; b=GvN7TwVqr4dHWgflLciyb2v+bGsaPaFULEUnWREtPj7Os4XekRS4BleptMVRcILCaT5iJS NuDHYMu2ciZHqznf8CIHWakOAS+XbYSsoO9GLVejc3jIko5zyRHqKHgHEtLOGbbYuP7aKl jcdgxI5I85ng5ZEdLwNovJV7CtDy5jP+WkvJ9Gl4Q62MSgmsxrdvWh5lEGvrhr6zrWsm5j GFkd7oDTxm5jOIKhh35imrtMgInUjPUUsIze5fw/wUDY34UaStXqS/tke8GAGbRzSuneio IwLRPbjrjUS8EHoo8pgXj77ilPdXJdY0/GfQlKTfpFV/n2wqiRQmHCW++Y2CsQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646035183; a=rsa-sha256; cv=none; b=eIncZSJVXi42Yra2APwDfjzuWGPee/DxlaNtIztdDShBU2tBT2R08uxkAxgB6PwbjNCgsh Z0IIH+BafqZRg1OSrKf89LZj316N1q3M1oOIX2tMirawPYXtMgKNZiFdwLuMa5tCVcCvFR wtMWeX0I8e0sGZMBkjMYsa/Jk+Cj6CPzD5qtG0DviutPy7KBL8zt1nKm8ExhXgDKougi90 6c681KBYRHgDW6QTF7UFNd1RRkZ6gRoJaGfLKK86oFBJKyTbtt3BB7EHjJ/6o/hyanfHkH HPT3mY27jdufDsdti9GEpbMJVK3uzrvkD/eUjG8FLRMwc6wEOeaROs3N9av89g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20210112.gappssmtp.com header.s=20210112 header.b=2bOsfkO2; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.60 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20210112.gappssmtp.com header.s=20210112 header.b=2bOsfkO2; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C1EA53BC62 X-Spam-Score: -0.60 X-Migadu-Scanner: scn0.migadu.com X-TUID: k8Y9F8/F59pJ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-02-27 14:40, Ludovic Court=C3=A8s wrote: > Hello Guix! > > This patch set aims to increase test coverage for =E2=80=98guix home reco= nfigure=E2=80=99, > to make symlink-manager.scm IMO easier to follow, and to have it more > closely follow the project=E2=80=99s conventions. > > Functionality is unchanged. > > Thoughts? That's great! symlink-manager was a little messy for sure. I took a brief look; On first glance patches seems good. I'll take a deep look later, when will be updating patch for bug#52808 and will report or make a separate patch if something pop up. Thank you very much for working on this :) > > Thanks, > Ludo=E2=80=99. > > Ludovic Court=C3=A8s (12): > home: symlink-manager: Clarify module imports. > home: symlink-manager: Move helper procedures as top-level defines. > home: symlink-manager: Use 'for-each' when used for effects. > home: symlink-manager: Use 'file-is-directory?'. > home: symlink-manager: Remove 'empty-directory?' and avoid TOCTTOU > race. > home: symlink-manager: Avoid extra 'lstat' call. > tests: Make sure 'guix home reconfigure' backs up files. > tests: Simplify use of 'local-file' in 'tests/guix-home.sh'. > tests: Check 'guix home reconfigure' for a second generation. > home: symlink-manager: 'cleanup-symlinks' uses 'file-system-fold'. > home: symlink-manager: 'create-symlinks' uses 'file-system-fold'. > home: symlink-manager: Rename "path" to "file" where appropriate. > > gnu/home/services/symlink-manager.scm | 355 ++++++++++++-------------- > tests/guix-home.sh | 44 +++- > 2 files changed, 198 insertions(+), 201 deletions(-) > > > base-commit: 33ce3f1c866231a3015411fdce18a3e72649e2f6 =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmIcf24PHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wyBcP/jal9rPsArKVIVsXYpAaqrwDEf1h/lYEu62i rIhdKKrgKtu8Mg3PMvR1uoG7sUib53NbSrySWAkZN7BpLK8R7oDWbMTc7AkrHFWK GebcDh+bkT/YfmZeiKzgCZI0zFLUaClFZH2KYMg27k4WJJJDCGOSqjQcJOqL2tA7 ijzTLVI+PX456eaOV3DE0utTuJ8QrNtiBz4elqAEKsBFqQcryfvybM1RgWd0jQ78 Q5J64KLykWmZo2rPoKVxliyRA4RchcUe+BDoiTC4cowDBXQXuh6gPf2fv+XvH2qJ qWe4ACVdhRIjiuJb+87u62M5Q+LO4LNpIL2Qrwtm7tB2G0q9Wkg8Kru/Aos8Zqcw 3LnKryRfH+CpyyGS6ZuVhfrOsTHFT1PSmBfT8GxwrqA+RLzqcjeDFzCwM6n2DKOz KQYEGngduWg3PhGJ88cLwzFIHzKRCdleQnOn2m9i6HeaeqFtl+i980XpowPjsAfA j/lY8/4uJ5+OOMSGNrFQNxrm+yyN1J/6xGudsisazSCWlEVXTz0Sot7ZBP6Sn6KO 9S58b3vkkOvLX/Hfbg2UY4x6qqyxziubdxXAPfKeWSmPcKpoimolZppgwhLpkdR9 OYp5BGaybCMRxD6HALMDIBf9krdjkwaub4oS6IqEabIrVFnxRlUqfc/JqDiBsioZ ND8n2v/T =j+X6 -----END PGP SIGNATURE----- --=-=-=--