bug#56343: ‘tests/services/telephony.scm’ fails to run

bug#56343: ‘tests/services/telephony.scm’ fails to run

[Ludovic Courtès]

Hi,

The ‘tests/services/telephony.scm’ file exercises procedures that were
removed from (gnu build jami-service) in
85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
from proceeding:

--8<---------------cut here---------------start------------->8---
$ make check -j5

[...]

PASS: tests/services/file-sharing.scm
PASS: tests/services.scm
PASS: tests/services/linux.scm
make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
make[4]: *** Waiting for unfinished jobs....
PASS: tests/sets.scm
PASS: tests/packages.scm
PASS: tests/pack.scm
PASS: tests/lint.scm
make[4]: Leaving directory '/home/ludo/src/guix'
make[3]: *** [Makefile:6061: check-TESTS] Error 2
--8<---------------cut here---------------end--------------->8---

Should we keep some of the tests in this file, or has it become obsolete
entirely?

Thanks,
Ludo’.

bug#56343: ‘tests/services/telephony.scm’ fails to run

[Maxim Cournoyer]

On July 1, 2022 5:34:37 PM EDT, "Ludovic Courtès" <ludo@gnu.org> wrote:
>Hi,
>
>The ‘tests/services/telephony.scm’ file exercises procedures that were
>removed from (gnu build jami-service) in
>85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
>from proceeding:
>
>--8<---------------cut here---------------start------------->8---
>$ make check -j5
>
>[...]
>
>PASS: tests/services/file-sharing.scm
>PASS: tests/services.scm
>PASS: tests/services/linux.scm
>make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
>make[4]: *** Waiting for unfinished jobs....
>PASS: tests/sets.scm
>PASS: tests/packages.scm
>PASS: tests/pack.scm
>PASS: tests/lint.scm
>make[4]: Leaving directory '/home/ludo/src/guix'
>make[3]: *** [Makefile:6061: check-TESTS] Error 2
>--8<---------------cut here---------------end--------------->8---
>
>Should we keep some of the tests in this file, or has it become obsolete
>entirely?

It isn't obsolete, but I had forgotten there were both unit and functional (system) tests for our Jami seevice. It's probably easy to adjust, I can look into it when I'm back from travels in a few days.

Cheers,

Maxim




Hi,

bug#56343: ‘tests/services/telephony.scm’ fails to run

[Lars-Dominik Braun]

Hi Maxim,

> It isn't obsolete, but I had forgotten there were both unit and functional (system) tests for our Jami seevice. It's probably easy to adjust, I can look into it when I'm back from travels in a few days.
I had to remove tests/services/telephony.scm from Makefile.am, so
we could update the guix package to fix other issues. Please revert
c23e0aa65d511a29f31da876f905594c0f8bce00 once you’ve fixed the tests.

Thanks,
Lars

bug#56343: ‘tests/services/telephony.scm’ fails to run

[Maxim Cournoyer]

Hi,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> The ‘tests/services/telephony.scm’ file exercises procedures that were
> removed from (gnu build jami-service) in
> 85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
> from proceeding:
>
> $ make check -j5
>
> [...]
>
> PASS: tests/services/file-sharing.scm
> PASS: tests/services.scm
> PASS: tests/services/linux.scm
> make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
> make[4]: *** Waiting for unfinished jobs....
> PASS: tests/sets.scm
> PASS: tests/packages.scm
> PASS: tests/pack.scm
> PASS: tests/lint.scm
> make[4]: Leaving directory '/home/ludo/src/guix'
> make[3]: *** [Makefile:6061: check-TESTS] Error 2
>
> Should we keep some of the tests in this file, or has it become obsolete
> entirely?

I've remove all the parsing tests and kept the others; see
258bc4c4e668e9817471d04d052bc0a8e2d43fa0.

Thanks for the heads-up!

Closing.

Maxim

bug#56343: ‘tests/services/telephony.scm’ fails to run

[Ludovic Courtès]

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> I've remove all the parsing tests and kept the others; see
> 258bc4c4e668e9817471d04d052bc0a8e2d43fa0.

Great, thank you!

Ludo’.