From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +GlJO6f07WJDjQAAbAwnHQ (envelope-from ) for ; Sat, 06 Aug 2022 06:57:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EAZZO6f07WKnDQAA9RJhRA (envelope-from ) for ; Sat, 06 Aug 2022 06:57:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A705598C for ; Sat, 6 Aug 2022 06:57:11 +0200 (CEST) Received: from localhost ([::1]:53340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKBs6-0004CP-Lq for larch@yhetil.org; Sat, 06 Aug 2022 00:57:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKBry-0004CF-K7 for guix-patches@gnu.org; Sat, 06 Aug 2022 00:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oKBry-0007ad-Bg for guix-patches@gnu.org; Sat, 06 Aug 2022 00:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oKBry-0001Gy-2a for guix-patches@gnu.org; Sat, 06 Aug 2022 00:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56771] [PATCH 00/33] *** Update Jami to 20220725, core Qt packages along the way Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 Aug 2022 04:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56771 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: Jack Hill , Lars-Dominik Braun , 56771@debbugs.gnu.org Received: via spool by 56771-submit@debbugs.gnu.org id=B56771.16597617954850 (code B ref 56771); Sat, 06 Aug 2022 04:57:02 +0000 Received: (at 56771) by debbugs.gnu.org; 6 Aug 2022 04:56:35 +0000 Received: from localhost ([127.0.0.1]:60913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKBrT-0001G6-Qk for submit@debbugs.gnu.org; Sat, 06 Aug 2022 00:56:35 -0400 Received: from mail-qt1-f173.google.com ([209.85.160.173]:34433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKBrO-0001Fp-F5 for 56771@debbugs.gnu.org; Sat, 06 Aug 2022 00:56:30 -0400 Received: by mail-qt1-f173.google.com with SMTP id e23so3389595qts.1 for <56771@debbugs.gnu.org>; Fri, 05 Aug 2022 21:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc; bh=FBN6WnqVdPO9Cbr5wnhEyRurRoyok5cvL+96/LBjDLQ=; b=M/8Q20TuEY3sd5LcE2JocGxUKl9t2xmLoS/AwPh5mn2fkYDgZ7yxt4wCkeT3BGvQzK fOU0VAmDcdLQc5PMILwn35158LTLQWB0CkXmBW8Ew+tKH3qRojQ6j/XoRxkvYFnWyXfU N78qwdVp/rq3uFcuSp2ccNcfyL1TDJI7PTrIRVu4E5p7nsDZ3oMrmmNY+SicRXlMO923 zVY5VwZp1+Bx0oXucDF1j0iRypyoDOf+zOrWlDTYZ7cHTmaHYVpvstriI/VzztvOehst 8D9FmswZygMIo8bIY/Julekre4aG0MmIR5clFlNJInu5ZynEodMdKZ2husXxdUdd6pFU Ms9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=FBN6WnqVdPO9Cbr5wnhEyRurRoyok5cvL+96/LBjDLQ=; b=WKNRdHA+VBs/tKRZftfdyEDHPzIluAwjtA6cwUPAo5yMCG5PKZ2bKT6SwIq/OJhyEi 8GguP0JOZ50xOgn3E7qDMqNny+0bA4b8denOYMCF6BdK+nNKq7YYo6+Rgo1JJyChJa8Y GXyaN0G4ljD40WvOBDTGGfErvVHC2lx2iMC2mls40Jz2qW5p2txGaMv8PGuOyenj6YIu clXgb8ltcase5kjOHe9zumFoYSN92dJZ4WItIsAenHAw/A5FpPwVizLhPpetspDa51se VjI/d7/gTaRiwzITq+pUWAnfrQfNDZsH49msZ6EhdaeLHSc1zLFo13LgmVkgFIfRodey X+ig== X-Gm-Message-State: ACgBeo0Bq7J+IEQzMvkWeQ/uiZm66znFrzQhwHPEOtG/T0zxqpj1uibV Jd4DCS06mJylocHEK3IgNRw= X-Google-Smtp-Source: AA6agR4JlKFMo3kltbsySmxegb41n8n6Phh1hG38cdGw9NrjHHovmADbpi5Zej4FYP7sxJkD1M89aw== X-Received: by 2002:ac8:578d:0:b0:31e:f696:ff95 with SMTP id v13-20020ac8578d000000b0031ef696ff95mr8227190qta.53.1659761781045; Fri, 05 Aug 2022 21:56:21 -0700 (PDT) Received: from hurd (dsl-10-148-69.b2b2c.ca. [72.10.148.69]) by smtp.gmail.com with ESMTPSA id bs30-20020a05620a471e00b006b9122642f5sm2987106qkb.75.2022.08.05.21.56.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 21:56:20 -0700 (PDT) From: Maxim Cournoyer References: <20220725211704.4977-1-maxim.cournoyer@gmail.com> <87y1w82ct7.fsf@gmail.com> <66a14530-2dbc-c700-4403-8fe86d77756f@telenet.be> Date: Sat, 06 Aug 2022 00:56:19 -0400 In-Reply-To: <66a14530-2dbc-c700-4403-8fe86d77756f@telenet.be> (Maxime Devos's message of "Fri, 5 Aug 2022 14:51:16 +0200") Message-ID: <87czdeotqk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659761831; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=FBN6WnqVdPO9Cbr5wnhEyRurRoyok5cvL+96/LBjDLQ=; b=aQqtMvu14O5nixtrhTWnOWuYmkS/ktRtsviRHC2C2Y14NLdRc7ASyPUzqBrH48a0td6LET RyS2G9L0agXXCJHDpchm8pJuv/KsAJY2yjAuH3bDDgGfHlVs8tra5w5DNcBU4KwBc0h1Wa Z+dXY0DZ3vxaavaB8NmUDCvgz3eK6cSKA9uSelb9pEvwgic1h8mAQxy2TUBcEhvZwkHEEV 8KMqyq2Y6XXrmSloAIrIdimpX6cnz9Hc9GvEfpTdrrXhNn1No/Guy4EU5v7/3QJvSuMPgi xNhb4tga/ba2INX9BJoQClS8Tg7DyLBJqCRcUK7cKuwVUKlAE31RuxbyfI6OGQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659761831; a=rsa-sha256; cv=none; b=F50jzfh5YRfYj8WiAOJs1ZCgsn/bqnBEYQRJBI1Z+BMX69WNRsudqahFs9XfkdFlNfTy/P Bv3yg9PvyLim3izi2RNumfXzd8QVgN5mu4Q1qU9X7qMBXJbzhmnmwagFTavIJrS7cwQxPz drh9BOyHksZKMLWcY3j0L2tkrH/5cNgYGnUp0Z68q3XDtInR42tP2PxTKOcGpqDrpSbVyo O//ieO/9ZNm3fCVlyXKbxlbacozwMadf2TpxYc+YbQtBK0chialCnliAvFFdaxv/Mr4CxA lAH6tX1jCow6QUn6jiLVY9CiV4mqV42l9iXct225c/nYkMbvm5aHfNgei2N0vw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="M/8Q20Tu"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="M/8Q20Tu"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A705598C X-Spam-Score: 5.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: Dn+2jGg4qeMV Hi Maxime, Maxime Devos writes: > On 01-08-2022 17:39, Maxim Cournoyer wrote: > >> We could also refrain from introducing this argument, instead finding >> the qtbase in use via search-input-file at the place where we need to >> know its store output to figure out the version used; that'd be simpler, >> but would remove the mechanism here that allows a user potentially >> mixing qt5 and qt6 (probably not a very useful use case) and being able >> to explicitly set the qtbase used for wrapping/building. >> >> What do you think? > > Aside from the #$ / #+ the fix looks good to me, but I don't know > about arguments like #:qtbase, it's not something I've experimented > with myself. Apologies, I think your comment about me changing #$ to #+ fell into the cracks. I made that change because qtbase was added as a build-inputs (meaning, native input), as it provides tools that need to run on the host, such as qmake. But you are right that Qt programs link to its libraries, and thus a second qtbase would need to be added to host inputs for cross-compilation. We should add qtbase there too, but it'd be nice to confirm cross-compilation can work. Thanks, Maxim