From: Andrew Tropin <andrew@trop.in>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>,
Efraim Flashner <efraim@flashner.co.il>
Subject: Re: [POSTMORTEM] Subkey is not authorized by .guix-authorizations
Date: Mon, 05 Sep 2022 10:07:25 +0300 [thread overview]
Message-ID: <87czcaxpsi.fsf@trop.in> (raw)
In-Reply-To: <87ilm5x64a.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 750 bytes --]
On 2022-09-02 15:23, Ludovic Courtès wrote:
> Hello!
>
> I’m late to the party, but thanks a lot for sending this analysis!
>
> Andrew Tropin <andrew@trop.in> skribis:
>
>> * What could be done better?
>> - guix pull could be done from local checkout, before pushing.
>
> Setting a pre-push hook that invokes ‘guix git authenticate’, as
> recommended in the manual (info "(guix) Commit Access"), should be
> enough: ‘git push’ would just fail in that situation.
For some reason I thought it does git verify-commit, which I used
manually to check if commit is signed, but it does make authenticate,
which of course works the other way. Missed it, my bad.
I have elaborated on this topic a little more in the manual.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-doc-Add-more-info-about-commits-signature-local-veri.patch --]
[-- Type: text/x-patch, Size: 1436 bytes --]
From e510ea1595c54bec788485f0638967d457afaf3d Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Mon, 5 Sep 2022 09:46:23 +0300
Subject: [PATCH] doc: Add more info about commits signature local
verification.
* doc/contributing.texi (Commit Access): Add more info about commits signature
local verification.
---
doc/contributing.texi | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/doc/contributing.texi b/doc/contributing.texi
index b1d236c011..17a54f94cc 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1627,14 +1627,23 @@ git config commit.gpgsign true
git config user.signingkey CABBA6EA1DC0FF33
@end example
-You can prevent yourself from accidentally pushing unsigned commits to
-Savannah by using the pre-push Git hook located at
-@file{etc/git/pre-push}:
+To check that commits are signed with correct key, use:
+
+@example
+make authenticate
+@end example
+
+You can prevent yourself from accidentally pushing unsigned or signed
+with the wrong key commits to Savannah by using the pre-push Git hook
+located at @file{etc/git/pre-push}:
@example
cp etc/git/pre-push .git/hooks/pre-push
@end example
+It additionally calls @code{make check-channel-news} to be sure
+@file{news.scm} file is correct.
+
@subsection Commit Policy
If you get commit access, please make sure to follow
--
2.37.2
[-- Attachment #1.3: Type: text/plain, Size: 640 bytes --]
>> - Accept subkey on guix pull if master key is in .guix-authorizations.
>
> Reported at <https://issues.guix.gnu.org/57091>.
>
>> - Add pre-push hook, which checks authorization on Savannah.
>
> That one is difficult: Guix is not installed on those machines.
>
> Another option would be to push to a different machine, one that we
> control, and make Savannah a mirror of that one.
It can work, but looks fragile.
>
> Thoughts?
Let's ask savannah admins if it possible to install guix on those
machines and add pre-receive/update hook? If not, we will look for
other options.
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2022-09-05 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 14:26 [POSTMORTEM] Subkey is not authorized by .guix-authorizations Andrew Tropin
2022-08-11 15:09 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2022-08-11 15:11 ` Maxime Devos
2022-08-11 15:25 ` John Kehayias
2022-09-02 13:23 ` Ludovic Courtès
2022-09-05 7:07 ` Andrew Tropin [this message]
2022-09-05 9:53 ` Ludovic Courtès
2022-09-05 11:50 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czcaxpsi.fsf@trop.in \
--to=andrew@trop.in \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.