From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ML3QBQaxRWNYcwAAbAwnHQ (envelope-from ) for ; Tue, 11 Oct 2022 20:08:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2IPVBQaxRWOUgQAA9RJhRA (envelope-from ) for ; Tue, 11 Oct 2022 20:08:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E245EF7A5 for ; Tue, 11 Oct 2022 20:08:05 +0200 (CEST) Received: from localhost ([::1]:60832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiJfg-00044c-Qr for larch@yhetil.org; Tue, 11 Oct 2022 14:08:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiJeh-000430-Bq for guix-patches@gnu.org; Tue, 11 Oct 2022 14:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55694) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiJeh-0001xJ-1r for guix-patches@gnu.org; Tue, 11 Oct 2022 14:07:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oiJeg-0004IM-IU for guix-patches@gnu.org; Tue, 11 Oct 2022 14:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58123] [PATCH] gnu: services: docker: Add docker-container-service-type References: <87r0zwr9dv.fsf@disroot.org> In-Reply-To: <87r0zwr9dv.fsf@disroot.org> Resent-From: =?UTF-8?Q?M=C3=A1ja_?= =?UTF-8?Q?Tom=C3=A1=C5=A1ek?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Oct 2022 18:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58123 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: maximedevos@telenet.be, 58123@debbugs.gnu.org Received: via spool by 58123-submit@debbugs.gnu.org id=B58123.166551160516486 (code B ref 58123); Tue, 11 Oct 2022 18:07:02 +0000 Received: (at 58123) by debbugs.gnu.org; 11 Oct 2022 18:06:45 +0000 Received: from localhost ([127.0.0.1]:54772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiJeP-0004Hp-H4 for submit@debbugs.gnu.org; Tue, 11 Oct 2022 14:06:45 -0400 Received: from knopi.disroot.org ([178.21.23.139]:38854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiJeN-0004He-4v for 58123@debbugs.gnu.org; Tue, 11 Oct 2022 14:06:44 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id D30A24DB29; Tue, 11 Oct 2022 20:06:41 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "To" Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id HX-LSC0RSobA; Tue, 11 Oct 2022 20:06:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1665511477; bh=Up3gKktlcb4OvV0QlrxMENwoNiXIQosNbYeD99aKU7c=; h=From:To:To:Cc:Subject:Date; b=S77qtc8ftkz+IZIWOfajIO2e1rrEDmaSaFsYZJLE2q/yxhDmIKOTVCMQoGc52byNS qsyGPbsXlKkdcE2oB8KQerotb2xHG9AfFHLLkbR31HktzK+0Xo1RB+WLkEIqN5OQtf ugu9sL/pCnFZs2NF0puclDeQQGR0Tki+/7/m4vNwwY7nAsSi47R5OPBd+K7jirvT9j Rd2nicukpgwbk9ZgDGSjuPe2ozCJd8PdJyfjaRJV2ISwFH05CI9wPJVcRhBASvIKGf BVwCRv4cCAEl0VfA7rsFudGKnWPGNeJaDAFG0HzV8XZVLQYywirIPZ4TldkclYrp58 dTfKXREYCs9Hw== Date: Tue, 11 Oct 2022 20:04:35 +0200 Message-ID: <87czaygrt8.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: =?UTF-8?Q?M=C3=A1ja_?= =?UTF-8?Q?Tom=C3=A1=C5=A1ek?= X-ACL-Warn: , =?utf-8?q?M=C3=A1ja_Tom=C3=A1=C5=A1ek_via_Guix-patches?= From: guix-patches--- via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665511685; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vb+Wx7WRkj1Toqzdcvn4pbZI5Imd6fGj41qtNDwddFQ=; b=YByU/RbpGUp+MlFwS+oUY6R1/T6/Hd5IBNKcrQPb+mtWhE3cxGil8ufkLJu9t8xzlHmG4x i4hoCWaaYCg5RgB/uTSHGMIKcjpJzSI93thnw4/JpFCJpnanXi5Z47xD0d4YLYXtSgqH5V qbI64uerqYhxkp4UXCPJdyOrGvwDymzQMG7BG9HJDhAFKPmK7kBcC9S8mM47+z3Aln2x// pfPQnnzTdceiCkrFt+Mo6nZpMx3g3+c9jmSms5gVYLFJriJE2ryRVDRccT5eV62kyP1gzd vViY/m97s/q9ZadtC1SC+ZRtGXuuR7d8PHs7zjmI7/lBdAm4I3ydiefnbuVXfw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665511685; a=rsa-sha256; cv=none; b=LLT2lVxCKmTtXGiYez4S2ASfzZQWfL+YFWGfSOouUynucXnDQnkjViI4kVjMmPn+GSbLm8 6kEg2tv5H3PfRosBrN+mDjOwOU5ZTwJTyNYTr3BIYVM2PNQ+04cSMG3bhKa7G46Uv2gchj ptFcreNDV2xPI7lgpzBWaX8F8Gg4AbEhYU1AYl4LqeC8g3CBzuxUUAhmPE7doCV9yhwnHY g8+yOByMgz0pj0pO8S9wm/27qO0FhDQ7fjfvUPPYoOrbbYn9rFD2S770ifz/g+FghbMM5X 0bGvvZB6EzHUaA3BwPWWGraTpuqYQb3tXyzB4t6oTDROnMpgHGuJS7hCArdw/w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=S77qtc8f; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.89 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=S77qtc8f; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E245EF7A5 X-Spam-Score: -1.89 X-Migadu-Scanner: scn0.migadu.com X-TUID: coP8qZ10sdbg Hi Ludo', >> I have applied the changes as you suggested. Thank you for your (as you >> said) "superficial comments", they were really helpful! And I am happy >> that you made them, as I'm sometimes too happy that I have made a >> contribution and I forget that I don't write only for myself, but for >> others. > > Thanks for the nice and useful service! > > It looks pretty good already (in part thanks to Maxime=E2=80=99s guidance= :-)). > I would have two more asks: > > 1. Could you update doc/guix.texi to document the new service? You > can mostly use =E2=80=98generate-documentation=E2=80=99 to produce t= he reference of > the configuration record, and then add a paragraph giving some > context and a documented example. Is that a command from make? I'm sorry I have never used it, I can update it if I can generate it :) > 2. Could you add a test under (gnu tests *)? That would ensure the > service does not bitrot going forward. I'm not exactly sure what would that mean. Test that creates a container and then runs it or...? > Let us know if you need guidance on these things. When you=E2=80=99re do= ne, > please send an updated patch with those changes here. Will do! Maya