From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MPu5FbVEaWMSjQAAbAwnHQ (envelope-from ) for ; Mon, 07 Nov 2022 18:47:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8EXSFbVEaWN4JAAAauVa8A (envelope-from ) for ; Mon, 07 Nov 2022 18:47:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 052F42A779 for ; Mon, 7 Nov 2022 18:47:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1os6DO-0004BW-7U; Mon, 07 Nov 2022 12:47:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1os6DA-0004AH-Tx for guix-patches@gnu.org; Mon, 07 Nov 2022 12:47:12 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1os6D8-0008To-ED for guix-patches@gnu.org; Mon, 07 Nov 2022 12:47:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1os6D7-0002wM-TY for guix-patches@gnu.org; Mon, 07 Nov 2022 12:47:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59078] [PATCH] lint: Split the derivation lint checker by system. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Nov 2022 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59078 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 59078@debbugs.gnu.org X-Debbugs-Original-Cc: 59078@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 59078-submit@debbugs.gnu.org id=B59078.166784321911294 (code B ref 59078); Mon, 07 Nov 2022 17:47:01 +0000 Received: (at 59078) by debbugs.gnu.org; 7 Nov 2022 17:46:59 +0000 Received: from localhost ([127.0.0.1]:35274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os6D5-0002w6-Du for submit@debbugs.gnu.org; Mon, 07 Nov 2022 12:46:59 -0500 Received: from mira.cbaines.net ([212.71.252.8]:41800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os6D3-0002vx-E1 for 59078@debbugs.gnu.org; Mon, 07 Nov 2022 12:46:57 -0500 Received: from localhost (93-42-6-17.ip84.fastwebnet.it [93.42.6.17]) by mira.cbaines.net (Postfix) with ESMTPSA id D3C1027BBE9; Mon, 7 Nov 2022 17:46:55 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id a456c9c1; Mon, 7 Nov 2022 17:46:54 +0000 (UTC) References: <20221106135532.5724-1-mail@cbaines.net> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines Date: Mon, 07 Nov 2022 18:37:32 +0100 In-reply-to: <20221106135532.5724-1-mail@cbaines.net> Message-ID: <87cz9ypshf.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667843253; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=H1FyVvFqRv//DuOWjMAMKJm2NG8U4P++5Ef4fhgNrbQ=; b=oMSMHJN0FA+AXEfLCD6jzC/4vkAewokH43VESohvqwrZFeaqSt0Rhl4n2VKt0jJLHl/ZQj rPmJGCYvG2ysfdA0EbDoEQkZvSmVvUrDhIFaSE+88wlFuZvWOjG4e5l5NNovTQCm9y3qVj HTirvod8SNhoF6M+DCudrvBov3CNDnhrsul3dgFDLT/vusheWahi0LQWV7f3a3Rq8k1Dlb Hne/ntZ5XBPX6CoyKPPSYq1dWc594g2L2/yqyCZb/biBtgwqDgTux/wOKLCdNRuNZhBHr0 mwwKuiQMMBglwjwTrcMGn4Gdo8yObUYffAahKRYECdRFSWrGVPf2znjbfwoGmQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667843253; a=rsa-sha256; cv=none; b=OSrBuYM+5MEPdIflDYXaPBhJnlRdy3g38Y4C3hdynMC8pIP1I9UoO32m2kdf2Nc5nniLpZ 132cbpwmEo1MeUnDTJVsMPthdZm9Cwyv9G6pJ1u/EYcdFmE2hB1zJRjn6k8NdmpJARITYu NNTHQtfgQcF+96ZYc/FSYOPeQaZF6pH7JlcUJBWyOubYnjsUUwDfnCs9zkffXnnUy4v/38 TEG8hsQk5jEeRPCYTpd5JfjRVENAxcDKOZSloe26raYoraIbzylO6uDcJw1e8x9fp3ATmN XABwwjGSn+6hcYDGxsyRGfZpDFxgR3X4gCv4SufsRYoOqV0KGg5gvsJO0VfAVQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.11 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 052F42A779 X-Spam-Score: -5.11 X-Migadu-Scanner: scn1.migadu.com X-TUID: JNSd5tHjbFME --=-=-= Content-Type: text/plain Christopher Baines writes: > This problem also impacts the Guix Data Service, since it tries to run the > derivation checker for all packages. This patch has now been processed by qa.guix.gnu.org. Looking at the logs for the Guix Data Service processing the base and target revision, and the change is more significant than I'd imagined: Base: inferior heap after cleanup: 1739.0 MiB used (5160.0 MiB heap) debug: Finished getting formatting lint warnings, took 349 seconds debug: Finished fetching inferior lint warnings, took 3782 seconds Target: inferior heap after cleanup: 1152.0 MiB used (1778.0 MiB heap) debug: Finished getting derivation/aarch64-linux lint warnings, took 334 seconds debug: Finished fetching inferior lint warnings, took 3285 seconds So with the changes, it's a little faster, but the main difference is that the heap ~3GiB smaller, so ~34% of what it was previously. I did notice that this also subtly differs from how the linter behaved previously, since some packages define support for systems not defined through the platform module. https://data.qa.guix.gnu.org/compare?base_commit=a60dc46c2bb5de196858594b72b00d5f86ca7e98&target_commit=4e152714f55337015991e62e51e8dea15e889b9f Personally, I think this change is still a good one. Maybe we can add a separate linter to go round and check that packages don't declare support for systems that aren't in the platform module. Unless anyone objects, I'll like to push this sooner rather than later, as I think the excessive heap size in the inferior process is not ideal. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNpRIxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XflUg//bzvSQ+wbaAL3FO9EQz6zGmVeDOgqbkEe rX+iCqLk0ZvYAzTMUYmz+z55ozfJChkhB5TwA71s68hOKZQFEvkI6lwUylaryy4a ovkttrcn6hEtr5E0KglToltSj5F8IHlQ3BT4uc0re2/zWIfrsFUEbjI2HLH99xyA CKxH1ENy0GboVZBH8SHYRLTTWefMRkMUCq6c2hWpZeOSYHuqf4Gk6KXc6oEln6js FBkFeH9N1V2607/KakrCY851zevbjXc5LD+0OXXN6ALR9qXzrb+gp00U/5gJ54zd pNlzZSanRC8R+LM3bAKOQxe1womVv3/QIczJCTclXL7NTVT/5a3WYlrbIldoPMhN ET2XVjRzHz4WheprtTzkm/F2JdcbFPNsra9K+uDzRHX2AH98JzklDhq58AzsxF+s hXge0BCv3rsJpjgQHtp8sW26VdyBssuZYMqEE9XbX+Jzvr++DtN4rgDu2nXWJOX/ RMns3KiK6U5yP3Gq6dI8YCtdxreHPbAPjfH829H5/gPCqE4wDcyinb1YCCAwsy7K 4ELkFjg/L7CEFfiuB5N+wuGq2bpxF2YNwWMs5QMq/tlGGSSXkGVWDwsaxKS+Y0XI GBzO77Hsjxm1fNpuBowP0ZaQKYnBtEwl5gbUYkeAnIDBqgdZECcGPTGOEh/jEQFN KQljNj7kxtE= =ALR6 -----END PGP SIGNATURE----- --=-=-=--