From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qLVhLGLmcmMnDgAAbAwnHQ (envelope-from ) for ; Tue, 15 Nov 2022 02:07:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CCNoK2LmcmOLAwEAG6o9tA (envelope-from ) for ; Tue, 15 Nov 2022 02:07:46 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 574ADAB65 for ; Tue, 15 Nov 2022 02:07:46 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oukCH-0007ak-P8; Mon, 14 Nov 2022 19:53:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oukCF-0007YG-Rl for guix-patches@gnu.org; Mon, 14 Nov 2022 19:53:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oukCF-0006no-IC for guix-patches@gnu.org; Mon, 14 Nov 2022 19:53:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oukCE-00035T-5U for guix-patches@gnu.org; Mon, 14 Nov 2022 19:53:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Nov 2022 00:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59253 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thiago Jung Bauermann Cc: 59253@debbugs.gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer Received: via spool by 59253-submit@debbugs.gnu.org id=B59253.166847356511844 (code B ref 59253); Tue, 15 Nov 2022 00:53:02 +0000 Received: (at 59253) by debbugs.gnu.org; 15 Nov 2022 00:52:45 +0000 Received: from localhost ([127.0.0.1]:52186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oukBw-00034y-T8 for submit@debbugs.gnu.org; Mon, 14 Nov 2022 19:52:45 -0500 Received: from out0.migadu.com ([94.23.1.103]:42549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oukBu-00034o-Pb for 59253@debbugs.gnu.org; Mon, 14 Nov 2022 19:52:43 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1668473559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U5GhvQCwPfXBasPW/1hvBGfQl5+jT0nd9yCLAEmrVE8=; b=JuTNWhcE2AtwKhlZZg8UGN3Bgj8Cm27hA4WylAatkghTbG+YYxCyGb55b5EeJR/iUTNT+d pzDBnvQbdlST8tFL8zkT8YsiVBwwxzBzaERJSN9F6VZH8Ggv7lookpAq8tRCJbWCjUyqcE vhduVWY9qlcMoQLUJ9tSd2fU0yA5/flK8/4NYK/tunURZSAG9HGwmJOyV00/EHqgVX4BUQ rTMcICmSVHJYlHrN/6CvPuad52dr8ravosiMDo0/UNhPeiQ1a0ibphhgLbWdt1AVQZxrcX E/gHLgK/o5ZJVZRz2UiK4MEJNrLsDg2GH3F5hWn9YONG7L6+vjbt2mor470H0g== From: Kyle Meyer In-Reply-To: <87h6z2p6jc.fsf@kolabnow.com> References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> <87r0y6pkac.fsf@kolabnow.com> <87y1seqlwm.fsf@gmail.com> <87h6z2p6jc.fsf@kolabnow.com> Date: Mon, 14 Nov 2022 19:52:36 -0500 Message-ID: <87cz9pvy23.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668474466; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=U5GhvQCwPfXBasPW/1hvBGfQl5+jT0nd9yCLAEmrVE8=; b=E12BxkfYqeKF1d+p5+CO7iUT23e2E89isr14rvr8Z8YD12ZBM0ZSq66O+cZzdPHYZ/V9Ym w8Uiypir48fOWL4/sn8lP9Gpf8Yk2d7ihTASo+uUKe6AhIYYyc1JldbhYO9D5WpwhBChmx wQrEOaGBrHOd15BJBun2+AoJTDPXiFsy348P0igMoL0BesTYwNw13KzWBrDuKNTeWcSAA1 O0LA1Oq6yzsrcjau4yTAIq+qmNcUT5QSJnhekaEKnloVapB+zWngwejfuek7V02SG/qisu vVT1dWGj6OWr/RAxQDFe83gvSL/0MJFGLCAm94reVubskfbZRcG9dJ9ekMEJ0w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668474466; a=rsa-sha256; cv=none; b=G8dIsO9cXqW569z5Z1TAHjd9w8YX/zFO+O4DvOYjj7FE3wMJthZPKQW4oTXdB3sNWp9rmH lMQtdO7FlzvITeDX/edYJV+RJaCjG7Xy2PveQMRNkSK5EjMQY/FVbRqKQwwntYLgmDJRPT oXETwHyuMUDUHkzgZqATMMNfliL4hIMdTQrXrSAScN6T5mi+FoKwHaZrD02s51RCN/wZQO 1XngGpPyPgwKw1itzrxXsGBPPYQ8wnDPZXuUVFbMyijvNFnSw4BsZJ4eISSBgD4h3UVzEp Yo2JpJ2R9uHXwQRV6MbSlbklbrRIokoQwYA2RcQzHsgEZJ+kmnwcddTsBrpG1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=JuTNWhcE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=JuTNWhcE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 574ADAB65 X-Spam-Score: 1.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8AEOxcxNI4QO Thiago Jung Bauermann via Guix-patches via writes: > Maxim Cournoyer writes: [...] >> Won't this make magit unusable from TRAMP (which already seems broken >> for me since the time we enabled native comp -- anyone else?). > > Hm, interesting point. I don't know. I don't use TRAMP because it was > too slow for me in the couple of times I've tried. > > magit/lisp/magit-git.el does have this custom variable though, which > this patch didn't change: > > #+BEGIN_SRC elisp > (defcustom magit-remote-git-executable "git" > "The Git executable used by Magit on remote machines. > On the local host `magit-git-executable' is used instead. > Consider customizing `tramp-remote-path' instead of this > option." > :package-version '(magit . "3.2.0") > :group 'magit-process > :type 'string) > #+END_SRC elisp > > So I'd say it's possible that my patch doesn't affect whether Magit > works from TRAMP=E2=80=A6 That's right. magit-remote-git-executable is the executable that will be used when operating remotely via TRAMP, so your patch shouldn't affect it (and if it does, it's unintended behavior on Magit's end). Note that, as the :package-version value suggests, this split happened in a relatively recent release, so previous some previous discussions on the list (e.g., bug#30434) are now out of date.