From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ONmEKFEWc2NlNwAAbAwnHQ (envelope-from ) for ; Tue, 15 Nov 2022 05:32:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mKqkJ1EWc2N9iAAAG6o9tA (envelope-from ) for ; Tue, 15 Nov 2022 05:32:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 78CDC3FCDA for ; Tue, 15 Nov 2022 05:32:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouncC-0006L7-Tz; Mon, 14 Nov 2022 23:32:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouncB-0006Iu-2e for guix-patches@gnu.org; Mon, 14 Nov 2022 23:32:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouncA-0006hP-QH for guix-patches@gnu.org; Mon, 14 Nov 2022 23:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouncA-0002VX-AC for guix-patches@gnu.org; Mon, 14 Nov 2022 23:32:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Nov 2022 04:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59253 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kyle Meyer Cc: 59253@debbugs.gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer Received: via spool by 59253-submit@debbugs.gnu.org id=B59253.16684867139620 (code B ref 59253); Tue, 15 Nov 2022 04:32:02 +0000 Received: (at 59253) by debbugs.gnu.org; 15 Nov 2022 04:31:53 +0000 Received: from localhost ([127.0.0.1]:52500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ounc1-0002V6-1x for submit@debbugs.gnu.org; Mon, 14 Nov 2022 23:31:53 -0500 Received: from mx.kolabnow.com ([212.103.80.154]:13690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ounby-0002Uq-68 for 59253@debbugs.gnu.org; Mon, 14 Nov 2022 23:31:51 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id B08D21854; Tue, 15 Nov 2022 05:31:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1668486703; x=1670301104; bh=IX8aQbwZ6lBpZD5fNqDU07ssxuJ2DckbyxH e3mOe/Cc=; b=GC/opQCQvGkjpWxxo7/UuF/AnBzim4bMNwAVjHKtKrTFFS6Q297 hAPBrDBHG7m/m2/UhRZ+GMWWuW1a2FFVhJ0b1DaATDPPyS2TjYmXZuwtXyUGUoRG Vdd/KVY21oCfCATmE03cCF2qfqA0FzPOq82Nkgm6jZawrvKlhjMnl19ogMEeNWdM L2SC2gOnDqKUJ4ADfPNqrv+Gdd67kJuOhgfUjmHsNrLQDBUHBFuQlvaN757fav0/ Nv4urZrZ8mRlTzbHQQHhp/n82j7hyEWic/rAqtlMZTX73wTzGW6A8qydxnDHX1E6 Hcmo2/dhhfNAocpP0woxLn2RfMDk9TGjxC4bZaKJbOovweHmZlRmy74oNo/HYXeh NDGc2g/ADgMIZBQ/gU92yTeysbPaeuryUi3SegLy5/DkbnkKmgZMZtKepKX1FrRB KIwqW0rqWeQb5bSw9kfhZ1tvuJKkjpzyVHVG12Ls/8GZWwDwlk0WfWRj7mzXCofT zLm7+oiOi1GHxSHAoZV/1o2octwrrsW0sA2SbeVphJi2yXmSWAyiABpUPCO9gkjj 2o7z79jarocMvOIH7bJ1s4dcZxDGPEtsrLh9u5FMtDUxkfp+2Y8W192xkPXrct1v liIwSLGrIPP+ySysMFhUY37fAk/g0W+shaVW3mQVi6HP5ILbUM01f6bU= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F5cgPjS-E-Yg; Tue, 15 Nov 2022 05:31:43 +0100 (CET) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by mx.kolabnow.com (Postfix) with ESMTPS id 64EE51853; Tue, 15 Nov 2022 05:31:42 +0100 (CET) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx001.mykolab.com (Postfix) with ESMTPS id E3F418CB; Tue, 15 Nov 2022 05:31:41 +0100 (CET) References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> <87r0y6pkac.fsf@kolabnow.com> <87y1seqlwm.fsf@gmail.com> <87h6z2p6jc.fsf@kolabnow.com> <87cz9pvy23.fsf@kyleam.com> Date: Tue, 15 Nov 2022 01:30:17 -0300 In-reply-to: <87cz9pvy23.fsf@kyleam.com> Message-ID: <87cz9oq1nb.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org Authentication-Results: aspmx1.migadu.com; none X-Migadu-Scanner: scn0.migadu.com X-TUID: Xn0KZ7tOzPDN Hello Kyle, Kyle Meyer writes: > Thiago Jung Bauermann via Guix-patches via writes: > >> Maxim Cournoyer writes: > [...] >>> Won't this make magit unusable from TRAMP (which already seems broken >>> for me since the time we enabled native comp -- anyone else?). >> >> Hm, interesting point. I don't know. I don't use TRAMP because it was >> too slow for me in the couple of times I've tried. >> >> magit/lisp/magit-git.el does have this custom variable though, which >> this patch didn't change: >> >> #+BEGIN_SRC elisp >> (defcustom magit-remote-git-executable "git" >> "The Git executable used by Magit on remote machines. >> On the local host `magit-git-executable' is used instead. >> Consider customizing `tramp-remote-path' instead of this >> option." >> :package-version '(magit . "3.2.0") >> :group 'magit-process >> :type 'string) >> #+END_SRC elisp >> >> So I'd say it's possible that my patch doesn't affect whether Magit >> works from TRAMP=E2=80=A6 > > That's right. magit-remote-git-executable is the executable that will > be used when operating remotely via TRAMP, so your patch shouldn't > affect it (and if it does, it's unintended behavior on Magit's end). > > Note that, as the :package-version value suggests, this split happened > in a relatively recent release, so previous some previous discussions on > the list (e.g., bug#30434) are now out of date. That's great! Thank you for the clarification. --=20 Thanks Thiago