From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ECyuEGJrgmPMYgAAbAwnHQ (envelope-from ) for ; Sat, 26 Nov 2022 20:39:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MFvOD2JrgmMDPgEAG6o9tA (envelope-from ) for ; Sat, 26 Nov 2022 20:39:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C15343D1E5 for ; Sat, 26 Nov 2022 20:39:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oz10z-0006PA-Ff; Sat, 26 Nov 2022 14:39:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz10y-0006Oz-Ma for bug-guix@gnu.org; Sat, 26 Nov 2022 14:39:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oz10x-00071s-AE for bug-guix@gnu.org; Sat, 26 Nov 2022 14:39:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oz10w-0006Pd-D2 for bug-guix@gnu.org; Sat, 26 Nov 2022 14:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#59423: Invalid 'location' field generated in dovecot configuration Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 26 Nov 2022 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59423 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: Pierre Langlois , 59423@debbugs.gnu.org Received: via spool by 59423-submit@debbugs.gnu.org id=B59423.166949150824640 (code B ref 59423); Sat, 26 Nov 2022 19:39:02 +0000 Received: (at 59423) by debbugs.gnu.org; 26 Nov 2022 19:38:28 +0000 Received: from localhost ([127.0.0.1]:41481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz10O-0006PM-8Q for submit@debbugs.gnu.org; Sat, 26 Nov 2022 14:38:28 -0500 Received: from mout.gmx.net ([212.227.17.20]:51635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz10K-0006PD-Jk for 59423@debbugs.gnu.org; Sat, 26 Nov 2022 14:38:27 -0500 Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N4hvb-1or4oy2ENj-011giL; Sat, 26 Nov 2022 20:38:15 +0100 References: <87y1s5wa4p.fsf@gmx.com> <87v8n2iytp.fsf@gmail.com> <875yf293ph.fsf@gmx.com> <87y1ry7o69.fsf@gmx.com> <87cz9a7n4y.fsf@gmx.com> <87fse6fmrq.fsf@gmail.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Pierre Langlois Date: Sat, 26 Nov 2022 19:32:37 +0000 In-reply-to: <87fse6fmrq.fsf@gmail.com> Message-ID: <87cz995wwu.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:Wti0A3CGONpwj3WlJnOvaDerYz4hse28BoD1T6Jz2LNPg2suPIp ZmM9JcvvFfds9sPyKfPD31h9RMVc1NBYcFaO6DsoBvwVxCBrSHKKdQZaBcyq+Ao52cin8GE fyCHlf44O21YrBh2FawyLOq6NhjZylyXRV1me+ribI67UclQF4R7bO+N5fHZlSpj7a+EL7l vfyslS4qjw4TEH5gHgLhw== UI-OutboundReport: notjunk:1;M01:P0:PiKJvwNLSEE=;1tcZTXfTTDoZHd2hCqVGofjpyKS lRAJ7xkVngIPnG+2XxNzJmiZgmUMn54PESneB0VSPzQnilVywS8yG1pDjyctRt18jpwjQQ4MK zxcYuGfSduuaamiphpC0pesMYZxkKjTkWq4VPAS6CDkED9tKpxiUr1WXOGvHxt0kUbSCpjrFE NgGVtzRIXV61CgjULm7E9lx/u8Hb8K36YyQ1cjNuMnr1jJesHhTMYn+2rxfoRzCZrWhQbeWkH 6OTwXS7enaLy2atpXcN2OAvtWPjIl0xlYe05H6eq6U8KKbNWVgXkL2O4M5aa2L3IBsUODurcx n0e8RDOfh2d2civZNiToj69zCEYe6zjCRhkIHxOo3/MVCnKscJQe5blDBZgdu0T4UlhmDj55E P836jSS2FOq2VTSsbWxXYq4NVzuLTcVbgMRDrppvuyGOKqE+6QJWFa6WtaI4X4j36Vpva/Wj4 KyrSZmNqYKTqITXiS1E7gW/J+A7H8vcHOt38xNA9ilQ8PmUAgmSW+Rou2fy70n/N8BaWerS+o 49HxFt4oISh5cWprDQzOvBOMXEfd9uzg4NVIcUx7iMEdVimFoJkQhBU3sVZsWz12kTFR4hIy+ nAfL7o8dEnBvpm7LvyZfm+cj0vYeChnTsKUfLl5WER+lm2djjFfeOkbgwJGyeV8wBTNQhof3h 0QVxSFTS8yO3TVOShw0S7ydcv2T8s8LTofOVHbs6IuxP9ZbuF6uR0HbEG5w6Ai1xgHGV7J6Jh oewF0WMHAxa/loS/4fiRHypd2yIOYgmCooysK7O3AYse8v/YaA30vEHV4aygmn8MY9tuLwmdq 8WQT+prGf5AmvkAV26Q21A+MJOiEF0JFD4XtGuXYYdkKk0ikeG4kDd0WzJn6+XG7Im37rXVN9 nbGdxQj36Eu1pc/DUmHP0s9HkcgwGHPIS7jFYkH8BQIxak+P3++yxohAUEu4qdvSsJZvFG/sz l8q+xg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669491554; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=tRoq1VFEZa/9BG70stMEPWxrDnpiBRrP7GUUMKNAIck=; b=gFCh6ro7JkUmo+U6V3cSvVpNQYXeboLu/vVkCQlmLRRWMr0D6RAFCe9rxmIkUgM0S74nVS JXNV0JdtSBU1Ea3Wr9LswOeTrLgs1id/yv9RF3/uf9ubh5G03eCAtXGD24i+j6mgip6aJa fLCoOEw7ag1sKakOD5Ro25Vink+i9DoZ63ST5QR3dMBI7md3bdSf5KHitJgR2oR4gTfakN OZN46ZZIkMjCZx95FVcxrOL7358IJ3oUodgHKCqLFlHpgNZKk/43epJaKWLdk+90uRYvBB bsirEAjKXgtxhNc95gEZjoGIdJKod4NANzmv2JBrJeMb3ykiUiWj75qXFXNZQA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669491554; a=rsa-sha256; cv=none; b=RzjUztTR5N57i2pA2QxKAfj/ZFhYa8ncBw84ee2GpbD6p8pn2qglVZNaQHd21XfhBtOe9n Fil1CYOvuT5nSJw9JO0VHBoZrZXHXYLwFaltFiVVWyndmqMce703ZnTzSNC+PJv4NYNvIW BaMwp1qg4OY0EBGs/gkiPsEg8IzxCmanbIgd6Wh2qvTyc+UPvNMwKK1JGYa0m2kZW42ycw v/JNHGvWo9phENkGvLcK2FY60OipjiwOSViCvVEzNPx7/VfiVFtFoPu/L5DSbGgqHVtaWj kP0L8aMbKC3KVGNPjAzQGZDbDo5nJmjXuQpNyL806m4OTimVLYrjgSlICWK1Mw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.33 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C15343D1E5 X-Spam-Score: 0.33 X-Migadu-Scanner: scn1.migadu.com X-TUID: I/zNvKn+6EV2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Maxim, Maxim Cournoyer writes: [...] >>>> Yeah I'm afraid I still see the same issue after a `git pull` just now: >>>> >>>> ~/code/guix [env]$ ./pre-inst-env guix system build -e '(@@ (gnu tests= mail) %dovecot-os)' >>>> /gnu/store/ayfvf5s561q955kv8wrkklrvq3ga3qpy-system >>>> ~/code/guix [env]$ guix gc -R >>>> /gnu/store/ayfvf5s561q955kv8wrkklrvq3ga3qpy-system | grep >>>> dovecot\.conf | xargs grep "^location" >>>> location=3D#< file: "gnu/tests/mail.scm" line: 297 column: 2= 0> >>>> >>>> Have you tried to rebuild from scratch, after a `make clean-go'? When >>>> first bisecting this, I was working from the git repo and couldn't >>>> reproduce the bug. Then it worked by using `guix time-machine' to bise= ct >>>> rather than work from git. >>>> >>>> So I'm guessing the change being in a macro, there could be residue .go >>>> files that need recompiling? >>> >>> Oh, I just realized the change was reverted with >>> 44554e7133aa60e1b453436be1e80394189cabd9, then I'm probably the one who >>> needs to do a `make clean-go' :-). > > The change was reinstated as part of the mcron update, in > 44554e7133aa60e1b453436be1e80394189cabd9. The bit that seems to cause > the issue here (still not clearly understood) is probably this one: > > diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.= scm > index 636c49ccba..dacfc52ba9 100644 > --- a/gnu/services/configuration.scm > +++ b/gnu/services/configuration.scm > @@ -242,17 +242,17 @@ (define-record-type* #,(id #'stem #'< #'stem #'>) > stem > #,(id #'stem #'make- #'stem) > #,(id #'stem #'stem #'?) > - (%location #,(id #'stem #'stem #'-location) > - (default (and=3D> (current-source-location) > - source-properties->location)) > - (innate)) > #,@(map (lambda (name getter def) > #`(#,name #,getter (default #,def) > (sanitize > #,(id #'stem #'validate- #'stem #'- = name)))) > #'(field ...) > #'(field-getter ...) > - #'(field-default ...))) > + #'(field-default ...)) > + (%location #,(id #'stem #'stem #'-location) > + (default (and=3D> (current-source-location) > + source-properties->location)) > + (innate))) >=20=20 > (define #,(id #'stem #'stem #'-fields) > (list (configuration-field > > > Reverting it would likely fix the issue (haven't tried), but it'd be > nice to have a clear understanding of what's going on. It may have > unmasked a bug waiting to bite. > > The issue seems to be with the serialization of the > object nested in the > record. I tried this at the REPL: > > scheme@(guile-user)> ,m (gnu services mail) > scheme@(gnu services mail)> (namespace-configuration (name "inbox")) > $8 =3D #< name: "inbox" type: "private" separato= r: "" prefix: "" location: "" inbox?: #f hidden?: #f list?: #t subscription= s?: #t mailboxes: () %location: #f> > scheme@(gnu services mail)> (serialize-configuration $8 namespace-configu= ration-fields) > name=3Dinbox > type=3Dprivate > separator=3D > prefix=3D > location=3D#f The location here should probably be empty rather than `#f' no? It looks as though the value is coming from the internal %location, rather than the user-provided location. If the two fields can shadow each other, then indeed, that looks like an existing bug that was exposed by the reordering, rather than a bug with the reorder itself. I'll if I can find anything the macro, it looks quite complex to me :-). > inbox=3Dno > hidden=3Dno > list=3Dyes > subscriptions=3Dyes > $9 =3D # > > But as you can see, it doesn't reproduce in this environment. I'll keep = experimenting. Thanks for looking into this! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmOCayEYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UJgsH/1KrMAZoMc0iCSG+uravBtrs PME4RibTpBGu5Wph10vhLpwM/n92SxwKugUFnDebODbbXAD4MpVlB5QeT7YRAIEF ksUg1+lUKhgFAGtQqjLY4HT6QVCgn5mz0srG02ruGl942MIOPjgWN3FdvQyexyz6 wFVep+4i5Ka8wCGUwpYtRGlxOa+vMwc9u8CuSLICjZs1p4YClk3K0z3NxYGJuvWt hR4DSTDAdXkRC9QX81LC6uuj8w6Moq4XuMOlv5oNNAHUAVZQizdE/yKEW+4c7hl9 FWKe6ysEgEloN9UicoPxJRFAiWOL1fP9A2H6Y9fdAauP6yBJJNrMhcyDPwLRW0E= =2/cA -----END PGP SIGNATURE----- --=-=-=--