From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YG5aLMq+UWRREQEASxT56A (envelope-from ) for ; Wed, 03 May 2023 03:54:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GBevK8q+UWQemQAAG6o9tA (envelope-from ) for ; Wed, 03 May 2023 03:54:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 65BA83FB5F for ; Wed, 3 May 2023 03:54:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pu1gx-0005Tj-TS; Tue, 02 May 2023 21:54:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pu1gw-0005Tb-QL for bug-guix@gnu.org; Tue, 02 May 2023 21:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pu1gw-0004P2-C0 for bug-guix@gnu.org; Tue, 02 May 2023 21:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pu1gw-0005l6-4W for bug-guix@gnu.org; Tue, 02 May 2023 21:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH 04/17] services: mpd: Obsolete the 'group' field. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 03 May 2023 01:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168307882022106 (code B ref 63082); Wed, 03 May 2023 01:54:02 +0000 Received: (at 63082) by debbugs.gnu.org; 3 May 2023 01:53:40 +0000 Received: from localhost ([127.0.0.1]:45329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pu1ga-0005kU-7f for submit@debbugs.gnu.org; Tue, 02 May 2023 21:53:40 -0400 Received: from mail-qv1-f51.google.com ([209.85.219.51]:54418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pu1gX-0005kG-L2 for 63082@debbugs.gnu.org; Tue, 02 May 2023 21:53:38 -0400 Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-5f45fad3be1so39596146d6.0 for <63082@debbugs.gnu.org>; Tue, 02 May 2023 18:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683078811; x=1685670811; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Qcs7i+5Pz/Zl1Yxu+CVMkPd7zPwNOgmyreMCqN/Sd00=; b=WDZ48xn1TDiCmBJSq87f3eeXo44QdFqtfBurkYMS2TtDmLffJwHyGuXYtoQ0LZANdF 7MWLCqpmfV0mZgNtqnxSaTh6cGlXATlgjXY325W6u6VbNrfmEXvbpCRLRREFjZHVfiSd o7yvoPKFwrqjuPLn5y9PTI6Fa8CzBzt9S+Up+v0mL1AVIu2vIkljy7FhvYdp60WsIAzx lCE10/LGJMIyctN+JN5T/fuBkHHzOcDXe3FrxZt1eHii1JlKCPO3rT5MOumijUtaMOOD B5JaHw2t/2F/Yiqy5PfyV9CduxBofGvsGXHSOCLzSSoRcw5ig1heVv/KjtkuEX23U4b0 7Exw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683078811; x=1685670811; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qcs7i+5Pz/Zl1Yxu+CVMkPd7zPwNOgmyreMCqN/Sd00=; b=VVPooTL47gYZj82HHa2wh2rcsmM18RKhkLtyupS7/ahdvOfSsxZDVzKSID6p44dSMH gv4/ZTqbQzB0X788CpMQDxMCPIjmoY7uk2zsFtMqOMuJw9/gtiYrP+toMtqA5tzTxUvq G6z5b0xl8oEe0b9aIdYo9gPC4G6IGqHu9Gtgo5SR8MITNqSgDnrTYQHn5nrUjvfn4jyh 1ojo0QQMWFK1B+dITPnx0O/PgXFTemqhD1mqlcBH4RZtaFgMj0B0kjXysLQeJoDV2tD6 qRClZc7A7+wFda4ArGqWQPsmwgI/Ra7fxDNgmhm7ki2aOk1p0Lnkhzd2nv/1svlJaoVL tXCw== X-Gm-Message-State: AC+VfDx8lHNUoeIj7jwTPs+29tdts0ss2MaRFP704qnxQXbfj+xEdYDN knXo91bk/KMKIv5vox0o4xHKpGJJBDRLOQ== X-Google-Smtp-Source: ACHHUZ7AyM64SUs+QCe5j7RL60QslTTqQmVWOKvSf3+S5dKy/dfyJCJc02skw2x91FJOswzpUoAfjg== X-Received: by 2002:a05:6214:407:b0:5f1:6892:743c with SMTP id z7-20020a056214040700b005f16892743cmr9351191qvx.24.1683078811639; Tue, 02 May 2023 18:53:31 -0700 (PDT) Received: from hurd (dsl-157-118.b2b2c.ca. [66.158.157.118]) by smtp.gmail.com with ESMTPSA id cp11-20020a05622a420b00b003f12f8616ecsm6135436qtb.4.2023.05.02.18.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 18:53:31 -0700 (PDT) From: Maxim Cournoyer References: <172f246e91445b431fb289b6cb346d37a8da1c08.camel@gmail.com> <87ilde8v7v.fsf@gmail.com> <652275711a94ce83399f8e79d545fbbe230ee824.camel@gmail.com> <87zg6o7tb6.fsf@gmail.com> <78b82d9f5eda10fab81c05ac6159798c39003110.camel@gmail.com> Date: Tue, 02 May 2023 21:53:30 -0400 In-Reply-To: <78b82d9f5eda10fab81c05ac6159798c39003110.camel@gmail.com> (Liliana Marie Prikler's message of "Mon, 01 May 2023 08:13:15 +0200") Message-ID: <87cz3i18px.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683078858; a=rsa-sha256; cv=none; b=ayjrFM3slktxTJ4BMDY3RNEYWJBPRdxpHxHNMFdwd2myH+cW5Wxn4Tvlh3VEW7RMofUcDM uNWwETXovWano68LENJNxd1QYR2FosGC8j5L2WrO6vH55MZOkeXKdyt+EB/PtN4AJU/8sC tssSURKaSQ+ZM37FYkGShLZXtjwySZOSlJWgmg4R7Ku1DaZ6ZeBqxSmCaBTKoCt2UMmva3 Ue5jS+eMvOJLRxiulZf6hiIQEV31d3WX5yV6/SXRqVyBi9rMjYuFGhDiNvxoMAB1r8pd3x 6lDvbsNB4tU58DvYV5yoyeyUjAnoEI6KfQWvZnLmq7Ugkj4r8ILbh+/3LY1YrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=WDZ48xn1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683078858; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Qcs7i+5Pz/Zl1Yxu+CVMkPd7zPwNOgmyreMCqN/Sd00=; b=FKG8d3hkb1Y4gCkEf7aHDBdkF37Kd37rJH482L481R8ORo48pGwmiHoeQG7Z1nU2525tmG G6o+V/hAMW2YMiFYiLLHnCnZGZw1FUlSZVdg9Ns7XBCrU54W1+ylodvafwq+oeCBiS9+H3 0fBz4S5b4NT1URMAo6/pXA6Nc6IG+mBfsv3VEk1tmRFXeNVIL+MgMxVHoeKxvZYPtwAqyI fa3bYo2RSH1wufB+1zcKWujXq2xSPxspoZAoiZCXgkQ+rnxxPtCu3W4OSC0JdSzZbGIjUR cL/977NpEXJ51i/VORZbtRWWlpnGowA7MM3mtbghD9yXRB+auEJzZ0asYVH3IQ== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=WDZ48xn1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.80 X-Spam-Score: 5.80 X-Migadu-Queue-Id: 65BA83FB5F X-TUID: WRWpJpG5Qc8t Hi Liliana, Liliana Marie Prikler writes: > Hi Maxim, > > Am Sonntag, dem 30.04.2023 um 21:07 -0400 schrieb Maxim Cournoyer: >> > In the current mpd-configuration, to use my own user, I must also >> > provide the matching group as a record, even if >> > e.g. 'users' is something I've never created myself and don't >> > really >> > have a clue as to how it was defined without looking at the source, >> > yet it's important that it matches the original definition >> > otherwise >> > I'd have two same-named groups differing only subtly, which would >> > introduce issues probably harder to diagnose than "sorry, no such >> > group!" > The "find by name" pattern applies here as well. We could extend the > semantics of group field so that if a string is passed, %base-groups is > searched for a matching name first instead of constructing a new group. > This would allow you to more easily specify (group "users") for > example. > >> > One way that seems like it'd solve it is to make the group field of >> > a >> > accept a ; then the user object would be >> > self-contained as far as extending user-accounts goes; the API >> > becomes a bit more obtuse though, especially when you simply want >> > to >> > specify a group known to exist ('users', 'audio', 'netdev', etc.). > Not really. If the allowed for a group, we > could drop the group field in the MPD specification. The semantics for > string groups would remain unchanged, whereas groups would > get added to the accounts service as though they had been specified via > the groups mechanic. We'd only have to twiddle with account service > there and the change would probably benefit every service that requires > an account:group pair. I think I'd favor the second option then (migrating to support both and strings), so that every service could benefit from the change, as you've noted. I don't intend to work on it in the scope of this series, but I think it'd be a welcome improvement! -- Thanks, Maxim