From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0D2REGRrX2R4FgAASxT56A (envelope-from ) for ; Sat, 13 May 2023 12:50:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8JJ7EGRrX2QxVAEA9RJhRA (envelope-from ) for ; Sat, 13 May 2023 12:50:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B4B3CE037 for ; Sat, 13 May 2023 12:50:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxmpB-0002UQ-Bd; Sat, 13 May 2023 06:50:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxmp8-0002UH-Up for bug-guix@gnu.org; Sat, 13 May 2023 06:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxmp8-0004D6-Ke for bug-guix@gnu.org; Sat, 13 May 2023 06:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxmp8-0005MO-GK for bug-guix@gnu.org; Sat, 13 May 2023 06:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63427: gdk-pixbuf unable to recognize image formats (JPG, PNG, etc.) Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 13 May 2023 10:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63427 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Nathan Dehnel Cc: Josselin Poiret , Liliana Marie Prikler , 63427@debbugs.gnu.org Received: via spool by 63427-submit@debbugs.gnu.org id=B63427.168397497120561 (code B ref 63427); Sat, 13 May 2023 10:50:02 +0000 Received: (at 63427) by debbugs.gnu.org; 13 May 2023 10:49:31 +0000 Received: from localhost ([127.0.0.1]:36091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxmod-0005LZ-9v for submit@debbugs.gnu.org; Sat, 13 May 2023 06:49:31 -0400 Received: from relay.yourmailgateway.de ([188.68.61.103]:37439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxmoZ-0005LO-Uj for 63427@debbugs.gnu.org; Sat, 13 May 2023 06:49:29 -0400 Received: from mors-relay-8403.netcup.net (localhost [127.0.0.1]) by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4QJMny3Y4mz7xmC; Sat, 13 May 2023 12:49:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de; s=key2; t=1683974966; bh=7TvvlxIi5rv3MObiCubh9wkigyqdqVAmuEYwzb424gE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IeuoU2dUCvFRPKzgAy+lBj8gpwuGEbhHOOW5hTrLM9u0FFNZf7gKmvpi6qgcye0U2 e4Co4y3V2MPEzlb6DuzwaJ1xZtQI4Alt1uA3tKR9pWN+RJeP3/sZy55TpYMkMM5e6T tB0IlLuvjxbZ5bQirffX4n3EvFAnpXkmBdA6wduGo+bdwRuKrW8Yhag3HBFEXYne1e NGWSiFMORARMcan6UH6DY2QIo7OSaB70qM0JueqVuGtHWQi0FkI1tippmSQK5IHhPP DvswLYqr1R8TRbYqoPIAcBYwbqXuHqDwM/wK887CTBSTWsvvR0yTsgBWrmSLeCjPkl PYhvlRsBXrwag== Received: from policy02-mors.netcup.net (unknown [46.38.225.35]) by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4QJMny38Qpz7xm2; Sat, 13 May 2023 12:49:26 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at policy02-mors.netcup.net Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4QJMnx4yF9z8sh1; Sat, 13 May 2023 12:49:25 +0200 (CEST) Received: from florianrock64 (ip92344de0.dynamic.kabel-deutschland.de [146.52.77.224]) by mxe217.netcup.net (Postfix) with ESMTPSA id 3EA3C80790; Sat, 13 May 2023 12:49:18 +0200 (CEST) From: "pelzflorian (Florian Pelz)" References: <874joje1ii.fsf@jpoiret.xyz> <5d2305c2acf0784713b7d32e6485a80e35171269.camel@gmail.com> <87bkipaovk.fsf@pelzflorian.de> Date: Sat, 13 May 2023 12:49:16 +0200 In-Reply-To: (Nathan Dehnel's message of "Fri, 12 May 2023 16:21:53 -0500") Message-ID: <87cz34ecb7.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Rspamd-Queue-Id: 3EA3C80790 X-Spamd-Result: default: False [-4.10 / 15.00]; BAYES_HAM(-5.50)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; RCVD_COUNT_ZERO(0.00)[0]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:3209, ipnet:146.52.0.0/16, country:DE]; FREEMAIL_TO(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; TAGGED_RCPT(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,jpoiret.xyz,debbugs.gnu.org] X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: xxZcuZxd7yOKy2tHzJvDJ/MHwpeB14P2/jczgt0qqt5W8nYkuNBHFlxl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683975012; a=rsa-sha256; cv=none; b=RBRSqSMUlDqmTp7DCweWfVjoNUcEeQmzTnlOkuys9N9Bno4VToUTktRyjxXQMivBA2o7sn nXvXnjzP28IX7/xEhQ1lq2O0Bsua9NOxVUzNsIrlnV4/d5vJ6sf1UIDD5p7po/JPZy3quW rbw7t9EA5gbBtfNb68X3DyJuFDRghTYRbHZOaLgP4JToPLvKKUGZZ+M334sjVG3iQovvx3 eqRKRyFitR0JANYZF2eO5b957rEGjR+uc41F9Bgv55UV/WKmfRyyziV1JdWFDbH/jZHQJd bv2S7n6+EVCdgmGcTeNjZKwPuocitQ/kzwKvZ6oaQnwOP3vRsfOTdtypR2JX4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=IeuoU2dU; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683975012; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BM1W5VgjVR9WSQe+XfktzCqpmn/g2nGniK0AzIUBQ3k=; b=qPDKfLLNmiHmH0snHCPRhtOD7iELsQjwyFv+5TYeelmWdpjNXlqD1M6m0xYHctR9P87F2K vMNuD9t/8gBooxDNvnTgdJc2ztBKrX7jZyg4VU//O0hHxTY6io8S77wfqllu3IHGreZJmK Uj/CyjY9pahVi4YkD4geJ0rraljs8QQZ2Kq+Sby5RIvJhHCT3GHtht+dljsgaLpRd1jCME Tb4NVMq6j3HzJGuSrIyYQ7XXUDBznyIrbcWEY2aEBzWMkqlsUjFfBVaoR9m8vWOANeLujP XtkrUZHFHBYk95uNTSt+TwMb2IKYY2oFPcO9RP4Db0Jm3K1GNdCTeZ/O1ZocQg== X-Migadu-Spam-Score: -0.61 X-Spam-Score: -0.61 X-Migadu-Queue-Id: B4B3CE037 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=IeuoU2dU; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: BQ9MdcOGxzbM --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Nathan Dehnel writes: > Yes, that one works That=E2=80=99s good. This means maybe either - if guix shell without --pure works too, you just have not run =E2=80=9Cgu= ix upgrade=E2=80=9D recently, or - --pure helped and viewnior is not compatible with the Adwaita dark theme, or - --pure helped because you have misconfigured something that breaks the installed viewnior, but leaves the pure one intact. What remains as a bug is wrapping the viewnior program inside gdk-pixbuf, so installing gdk-pixbuf is not needed anymore. Untested patch is attached. But then other image loaders installed by the user to support e.g. libexif would not be usable anymore. We could also add libexif, but do we even want the attached patch? Or should it be up to the user to install image loaders? Regards, Florian --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=viewnior-Support-image-formats-out-of-the-box.patch Content-Transfer-Encoding: quoted-printable >From 29c76710eea6720aa4b5e774a83ce19e577937ac Mon Sep 17 00:00:00 2001 Message-Id: <29c76710eea6720aa4b5e774a83ce19e577937ac.1683974741.git.pelzfl= orian@pelzflorian.de> From: Florian Pelz Date: Sat, 13 May 2023 12:33:26 +0200 Subject: [PATCH] gnu: viewnior: Support image formats out of the box. * gnu/packages/image-viewers.scm (viewnior) [inputs]: Add 'librsvg-for-system'. [arguments]: Enable 'glib-or-gtk?' to make available GDK_PIXBUF_MODULE_FILE. Wrap viewnior to use it instead of the image loaders installed by the user. --- gnu/packages/image-viewers.scm | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index db7a44d4ff..bbe26aadbe 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -27,6 +27,7 @@ ;;; Copyright =C2=A9 2022, 2023 Maxim Cournoyer ;;; Copyright =C2=A9 2022 Tomasz Jeneralczyk ;;; Copyright =C2=A9 2022 Cairn +;;; Copyright =C2=A9 2023 Florian Pelz ;;; ;;; This file is part of GNU Guix. ;;; @@ -425,12 +426,22 @@ (define-public viewnior (base32 "14qvx1wajncd5ab0207274cwk32f4ipfnlaci6phmah0cwra2did")))) (build-system meson-build-system) (arguments - '(#:phases (modify-phases %standard-phases + '(#:glib-or-gtk? #t + #:phases (modify-phases %standard-phases (add-after 'unpack 'patch-source (lambda _ ;; Don't create 'icon-theme.cache' (substitute* "meson.build" - (("meson.add_install_script*") ""))))) + (("meson.add_install_script*") "")))) + (add-after 'glib-or-gtk-wrap 'wrap-pixbuf + (lambda* (#:key outputs #:allow-other-keys) + (let ((viewnior (string-append #$output "/bin/viewni= or"))) + (wrap-program viewnior + ;; Wrap GDK_PIXBUF_MODULE_FILE so viewnior can b= e used + ;; to view JPG, PNG and SVG, without the user ne= eding + ;; to install gdk-pixbuf or librsvg. + `("GDK_PIXBUF_MODULE_FILE" =3D + (,(getenv "GDK_PIXBUF_MODULE_FILE")))))))) #:tests? #f)) ;no tests (native-inputs (list gettext-minimal @@ -440,7 +451,8 @@ (define-public viewnior (inputs (list exiv2 gdk-pixbuf - gtk+-2)) + gtk+-2 + (librsvg-for-system))) (home-page "https://siyanpanayotov.com/project/viewnior") (synopsis "Simple, fast and elegant image viewer") (description "Viewnior is an image viewer program. Created to be simp= le, base-commit: e3e011a08141058598cc7631aeb52d620a3ccb8c --=20 2.39.2 --=-=-=--