From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GDEzNx6VZ2RqCAAASxT56A (envelope-from ) for ; Fri, 19 May 2023 17:26:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qLo5Nh6VZ2Q1xwAAauVa8A (envelope-from ) for ; Fri, 19 May 2023 17:26:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A086C8D47 for ; Fri, 19 May 2023 17:26:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q01zX-0001ew-H0; Fri, 19 May 2023 11:26:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q01zW-0001eY-5l for guix-patches@gnu.org; Fri, 19 May 2023 11:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q01zV-0006CR-UJ for guix-patches@gnu.org; Fri, 19 May 2023 11:26:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q01zV-0000tQ-R4 for guix-patches@gnu.org; Fri, 19 May 2023 11:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63135] [PATCH 0/3] MATCH-RECROD improvements Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 May 2023 15:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63135 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "(" Cc: Josselin Poiret , 63135@debbugs.gnu.org Received: via spool by 63135-submit@debbugs.gnu.org id=B63135.16845099553406 (code B ref 63135); Fri, 19 May 2023 15:26:01 +0000 Received: (at 63135) by debbugs.gnu.org; 19 May 2023 15:25:55 +0000 Received: from localhost ([127.0.0.1]:57157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q01zG-0000sd-LS for submit@debbugs.gnu.org; Fri, 19 May 2023 11:25:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q01zB-0000sJ-K7 for 63135@debbugs.gnu.org; Fri, 19 May 2023 11:25:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q01z6-000688-DC; Fri, 19 May 2023 11:25:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=rRWO9Q1BhQneFtzmS9BRVGQeC2U45t0sFBVlGTcKHBo=; b=cbxBhbZ4wkWomNFgjiCC doTgM/V1TKRFosdb18WsE57y7TbPXbc36g9pqnupI5/B4ImvBR6LVRpDLc/zuxyUMxsFlgmZ9PsK7 kMqlUpAVmBpIravlMNpYobKSeJcmDETurX8lagVBFhQKfeM9DI0g6rPa2ebH1CTv2qiaeAmY3MDo2 1t3RdeRpPxaPUTSQx/XHL6+qE/L0+TMvjOuVa4aL0i23ekLDloy7GP5fB30L3WLPq/inGtFusy/T2 I0ZUP04x8/HObpszkFPc1GibrzNAot9LggBbLmwxAeH0YIByDPZU6PTCceBfOE4dzAJJD5GGOOlkP rfYyqS4Qrb5S0w==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q01z5-0004rn-Rw; Fri, 19 May 2023 11:25:36 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230428191905.13860-1-paren@disroot.org> <20230428191905.13860-3-paren@disroot.org> Date: Fri, 19 May 2023 17:25:33 +0200 In-Reply-To: <20230428191905.13860-3-paren@disroot.org> (paren@disroot.org's message of "Fri, 28 Apr 2023 20:19:02 +0100") Message-ID: <87cz2wxs0i.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684509982; a=rsa-sha256; cv=none; b=g594jvk+ZMu6fdRrLeB0u3lltdzQwVNfk/kjvlbQalv+MjmxhPkTR+fgNettiZFDr/5zrv 2JmZ3rtmKtHSxzIo0TuAA8zuyDimsDDTUnTxzCRT80k14OUwF3Msh/2LNQyzDtqemP4MPH H4lZGsr3CvIKEMw498tTCRHh1soUkH0jfjEvcCBC5laKIOjdWxMIhH59e7gO4szG4bCbx5 BUAkG+0JZI8ALZ1jB74mpNeFJaGOVncRJitJ2HcsM28GVfM1pxnXsZBkXql0YFjkY8iTBc erGXGNkyt0Augf6DvxXF6npH9rwF0I6eAVDM3IELnrz+aJ72p3RI7sKFfmepwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=cbxBhbZ4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684509982; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rRWO9Q1BhQneFtzmS9BRVGQeC2U45t0sFBVlGTcKHBo=; b=TTud6WPL+TXcLvD2I4xEP9pYgZCusBTDDsxeUXFJf/gSON1KU6Df8yCou9VvWPj2FaWKP3 W6K3BfAw7SLM/4XTs9MUlRgFf6UZ2IpM0G82sjGiZASDD45F7mQ+mB7kdCVf7DQU5hz0wA PRfvsRMcBfT5u4exXM5BQU5u4jtX2DYdFKGbwWdmCIfLU4TuDECN35/YgY8aoYppLt01y6 ljcQqVlJXzJydrARyNvPLbDlh59YxFEh+7dyUu9glQWJv5XWuOqsNReYAk9dgRqckKiGBZ 9amv8NNsXcLpbH9MNTY7OQYuhPwooPNdclDeg3zbeKlFq9anBQMr+rkmx8TBcA== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=cbxBhbZ4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.59 X-Spam-Score: -2.59 X-Migadu-Queue-Id: A086C8D47 X-TUID: 1a3iIqbX2uvd "(" skribis: > * guix/records.scm (match-record): Display MATCH-RECORD as the origin of > "unknown record type field" errors. > Show the original MATCH-RECORD form, rather than an intermediate LOOKUP-F= IELD > form, within said errors. [...] > (lambda (s) > "Look up FIELD in the given list and return an expression that repre= sents > its offset in the record. Raise a syntax violation when the field is not > -found." > +found, displaying it as originating in form S*." > (syntax-case s () > - ((_ field offset ()) > - (syntax-violation 'lookup-field "unknown record type field" > - s #'field)) > - ((_ field offset (head tail ...)) > + ((_ s* field offset ()) Maybe =E2=80=98source=E2=80=99 or =E2=80=98form=E2=80=99 rather than =E2=80= =98s*=E2=80=99? Should we add a test in =E2=80=98tests/records.scm=E2=80=99 while we=E2=80= =99re at it? Otherwise LGTM! Ludo=E2=80=99.