From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eC2AFr2Ea2RdLgAASxT56A (envelope-from ) for ; Mon, 22 May 2023 17:05:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uClxFr2Ea2SbSQEA9RJhRA (envelope-from ) for ; Mon, 22 May 2023 17:05:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2FF212A51C for ; Mon, 22 May 2023 17:05:33 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1764-0003aB-D8; Mon, 22 May 2023 11:05:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q175r-0003RZ-W1 for guix-patches@gnu.org; Mon, 22 May 2023 11:05:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q175p-0003TG-TP for guix-patches@gnu.org; Mon, 22 May 2023 11:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q175p-00049l-Oz for guix-patches@gnu.org; Mon, 22 May 2023 11:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63402] bug#63403: [PATCH 1/1] services: wireguard: Implement a dynamic IP monitoring feature. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 May 2023 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63402 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 63402@debbugs.gnu.org, 63403@debbugs.gnu.org Received: via spool by 63402-submit@debbugs.gnu.org id=B63402.168476786415905 (code B ref 63402); Mon, 22 May 2023 15:05:01 +0000 Received: (at 63402) by debbugs.gnu.org; 22 May 2023 15:04:24 +0000 Received: from localhost ([127.0.0.1]:35796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q175D-00048T-LP for submit@debbugs.gnu.org; Mon, 22 May 2023 11:04:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1758-000481-Kx; Mon, 22 May 2023 11:04:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q174q-0003HY-6S; Mon, 22 May 2023 11:04:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=CdwlsJJNdCd3v0HrP/VX7se/Vm5JtqQFRAyh1DH40iA=; b=Y/JNe2XHperIsbNv4Svi EUouTN6NQUQ88z/qnApwCq5LLBGUX4ylxfALKKWYhuddfRYRDV50aYjUKXhU32Vvnwn+qfRLENvRz 6EEWbKUIZSjd7aRUH60TQfBl7x0MS378eM7kTe86WiH7r+Sp2w8Wmtqh0cLFoLYnmoL+kDEgVl0Wr EP0gbQkgPMJu1bBc2SJiL3kLxz1IGV26SP8d5vrBNKXWhzMAktqJI+xgMz4DFsGH5EBJ6FxeuDDNe Esfl8gWLBc9V6nWFMUfxJ0Y6xcYJz1NpGiVw0vmHKL5eWSZ5+GWXTg613nNjtUnEGwdcX8r9clSI7 zW8AzlLK+bxubQ==; Received: from [193.50.110.247] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q174p-0003Nv-Bi; Mon, 22 May 2023 11:03:59 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Mon, 22 May 2023 17:03:57 +0200 In-Reply-To: (Maxim Cournoyer's message of "Thu, 18 May 2023 21:59:14 -0400") Message-ID: <87cz2swgpu.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684767933; a=rsa-sha256; cv=none; b=lX9A9cI7QI7AWEkRVgLevACG6V6dG6OR8GuOdkLW5DxEuBVsxtngQf1C+5+6cTSK9Tl4uI HM7FVZLUVeeXCe/cSIrIEpQAgo5d8JySa1NaXYwWEtxyxh9kIBPAElCx7lYZB1bwUpqOgw bndDDU2diYcPQh+/J2MN/38F+zctrgNp+HS898btAtT/10wCkq+NTDdcIgAd53JZp+MYc7 VsrlaoqtpKET6rW8SrSUENF3seU8/9uHFzX3O655TrYMZwgMSdrspnxK9+4gVV8tkM4TWP 0zZzlYQ8AC3S1sLGE0p0smBOVXQi71uTrFd6ojXRH9YVMigm+Ha8km1ibH8X2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="Y/JNe2XH"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684767933; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CdwlsJJNdCd3v0HrP/VX7se/Vm5JtqQFRAyh1DH40iA=; b=RQLUxgeufg9pqy+uzhrVbzNxCGYLWPYTHHEmw6u7KH5+Y+nCnqMJfhQDT2dpTj/5WJOuBL rS9FwBOGryRQO2ethgJnZdaMmz39ie6hYE+XGK1oz5OLR/ACsJlBKLN2UHNCVZ9/MOYfAk vm83oN1z+lk7dx8Aax7GkWIaAB/0ItnTkJ5SQA6S+D1h3fMM0LKfLp6Z9txfLHmHyqeUfU jc/x8G/GhfV9MK4sZSq9Ss9Xn99ZB06VFoEwVMFCknPNv+UHVJsaUcne0dFX0KcVblDexs clE75BONniN2QtqFXkDzRE/rsuSJbAeuFrqhK0rzhl9W7VLhA1ZAdi9iRgwNAQ== X-Migadu-Spam-Score: -3.41 X-Spam-Score: -3.41 X-Migadu-Queue-Id: 2FF212A51C X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="Y/JNe2XH"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: lUP0yGBpd/E1 Hi, Maxim Cournoyer skribis: > * gnu/services/vpn.scm () > [monitor-ips?, monitor-ips-internal]: New fields. > * gnu/services/vpn.scm (define-with-source): New syntax. > (wireguard-service-name, strip-port/maybe) > (ipv4-address?, ipv6-address?, host-name?) > (endpoint-host-names): New procedure. > (wireguard-monitoring-jobs): Likewise. > (wireguard-service-type): Register it. > * tests/services/vpn.scm: New file. > * Makefile.am (SCM_TESTS): Register it. > * doc/guix.texi (VPN Services): Update doc. As discussed on IRC the other day, I tend to think that this is =E2=80=9Cno= t our job=E2=80=9D but rather upstream=E2=80=99s. (As a rule of thumb, I think s= ervices should merely expose what upstream implements.) You mentioned that upstream has a shell script to do something similar. Using that may not be as nice as what you propose here in terms of integration, but the upside is that we wouldn=E2=80=99t have to maintain it ourselves. Would that be a viable option? WDYT? Thanks, Ludo=E2=80=99.