From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4PoeH2L2tmRP8QAASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 22:30:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KLzoHmL2tmS+qAAAauVa8A (envelope-from ) for ; Tue, 18 Jul 2023 22:30:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 130BB4ACE3 for ; Tue, 18 Jul 2023 22:30:26 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=cTW+ZHH7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689712226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gVPvKNxsd0PwWA5+tSPeczRRp8Q9GNve3x+HeVFS0Y0=; b=DioDrSQyJy7T21Rl0cnInzDrLVylXP9RmnTuMIoM02wL3JFHCwBO+U3xvP9L99vlcxpy79 gOUUx3cREsKCuYJJcGcwcH9z+2M+J1dkZTdHsmeBOHNrp0ES81Erq5V+i1z5AVXvI1hK3Q 1n5AF41bhVj2Gl1s3INJ9zXgo1W/bV6g7XHiT3fMCaSNqPy/MSNbSWIX4SeOmkzLeHSDpf 7L8x1s0Ny6FNiemadnjP3xUhLQ6sHEapAR5lEIi/vVvmAjQVXGwGMTn0pMArBaVP4Koz1M W6YJFSx1tFkDUAvQan6HXg0oQfKAaDOR5pqZcHw0d/PJpyQjmIA02BmVToA73w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=cTW+ZHH7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689712226; a=rsa-sha256; cv=none; b=IQtc1xW7ARLW3j25Xf/vazYIcHosmnirel6PYWTERqW/Bn4btlxQlSHXLj/aLQ7/jEF6bj cRfd7o0YGwkeTxZfM3aQ4qAknRCFX+JkPAmdcXMaAaIiqVuASbqRcdfAw2LOZvXjXAZXVR Hl++v90MkHzY71Uj4kdxHteKe328ovfjx8Jk3h4c1Opg1lzLi00MOHdBxRaGLwcHJsuSI+ No9TR2MNDLpUMVmrRm5q1OrwM/Q87xPGqamLUuWgSXzlOEnVVHy5ieBsRzQXiX/rmZ+2Hq PytBwGYzl2CC9A+YjA1axKZYNkoq8wWpOj5Bc3kj12Y5Dk2gWVfUJQqg5IhV/w== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLrKg-00039y-He; Tue, 18 Jul 2023 16:30:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLrKd-00039V-PU for guix-patches@gnu.org; Tue, 18 Jul 2023 16:30:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLrKc-0000Xd-FS for guix-patches@gnu.org; Tue, 18 Jul 2023 16:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLrKc-0004NQ-Bo for guix-patches@gnu.org; Tue, 18 Jul 2023 16:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64711] [PATCH 00/45] Fix builds and skip failing tests for the Hurd. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 20:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64711 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Janneke Nieuwenhuizen Cc: 64711@debbugs.gnu.org Received: via spool by 64711-submit@debbugs.gnu.org id=B64711.168971216816753 (code B ref 64711); Tue, 18 Jul 2023 20:30:02 +0000 Received: (at 64711) by debbugs.gnu.org; 18 Jul 2023 20:29:28 +0000 Received: from localhost ([127.0.0.1]:54421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLrK3-0004M8-I9 for submit@debbugs.gnu.org; Tue, 18 Jul 2023 16:29:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLrJs-0004Ln-Sx for 64711@debbugs.gnu.org; Tue, 18 Jul 2023 16:29:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLrJn-0000Ep-BU; Tue, 18 Jul 2023 16:29:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=gVPvKNxsd0PwWA5+tSPeczRRp8Q9GNve3x+HeVFS0Y0=; b=cTW+ZHH7QGSFtiyUKY4z PGw2ZEt4zXOefjgt04zFVbpTuYz0Q1NKnM4vmPbjfft+WNSMeL90PXftCsGyWW1B0nrZqTwiuRh51 yw9lCOfaxlhcLxQWJtvgEjJybi3a39vZdrHRbBZ8UVKFT+kqflvEZaWJHy8DTy64Qkq4Nes6AYFHI UK+oBJrvLpCb+14EBf6IJdYcZGBqHpkhNl3xba+hjIE6OzT8/J5lS8l50HIgCpBnZJTgKXoCfeNL0 IL0xF8pPO9Jji/rPIWBIvNLUNkW1T2/W3VnIW7Y+8MxMimGAbmCyJPbWF36kjVz20hpfoaWVgb1Eq PfD2bp3a5ys50w==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLrJm-0005Xc-Cp; Tue, 18 Jul 2023 16:29:11 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Tue, 18 Jul 2023 22:29:07 +0200 In-Reply-To: (Janneke Nieuwenhuizen's message of "Tue, 18 Jul 2023 16:38:12 +0200") Message-ID: <87cz0pge0c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -5.35 X-Migadu-Queue-Id: 130BB4ACE3 X-Migadu-Spam-Score: -5.35 X-Migadu-Scanner: mx0.migadu.com X-TUID: 9tkEf2zeMZrX Hey! Janneke Nieuwenhuizen skribis: > Also, most probably problematic tests in the guile test suite were fixed = on > guile master. As I understand, Josselin is working on this, so way may w= ant > to skip the patch for guile (or apply it anyway and revert it later). > > Because many patches are almost trivial and similar, you may want to give= some > specific comments to the non-trivial patches and possibly some general > comments for the trivial ones instead of a LGTM on every individual patch? So modulo the few comments I sent, I think this looks good. There=E2=80=99s a couple of things to check (which I haven=E2=80=99t do): =E2=80=A2 Make sure x86_64-linux derivations (for instance) are unchanged. That is, =E2=80=98./pre-inst-env guix build libreoffice -d=E2=80=99 sho= uld produce the same thing before and after this patch series, on x86_64-linux. (Pro tip: replace =E2=80=98-d=E2=80=99 with =E2=80=98-n=E2=80=99; if th= ere are substitutes, it means it hasn=E2=80=99t changed. :-)) =E2=80=A2 Make sure =E2=80=98guix build sed --target=3Di586-pc-gnu=E2=80= =99 still works. Probably the derivation should be unchanged, but maybe it=E2=80=99s OK = if it changes (sometimes avoiding a cross-rebuild would require extra boilerplate that we=E2=80=99d rather not have). =E2=80=A2 And well, =E2=80=98guix build sed -s i586-gnu=E2=80=99 should w= ork as well, but that=E2=80=99s the whole point of this series! Thanks a lot for all the work! Ludo=E2=80=99.