From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oGksC1Ve0mS9QgEASxT56A (envelope-from ) for ; Tue, 08 Aug 2023 17:25:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sFwLC1Ve0mTizAAAauVa8A (envelope-from ) for ; Tue, 08 Aug 2023 17:25:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B598F428CA for ; Tue, 8 Aug 2023 17:25:08 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ql1iev6P; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691508308; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1A/ZCB+8Pwk9lVmzDSjRCtrVgBx9VQjuTWjY8RHM9MM=; b=aLZtDk9xMt/VSM4DjJFzcATZLDgWATldr+Ju6DE/PmMaUof25zLZgCcc2AB1YpGHnZRdgL cbE9oKC2Wqrvw0Fg2iZ3t1Ti8I/ki8puY77TBrxxNDZGnIz9ue/M1KvO6cvpDh3K5XkH76 V/+vYnlZOKfHpyfJ5ujiQEAkcL5PTHhCNT7MxYSs0QEhVR33vYrpzcVfmnIZOPBkMGpmEf QmZplUGDr2sm3LzQw3fMFIRqYJl6wuftDKS7wC21+ULg1qwcuLmOrMNRyKX/3iqCUgf2gv 1zdUC8p6HB2WCsTII49wLlBohm/DjWXdjrjOxaNw4Ylr74Edo7725qgQ/HuAJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ql1iev6P; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691508308; a=rsa-sha256; cv=none; b=sP9R5CcfFai62+D4TUrp3w+wkbm+W0roWQmTtdDmPzYi8FNRKfqAg4zbNz1Ij39IvkTKFD chueiP1D60YQ3a0Wd5zcfWtSG2GZEV1/XZtxBCiff/Iy2Cmi/r9E7XqeJRED/wxBg16w1p dzgGMdODxaO7u1jkloAkFVGaAj9gBnggIlbeu4iEUEwAhioWNtxN14eZf8LimWn7manKYm 5c8BECwv9WfvzFhMJmVEIAGkhyvC4CgpHgmFdL0M3TD1WDH+C5fbsu465YJPrgdFQ4VOgl 95lyW+93hruO0ImmTfc51AeChInnYiD7ablBajYiyqW6C5yI791Y75puRqdPnw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTOZz-0006f7-Uq; Tue, 08 Aug 2023 11:25:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTOZy-0006eu-Is for guix-patches@gnu.org; Tue, 08 Aug 2023 11:25:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTOZy-0003Kr-9x for guix-patches@gnu.org; Tue, 08 Aug 2023 11:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTOZy-0006mZ-5M for guix-patches@gnu.org; Tue, 08 Aug 2023 11:25:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62202] [PATCH 0/21] Juliahub import script. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Aug 2023 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62202 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Nicolas Graves Cc: Simon Tournier , 62202@debbugs.gnu.org Received: via spool by 62202-submit@debbugs.gnu.org id=B62202.169150829126049 (code B ref 62202); Tue, 08 Aug 2023 15:25:02 +0000 Received: (at 62202) by debbugs.gnu.org; 8 Aug 2023 15:24:51 +0000 Received: from localhost ([127.0.0.1]:37499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTOZn-0006m4-0K for submit@debbugs.gnu.org; Tue, 08 Aug 2023 11:24:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTOZk-0006lr-2K for 62202@debbugs.gnu.org; Tue, 08 Aug 2023 11:24:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTOZd-0003DV-K8; Tue, 08 Aug 2023 11:24:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=1A/ZCB+8Pwk9lVmzDSjRCtrVgBx9VQjuTWjY8RHM9MM=; b=Ql1iev6P6QKI6Qhg37z9 UKdZp98aTeOwlQb4TqoqwbDVnU2QS1eMWA07ln/ww6dWPs3mG9m9EPvLdvUpcjKnLtnR1Wd1ZRb84 q9lC4g7vICREfUyaVqkgPHHah6NU7wM6f31D9LRXCWSuWv5GQ3LDHgKBn2xLNEeJPYsIZhoXwFHoN LBULM8ayv15qkUr2junfm+hDjrmCl6f6oxaXp8AlX2+3U7HDsrYV5cz6clC004cwfPeoboeqPyaOn 6vKGje1rgQKvs5LAcSnO1anmjMW60bYWwRrwGYHJnsmuD0f6oNhKXVXP06NAfDiu4ndRbXkcA8+KW qYROlzx31v9XfA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871qlq89kz.fsf@ngraves.fr> <87ile69geh.fsf@gnu.org> Date: Tue, 08 Aug 2023 17:24:38 +0200 In-Reply-To: <87ile69geh.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 09 Apr 2023 00:07:50 +0200") Message-ID: <87cyzxr1zd.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: B598F428CA X-Migadu-Scanner: mx1.migadu.com X-Spam-Score: -6.87 X-Migadu-Spam-Score: -6.87 X-TUID: HacL4a1ZVOcc Hello Nicolas & Simon! What should we do about this importer? Looks like useful code to me! Thanks, Ludo=E2=80=99. Ludovic Court=C3=A8s skribis: > Hi! > > Nicolas Graves skribis: > >> Took me quite more time than I would've liked, but I have a usable >> juliahub scheme import script! >> >> It seems there's still one edge case that isn't covered and revolves >> around when Julia packagers don't properly tag their git repos (I've >> only seen the case with SnoopPrecompile). There's the possibility to >> rely on tree commit hashes from the General repository (since this is a >> valid way to identify/store a git repo), but that needs some major >> changes in the way latest-repository-commit works. Otherwise, it needs >> to be done by hand. It might also not work for subpackages in >> directories that are up-to-date on juliahub but not yet on github, I >> haven't met this case yet. >> >> I'm sending a patch series in the coming minutes. >> >> It's detailed since I haven't swauased all commits, for readability, but >> I can squash it further if necessary. > > I=E2=80=99ll let Simon comment on the actual code since I=E2=80=99m not a= Julia person. > :-) > > Some more general comments: > > =E2=80=A2 Please make sure to document it in =E2=80=98doc/guix.texi=E2= =80=99 under =E2=80=9CInvoking > guix import=E2=80=9D, following the same template as the others there. > > =E2=80=A2 Please write =E2=80=98tests/juliahub.scm=E2=80=99. I recomme= nd the same strategy as > =E2=80=98tests/cpan.scm=E2=80=99, which is to mock the upstream HTTP = server. > > =E2=80=A2 Prefer (srfi srfi-41) over (ice-9 streams) (see rationale at > ). > > =E2=80=A2 Prefer (srfi srfi-71) over (srfi srfi-11) for multiple-value > bindings. > > Thanks, > Ludo=E2=80=99.