From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cBXCOtzS8mSpfAAAG6o9tA:P1 (envelope-from ) for ; Sat, 02 Sep 2023 08:14:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cBXCOtzS8mSpfAAAG6o9tA (envelope-from ) for ; Sat, 02 Sep 2023 08:14:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A537C54698 for ; Sat, 2 Sep 2023 08:14:52 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=A3saOWJe; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693635292; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=1YA7wqDBoFH67/cIkParVuOTYoQgAi3dpRPby/krTI4=; b=QPIvay+vLLdHqD/cILamWSwXvPRja76Y7CV0CZlvRe5EhUH9MKEMJUBYjxblkbijsqjzLQ YOVZyjqU1fbUvtYyEhhCtWK225Du30brO5iuBaME/X030EEHc3L7Yr2OozfqgWp4NGS/1A NENeQruAJUDNOaxC0Cer0y/AnxEZshoa9yykjkfDCeLtiKVfLB6t4uYFmLJvy2lK0CG8qz rGvF2hNADTEj6/7Ol11LWG9GAIIYVJIOW3Frv4UkBcOAQfBHW7vCs/cptYwNdlTVS0X5Je ia8TYNLFGdjm+NYme14YcrLpAp9XgZTJAJmtv1leoLt9Tx596PbYkSL7RaJwBw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693635292; a=rsa-sha256; cv=none; b=QU8GnRuvpAoEFSwVSDrW6GysRmzZQTELSbgL0oElZAvLFSgW+VhDZFoS91b0QDoiw3Nung sWqeZ5OUGEn4dZ0Ewtwwr+us5nsuLxAIvgB54WJV6G99GkkBNCR+9zBJzWrrS99rtUR3D/ mwGrSHKXk3UbPAKoZkXqvccnp+NlmqtT50Ao9J0ZPa4+wzrmKecvE30JRLcbjqZjeyFLC4 jFZlGVi0kdqhRdkzeBLU9WUVv81SIEiYFmS9QwVf0hokOc3ByKdHAHI5U/j5Egimp2r7Bj mjzojPkBbPf2NmAONn4gZKYxb4CdxlFFTvVdlq5NEtX+60m79QzzxmvHGNQ1dQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=A3saOWJe; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcJhj-0007tg-0W; Sat, 02 Sep 2023 02:01:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcJhh-0007tT-Pv for guix-patches@gnu.org; Sat, 02 Sep 2023 02:01:53 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcJhg-0002JY-He for guix-patches@gnu.org; Sat, 02 Sep 2023 02:01:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcJhq-0007Dj-3F for guix-patches@gnu.org; Sat, 02 Sep 2023 02:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50133] [PATCH 0/6] Add lxd package and service. Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Sep 2023 06:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50133 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Andrew Whatson Cc: 50133@debbugs.gnu.org, control@debbugs.gnu.org Received: via spool by 50133-submit@debbugs.gnu.org id=B50133.169363449727714 (code B ref 50133); Sat, 02 Sep 2023 06:02:02 +0000 Received: (at 50133) by debbugs.gnu.org; 2 Sep 2023 06:01:37 +0000 Received: from localhost ([127.0.0.1]:34941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcJhQ-0007Cu-KZ for submit@debbugs.gnu.org; Sat, 02 Sep 2023 02:01:36 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:59552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcJhO-0007Cf-TQ; Sat, 02 Sep 2023 02:01:35 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 81F571AAD0; Fri, 1 Sep 2023 23:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1693634476; bh=frHz7iJVb04xeB/ane0fXy75N/GL+Ntej+hjc3x374E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=A3saOWJe9wzP5xS+DDb1n4vOLUT3lgTaUJ/NDttqHZGFI1+rib32QdhDjnOvYTyi9 F86STGt4YgblIWIg1QB8SWQRpyfs1VJugYd1f+6p/D4VKotPyEttnO7TwxrN6fPuSE 3mW6WkRgAC3uCwrgNIZRl+yCi5EndilQE4ODd8pIP8M1/ltvwEnb0j03wADKSC84nJ TJXVys8s1DzAOnctI0zPN6jQg9yr9aHJOIH+8C6csBq8uY52gcjUxMnZ88WW3SW+S6 VZg07qTx2mcwPhR21Ptlk69xABi3JymZmCtwF4AFOKmW2vRIme7Z+T5O5PfNH4hUem bRZRAaWdyKpDQ== From: Vagrant Cascadian In-Reply-To: <87ee98akb7.fsf_-_@gnu.org> References: <20210820124524.117090-1-whatson@gmail.com> <20210820124524.117090-6-whatson@gmail.com> <87ee98akb7.fsf_-_@gnu.org> Date: Fri, 01 Sep 2023 23:01:13 -0700 Message-ID: <87cyz1nmfq.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: A537C54698 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -3.83 X-Spam-Score: -3.83 X-TUID: Hz+UVRv2k5Ee --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable retitle 50133 Add lxd service thanks On 2021-09-28, Ludovic Court=C3=A8s wrote: > The whole series LGTM and I=E2=80=99ve already applied patch 1=E2=80=935. Retitling as the only outstanding issue is the lxd service. > Some comments below about the service: > > Andrew Whatson skribis: > >> * gnu/services/virtualization.scm (lxd-configuration): New type. >> (%lxd-accounts, lxd-service-type): New variables. >> (%lxd-activation, lxd-shepherd-service): New procedures. >> * gnu/system/file-systems.scm (%elogind-file-systems): Add >> "/sys/fs/cgroup/systemd" file-system. > > [...] > >> +(define lxd-service-type >> + (service-type >> + (name 'lxd) >> + (extensions >> + (list (service-extension activation-service-type >> + %lxd-activation) >> + (service-extension shepherd-root-service-type >> + lxd-shepherd-service) >> + (service-extension account-service-type >> + (const %lxd-accounts)))) >> + (default-value (lxd-configuration)))) > > Please add a =E2=80=98description=E2=80=99 field. > >> index b9eda80958..7c3777298b 100644 >> --- a/gnu/system/file-systems.scm >> +++ b/gnu/system/file-systems.scm >> @@ -499,6 +499,17 @@ TARGET in the other system." >> (check? #f) >> (options "none,name=3Delogind") >> (create-mount-point? #t) >> + (dependencies (list (car %control-groups)))) >> + ;; The systemd cgroup needs to exist to run systemd inside lin= ux >> + ;; containers (eg. via LXD). This is *not* required for elogi= nd, but >> + ;; keeping it with the other systemd hacks seemed sensible, fo= r now. >> + (file-system >> + (device "cgroup") >> + (mount-point "/sys/fs/cgroup/systemd") >> + (type "cgroup") >> + (check? #f) >> + (options "none,name=3Dsystemd") >> + (create-mount-point? #t) >> (dependencies (list (car %control-groups))))) >> %control-groups)) > > Instead of adding it here, how about extending > =E2=80=98file-system-service-type=E2=80=99 instead, similar to what > =E2=80=98qemu-binfmt-service-type=E2=80=99 does? That way, the extra req= uirement would > be limited to LXD. > > Two other things, could you add: > > 1. documentation in the manual under =E2=80=9CVirtualization Services= =E2=80=9D, with a > commented config example? > > 2. (ideally) a system test to ensure that the basics of the service > are working? live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZPLPqQAKCRDcUY/If5cW qrD8APwNEcCl5h5xqSMZMMppDGzGXdB8GyTnngeeaJSaSx4SzAD/QQjvJGTXJtRI ZPovlsPzqLZfNCopCH3vkZEJ5tv3DQk= =LZAr -----END PGP SIGNATURE----- --=-=-=--