From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id aJ3EA6zGFWV3KQEA9RJhRA:P1 (envelope-from ) for ; Thu, 28 Sep 2023 20:32:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aJ3EA6zGFWV3KQEA9RJhRA (envelope-from ) for ; Thu, 28 Sep 2023 20:32:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0C1DD687 for ; Thu, 28 Sep 2023 20:32:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695925932; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Ov/IPxXkuZgB8u73Yjsj4KfXNh2tZaPAZlbtGV7ynhY=; b=EOMZ/Q3EX8IG5QeBh+IjzTT4iTvOvX50w286aIdAjWavm3zKg1Msug+iTRdYN7JU/zp2F6 MbJLHACnUmVHIKzgklStaCLaNFLODRxE7Bdd126UyDJq6uCWV2BE8JIGNtebaIIqHAx3Ke YmEZ/tpuuff78a8wRZZwgvSfVsBr2JKeqt7ka7yJPiEvYqz0XPAoa/4UHJG/xkv0dpcs49 D7Q2yy4N3pyFaQVZSo+UzHpJ5MW7/KiHw7raL15/KuMmqgWWEiJnu0oNHwoUOUOrL/mprd AgKQEERg1Vd4H4cqk774jH8qx5XhJg+IiyzWGG6bxNlVV3pxZsP07RskGWfBQQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695925932; a=rsa-sha256; cv=none; b=P0aHQBtwWkjMRIx7/10kme3p9KrWiAWg9U1w5QoOJ6EnGk08uJMiQGFxvtSKx9qSGh06jH tvKA0R7DxLDYOQcn4OLMCejI0YNbgJNosW8klsT/3okrkg1Lu3h0LY9Yuan6SrUXYyp0wk FU+C2w8sFrHElLTkYEgCYJ+enjwuaX3NhfWY+J+cO15xNj/iTtyhM9Ipm9Dk9AGujZiPWW 27lSe5XfN76j4GIezN2qqh/pKLtcj4kx7iYOMP8R37/kGqqdejMBaByincP/vku6iQljJq RmNMzLZXUlNpTUUzWCboggCy0fD9Bu8OM7WePjtU+QWDl2wxjFsuEonCLewpeg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlvnl-0007MF-C3; Thu, 28 Sep 2023 14:31:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlvnh-0007Ln-OE for guix-patches@gnu.org; Thu, 28 Sep 2023 14:31:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qlvng-0004JU-6g for guix-patches@gnu.org; Thu, 28 Sep 2023 14:31:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qlvnu-0006tj-8h for guix-patches@gnu.org; Thu, 28 Sep 2023 14:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65853] [PATCH] gnu: scilab: Fix and hardcode script inputs. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Sep 2023 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65853 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 65853@debbugs.gnu.org, Andreas Enge , Eric Bavier Received: via spool by 65853-submit@debbugs.gnu.org id=B65853.169592588626455 (code B ref 65853); Thu, 28 Sep 2023 18:32:02 +0000 Received: (at 65853) by debbugs.gnu.org; 28 Sep 2023 18:31:26 +0000 Received: from localhost ([127.0.0.1]:54484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlvnF-0006sY-S3 for submit@debbugs.gnu.org; Thu, 28 Sep 2023 14:31:26 -0400 Received: from 11.mo550.mail-out.ovh.net ([188.165.48.29]:52655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlvnA-0006sF-4A for 65853@debbugs.gnu.org; Thu, 28 Sep 2023 14:31:20 -0400 Received: from director10.ghost.mail-out.ovh.net (unknown [10.108.20.113]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 2608F275EE for <65853@debbugs.gnu.org>; Thu, 28 Sep 2023 18:31:00 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-z9cc4 (unknown [10.110.208.79]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id BE3951FE89; Thu, 28 Sep 2023 18:30:59 +0000 (UTC) Received: from ngraves.fr ([37.59.142.98]) by ghost-submission-6684bf9d7b-z9cc4 with ESMTPSA id fkwuAGPGFWW1XQIA1FwEXQ (envelope-from ); Thu, 28 Sep 2023 18:30:58 +0000 X-OVh-ClientIp: 81.67.140.142 In-Reply-To: References: <0852115dc8e706b80b05d57cfbfae64de79fdac5.1694362722.git.ngraves@ngraves.fr> Date: Thu, 28 Sep 2023 20:30:58 +0200 Message-ID: <87cyy2gnfh.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 14295551118034264624 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedrtddtgdelhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeevkeelueejtdehgfffkeelkefhhffftefgvdehkeeluefhheeuleejtdejhfdvgfenucfkphepuddvjedrtddrtddruddpkedurdeijedrudegtddrudegvddpfeejrdehledrudegvddrleeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeeiheekheefseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehhedtpdhmohguvgepshhmthhpohhuth X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches From: Nicolas Graves via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.74 X-Spam-Score: -6.74 X-Migadu-Queue-Id: A0C1DD687 X-TUID: LvYNo54BJaRt On 2023-09-28 19:36, Efraim Flashner wrote: > A couple of things I noticed: > > On Sun, Sep 10, 2023 at 06:18:42PM +0200, Nicolas Graves wrote: >> + coreutils > > This can be coreutils-minimal > Will change it. >> + (("grep") >> + #$(file-append (this-package-input "grep") "/bin/grep")) > > These can be (search-input-file #$inputs "/bin/grep") to make it easier > to swap out the packages for something else if people want. > Fine for me. >> + (("sed") > > I checked the script, it should be ((" sed ") since there are a couple > of instances of 'sed' in the script which aren't invocations of sed. Yes I indeed noticed it too, probably forgot to resubmit a patch but my local version works well. > >> + #$(file-append (this-package-input "sed") "/bin/sed")) >> + (("uname") >> + #$(file-append (this-package-input "coreutils") >> + "/bin/uname")) >> + (("dirname") >> + #$(file-append (this-package-input "coreutils") >> + "/bin/dirname")) >> + (("basename") >> + #$(file-append (this-package-input "coreutils") >> + "/bin/basename")))))))) > > Are there more binaries which should be substituted? I saw glxgears, > chcon, a couple instances of java, pwd, valgrind, docbook paths. And > then there's a couple of other scripts and binaries in the bin/ folder. > I think it'd be better to use wrap-script or wrap-program and then use > substitute* to strip the leading /usr/bin/ from the different calls to > the different binaries. I don't use more than that for a CLI usage. The thing is that we already build without the GUI (so without java). Maybe valgrind could be useful for debugging, docbook for documentation... I'll take a look in the coming weeks, but I can guarantee it works for me, so I propose we should process with this one, and add other patches on top when someone needs them. But we should be mindful that all possible paths / binaries are not reachable when the script is run (IIRC, they also depend on the OS and options). -- Best regards, Nicolas Graves