all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: 67229@debbugs.gnu.org
Cc: paren@disroot.org, ludo@gnu.org, me@tobias.gr,
	rekado@elephly.net, rg@raghavgururajan.name, jgart@dismail.de,
	othacehe@gnu.org, guix@cbaines.net,
	Sebastian Gibb <mail@sebastiangibb.de>
Subject: [bug#67229] [PATCH] gnu: Add r-gtsummary and dependencies
Date: Fri, 12 Jan 2024 09:51:18 +0100	[thread overview]
Message-ID: <87cyu7ylx5.fsf@gmail.com> (raw)
In-Reply-To: <9610e6bc1c5bd70ed3e66b491603462f98b87cdf.1700143657.git.mail@sebastiangibb.de>

Hi,

(Sorry for the late reply.)

On Thu, 16 Nov 2023 at 15:07, Sebastian Gibb via Guix-patches via <guix-patches@gnu.org> wrote:
> Change-Id: I8925668063ca53b91bec49788fbed3df5eb2c2fc
> ---
>  gnu/packages/cran.scm | 211 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 211 insertions(+)

Thanks for your contributions.  From a first look, they look good to me
but it would help if you could:

 1. Split all the additions to atomic commits – one package per commit:

        +(define-public r-reactr
        +(define-public r-reactable
        +(define-public r-juicyjuice
        +(define-public r-gt
        +(define-public r-gtsummary
        +(define-public r-bigd
        +(define-public r-broom-helpers

    Hence 7 commits; :-)

 2. Write compliant commit messages, as:

--8<---------------cut here---------------start------------->8---
gnu: Add r-reactr.

* gnu/packages/cran.scm (r-reactr): New variable.
--8<---------------cut here---------------end--------------->8---

Could you send v2 (reroll-count=2)? 

Cheers,
simon







  reply	other threads:[~2024-01-12 12:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 14:07 [bug#67229] [PATCH] gnu: Add r-gtsummary and dependencies Sebastian Gibb via Guix-patches via
2024-01-12  8:51 ` Simon Tournier [this message]
2024-01-30 16:16 ` Ricardo Wurmus
2024-12-03 16:28 ` bug#67229: " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyu7ylx5.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=67229@debbugs.gnu.org \
    --cc=guix@cbaines.net \
    --cc=jgart@dismail.de \
    --cc=ludo@gnu.org \
    --cc=mail@sebastiangibb.de \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    --cc=paren@disroot.org \
    --cc=rekado@elephly.net \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.