From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 8LfzNs1UwWVw3QAAe85BDQ:P1 (envelope-from ) for ; Mon, 05 Feb 2024 22:36:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8LfzNs1UwWVw3QAAe85BDQ (envelope-from ) for ; Mon, 05 Feb 2024 22:36:14 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=BtfFiHWc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707168973; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=btch/FiNpE9zJzhDKQe535sUCcTpnzdWmJ6YSaHSzb4=; b=CrN1YxJ1bA2W3l0gyWLEm9eaDyOtgjOMI63pRIMJOMtvOI+aihpfCG2F68cTALrvRl9dHI zWCW5VFexbz/qeRf0FWC7BxVqi7jRPaUTKp+fQ8T0jS5eyM3M9R2tSZ/bzTwYDWXRGEYii MPpP7gPA8/9qktUzWZ7ZTb7jm4NRESaYnmEq6+tej/ego3KGiI3RSMCFQV3fY+pQm92qc/ ZwyF8JpfmrSNDxwfOACH08WuiYe0/qTul1tRFmqMebEQoiqF+7XbFzrRQoBuLPjMOSk7uU k97GRHOcO+yypjBiCbp+nh+doHAexZ6fUMpVSxnhskE8MM8DpnYEocVdw48gcg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=BtfFiHWc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707168973; a=rsa-sha256; cv=none; b=mTHlRIoUF2CQ3Uap1xUhLRrGQfTHapHxoov09yRtP1/POOXCY6DK2vzs1fZB9gmQ6kqJtG 2dBWo2vc40KARxfdk9/sVLS8W1V9CR80W6Zfl1p8EftAgtCBgm1HgQ6FfswbGFCPXAp4E6 dComF1mkwjqcV3AXTEwYcwb1RV3BSHtaH/yaijl6cqFtdsA09bmv1G8ohGGHAOrlIODbvp NC7ejJ4OT2hz3J+UZFBOmUOMmaj0ISHh8DWzwZTYxQvOeVAu2ekB9+KQKpfXE9XOYHNji8 0u15f9iET4YuAgRcI7LbTlKriqDF0aWHp4o5ZL5vVNlrBV5t/a86c7X4TmTnWA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7F66A598DA for ; Mon, 5 Feb 2024 22:36:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rX6d4-00079O-MX; Mon, 05 Feb 2024 16:35:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rX6d3-00078p-7Z for guix-patches@gnu.org; Mon, 05 Feb 2024 16:35:49 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rX6d2-0000tZ-Vp for guix-patches@gnu.org; Mon, 05 Feb 2024 16:35:48 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rX6dF-0006Y2-N8 for guix-patches@gnu.org; Mon, 05 Feb 2024 16:36:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68564] [PATCH] build-system: fix the Chicken build system Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Feb 2024 21:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68564 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Daniel Ziltener Cc: 68564@debbugs.gnu.org Received: via spool by 68564-submit@debbugs.gnu.org id=B68564.170716895425156 (code B ref 68564); Mon, 05 Feb 2024 21:36:01 +0000 Received: (at 68564) by debbugs.gnu.org; 5 Feb 2024 21:35:54 +0000 Received: from localhost ([127.0.0.1]:52413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rX6d7-0006Xf-Rm for submit@debbugs.gnu.org; Mon, 05 Feb 2024 16:35:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rX6d6-0006XT-Cg for 68564@debbugs.gnu.org; Mon, 05 Feb 2024 16:35:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rX6cn-0000sN-LZ; Mon, 05 Feb 2024 16:35:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=btch/FiNpE9zJzhDKQe535sUCcTpnzdWmJ6YSaHSzb4=; b=BtfFiHWcPD0qJZiWEUug wnZ99D+nBo5nWeSqiwaVQDA75MKLUVzX0HizBVUEeDQrddSOqgQYzv4UZBwpYgFMyx3zYRSMgsDP2 Gt7JMBiGkzZ52PmUeqUMbJtKCIgJcB5p5fWJSoPxokfx8WHEk2uVxDnZMDUYKsCPBMyeDkCuOHX50 pApLTeh+sY6wsABkZmLdl4z32QTiLqjLR1ERRbvGgulZSWySVzvLiMdr/xfTAh1D0qHPNZY8NtJEv xZnVwtMDDMRyn8yk0z4i9P24J60JZQt9mX2jn5tX6mp2wUgsYRDizyYLzm0geeK3WZtla7kiRHQiQ HeIfNP8Q5ym5OA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <5f79ce0097f1092706b65abd99940d06@lyrion.ch> (Daniel Ziltener's message of "Thu, 18 Jan 2024 11:09:12 +0100") References: <5f79ce0097f1092706b65abd99940d06@lyrion.ch> Date: Mon, 05 Feb 2024 22:35:31 +0100 Message-ID: <87cytabnmk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.37 X-Migadu-Queue-Id: 7F66A598DA X-Spam-Score: -7.37 X-Migadu-Scanner: mx11.migadu.com X-TUID: PIXt8Skx4PKv Hi Daniel, Daniel Ziltener skribis: > --- > guix/build-system/chicken.scm | 68 +++++++++++++++++++---------- > guix/build/chicken-build-system.scm | 17 +++----- > 2 files changed, 50 insertions(+), 35 deletions(-) This change contains several seemingly unrelated changes, some cosmetic/stylistic and others that have a functional impact, but it=E2=80= =99s not clear to me what the fix is. Could you clarify what problem you=E2=80=99re trying to fix? It=E2=80=99s also important to separate unrelated changes to help reviewers= and to help our future selves should we need to bisect the Git history. > (define %chicken-build-system-modules > ;; Build-side modules imported and used by default. > - `((guix build chicken-build-system) > + `((zilti build chicken-build-system) Leftover change? > + (modules '((zilti build chicken-build-system) Ditto. > + #$(with-build-variables inputs outputs > + #~(chicken-build #:name #$name > + #:source #+source It=E2=80=99s best if we can avoid =E2=80=98with-build-variables=E2=80=99: = =E2=80=98%build-inputs=E2=80=99 and =E2=80=98%outputs=E2=80=99, which this form adds, are now considered deprec= ated. > (define* (setup-chicken-environment #:key inputs outputs #:allow-other-k= eys) > (setenv "CHICKEN_INSTALL_REPOSITORY" > - (string-concatenate > - ;; see TODO item about binary version above > - (append (list (assoc-ref outputs "out") "/var/lib/chicken/11/= ") > - (let ((oldenv (getenv "CHICKEN_INSTALL_REPOSITORY"))) > - (if oldenv > - (list ":" oldenv) > - '()))))) > + (string-append (assoc-ref outputs "out") "/var/lib/chicken/11/= ")) > + (setenv "CHICKEN_INSTALL_PREFIX" > + (string-append (assoc-ref outputs "out") "/bin/")) > + (setenv "CHICKEN_REPOSITORY_PATH" > + (string-append (getenv "CHICKEN_REPOSITORY_PATH") > + ":" (getenv "CHICKEN_INSTALL_REPOSITORY"))) > (setenv "CHICKEN_EGG_CACHE" (getcwd)) > #t) >=20=20 > @@ -104,10 +103,6 @@ (define* (check #:key egg-name tests? #:allow-other-= keys) > ;; there is no "-test-only" option, but we've already run install > ;; so this just runs tests. > ;; i think it's a fair assumption that phases won't be reordered. > - (setenv "CHICKEN_REPOSITORY_PATH" > - (string-append (getenv "CHICKEN_INSTALL_REPOSITORY") > - ":" > - (getenv "CHICKEN_REPOSITORY_PATH"))) Could you explain why this statement is moved from one phase to the other? Thanks, Ludo=E2=80=99.