From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 6I1aAlU5wWUX0gAA62LTzQ:P1 (envelope-from ) for ; Mon, 05 Feb 2024 20:39:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 6I1aAlU5wWUX0gAA62LTzQ (envelope-from ) for ; Mon, 05 Feb 2024 20:39:01 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VAWblA9W; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707161940; a=rsa-sha256; cv=none; b=QSUmwJBGMPK3HTiMuN6oCpma57zkxLwlGvmOU0H6LS68kMnvt8dF/jkTa28yn4wpl4QbSI +8ioKxBNTuTrkwU24ouBSe2QJRy3BnAPSu1Tvld9QonSjD3GSaWkvDHWyGW8/U4h82Gr4V DGgfLG3hOYipmLLqKYip7XoEF1vv3LNWBG6XjYz0wehYqDCl2OR1Mt9mq0YyUSU9rTxWtf tGjQ+IVAkCkIoBMo+CC1SX2D6hH+Xw1dW4Yjwxo2NDXge86fk53PrUdsgK9jabDFR5q9YN TtpZimI/cgADJvEzZhKRo7y4nU83eOMKk4yUnVXv5bEUkysE8CAXbinI3L8PEw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VAWblA9W; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707161940; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=hrkJgfOUJ77/hkG54l7cbPOX3+i6bzq70G4wNWspAlY=; b=E2Qlhoa1BBpbnvu+V2BqQ3AGCRVnaECfLImN38JI9wx0p6i7GzovH6PpjVjOCrrfnyv2EP xtmt6JYiEHZtgiGs6GQDCOyD2db4lz0wTKrSJnH0TM811OuHvbXL/tw80Qis6aYk38qKdW 0LVqsHN4gTWNPyV0cLxh0bE2YfSS2303MUsyDBUERmNeANxtvNbaQv54zZkAjfmAYYyUMt vJ8OGfYeyZ6hGzv6UsrnSC4pQmUVyzXu6oiZYN0lI/0y1hcIN1omPFxgZHHdgvyzfC/Koi 3h7qd4Lxbf9fdtfln0V7G15hU6BTH9vHqw/EFyxY52XWJ3b/NXbXbCpFSiBwQw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DF949FF3C for ; Mon, 5 Feb 2024 20:39:00 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rX4nt-0004TS-I4; Mon, 05 Feb 2024 14:38:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rX4np-0004TA-VT for guix-patches@gnu.org; Mon, 05 Feb 2024 14:38:50 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rX4np-00019r-Nl for guix-patches@gnu.org; Mon, 05 Feb 2024 14:38:49 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rX4o2-0003bb-2E for guix-patches@gnu.org; Mon, 05 Feb 2024 14:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68250] [PATCH v2] gnu: mpv: Fix pkgconfig file. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Feb 2024 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68250 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hilton Chain Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Zheng Junjie , Lars-Dominik Braun , Josselin Poiret , Andrew Tropin , jgart , Marius Bakke Received: via spool by 68250-submit@debbugs.gnu.org id=B68250.170716190013810 (code B ref 68250); Mon, 05 Feb 2024 19:39:02 +0000 Received: (at 68250) by debbugs.gnu.org; 5 Feb 2024 19:38:20 +0000 Received: from localhost ([127.0.0.1]:52341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rX4nL-0003af-Nq for submit@debbugs.gnu.org; Mon, 05 Feb 2024 14:38:20 -0500 Received: from mail-oa1-x2e.google.com ([2001:4860:4864:20::2e]:53253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rX4nI-0003aS-T0 for 68250@debbugs.gnu.org; Mon, 05 Feb 2024 14:38:18 -0500 Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-21920f89441so2136661fac.2 for <68250@debbugs.gnu.org>; Mon, 05 Feb 2024 11:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707161878; x=1707766678; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hrkJgfOUJ77/hkG54l7cbPOX3+i6bzq70G4wNWspAlY=; b=VAWblA9WPF8zgdkDSRdoqJArg+tgsKmEYk7gHsEznovozZNnzWxE+DTSqKAycLmFkj n25MN7KITnrctMJtp0G7rPvyFgDB1iIgnJ7UH1Y1fRfcTnrX39AF3x8bXl1Po084tNs/ XICGnF3zhgegqmbi47hDpCwGu3apghyRhm/XamCp09k1Q8vdqqILZ/PrPC+PF3FGrnrY Kwdjrx7QaC5VWxmvvp41hjtG6/Ajb6K+LUtFx196nup4MPpz2dJHZloYL1lkiuApxMdl 4wgeaDKMj7LQt4oKoH1VtZdYIqAvG6B/uFlauXmej7sN/OZnbJYuqO94o8wlKQ6qKjcj 6U6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707161878; x=1707766678; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hrkJgfOUJ77/hkG54l7cbPOX3+i6bzq70G4wNWspAlY=; b=CuvGTtIYdr2O0yOnWYoe+ZkJWkDtem+AroPaRUB+oRW+R7LM4ur1byIsBcJHptvhQ0 7HynjJihsmx0vx7AgZWqhWIG+/HhFhRj9yP64lHetfzi3AevoRLuvZMLxosq9Csiiwql +7EbOtJXGts8Ni3rtaa+0LelUSPPamL32xA6eObeJwKn7DF7hqZs86xDE6/IogWOFWsA /YB80Vbe/Qf4dY620AiRkpjRLW3YvkbDMVrcrrasROPkKD/R3huuKVsQfZxu2aNcUXgY i7t0gGzIBkQU+/sl3y+WHh7K5QKJL7yPCM7kqUBnhbCaNRfwj3XdFCaCxKl2vvnHPM4g 5pTQ== X-Gm-Message-State: AOJu0YznWTpJcHwBs6KmZXTZkNlVO/OJ5bgNkjmNfKrTgjU1B6mw8n4i wiFS5kOZWlMR9Q84bqp+YQ9UcFXBX309zYG3l0y+KTK5EjOWTowd X-Google-Smtp-Source: AGHT+IFewAucDYB+6rKqPrkyRGx3DJ4hy2r+0TJLdp8LITld4a3iJpF/6yB+mZjjRq+Mo5w1vhbdWQ== X-Received: by 2002:a05:6871:6a5:b0:214:d3ae:d47c with SMTP id l37-20020a05687106a500b00214d3aed47cmr877193oao.0.1707161878446; Mon, 05 Feb 2024 11:37:58 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXe7eidw1XUa9XCgp9VIK+kFSYxwn2mOwKdiAZwT5Te3JG1i4571SuIeyS1NeVDWSqBqiZfKs81jlmfLPYvnfIHwlL8qyhvz64wEmbf1tzytlnGU8ORMKHHha3coqsNYshb2k126z/ZLbXOKXUXCkjfuqyRaXE83MGJ8Ngx1D/S4/p1UZ9uCrPo+WrrZc7PiGPKxeJzcGTGU5tDbFJFHnmEOLmgle/miVdesstTD2Hwf4BR3ZvE44T1vFserdfOQra11cRA0eIG Received: from hurd (dsl-10-130-152.b2b2c.ca. [72.10.130.152]) by smtp.gmail.com with ESMTPSA id d18-20020a05622a15d200b0042992b06012sm235160qty.2.2024.02.05.11.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 11:37:57 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <87o7d04w1k.wl-hako@ultrarare.space> (Hilton Chain's message of "Thu, 01 Feb 2024 13:01:59 +0800") References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> <8734uukrgq.fsf_-_@gmail.com> <87o7d04w1k.wl-hako@ultrarare.space> Date: Mon, 05 Feb 2024 14:37:56 -0500 Message-ID: <87cyta66sr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -5.48 X-Migadu-Queue-Id: DF949FF3C X-Migadu-Spam-Score: -5.48 X-TUID: YZeZhPoxRWYc Hi Hilton, [...] >> I've just seen this, after pushing a hot fix as >> f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed >> libraries in Requires.private. >> >> I suppose that someone wanting to build something statically from mpv >> would benefit from having the original mpv.pc file without >> modifications. >> >> Perhaps we can try it out for a bit, and if the propagation causes >> problems, we can fall-back to this change here? > > > Then we should follow the approach in v1 to add libmpv as a separate package. > I'll send v3 later. Actually I don't think we need to split out a library for mpv here; there are two things we can do in the short term: 1. Build MPV strictly as a shared library (-Dbuild=shared) or something in Meson. Then Meson doesn't output all these Requires.private dependencies, which are only useful for static linking, and which pkg-config confusingly uses for its --exists check. 2. On core-updates, I've been experimenting with replacing pkg-config with pkgconf, which seems to be designed better for avoiding the above pkg-config's pitfall. Currently stuck on a hard to understand cycle. -- Thanks, Maxim