From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id sH89GllH6mVCLQEAe85BDQ:P1 (envelope-from ) for ; Fri, 08 Mar 2024 00:01:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id sH89GllH6mVCLQEAe85BDQ (envelope-from ) for ; Fri, 08 Mar 2024 00:01:45 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fWiMW59J; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709852505; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=2+BYuN+OZzGajmkk/zpXvbjR8k4bxBJbk4/46XNUVjU=; b=EOQlutdfQ0Gweay3NccXzpR+E3eSX2MrmvOaBOzD+naueTy/CsIwKuOsrnE0IRfN7Xgik4 7bXV6rB106ufD4lwUTuJzMiUz/dbJxs0zf0TFPL+W5tReG3cOl6vC//lTJ+mdpLjV4o0yY YH9QpCmqpSr7bfcy9WQCqigiRnLkaegHyVuel6b6m0YzM5165wCnAJxFbckqCpoltQm+k/ Y6s6Pf47zklwVY6s0owhcL5d8WNwnJoGQctJAo1ZrNlAEeXt08CT39RvJIKN++CX/JLWld 2bMZRaUvU6wAervxXwnjNLweBAUhJgpgBxY9dFG9J3d/jHKKW7F4RfMCULgIWw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709852505; a=rsa-sha256; cv=none; b=ZpjWjosGcx2HY/mE9UgmkDqXloylXdRiJ7+D2pXuTO/EkbZapqQmZMBRK4ACD7ZSRTZtUd dT72Ip+ObdQ9U621CuUNyYm8kk9Nm9QyS6+8ktmPOIqXpULzhTJv/mqU13yisUvNOUgQQS jPtvZ26KU91EYDLLa8rQ48Ui4GB0kkJLYa4ZWRrbHmvfye7yfT/stzDg8XaGvt+5VbUjhA 4yEwr1ozLFiU2K41w01oHNhjWTpL9M5M8STSAvsFbwofVUfsL6hbEOqUYTcWKU2UXQzgVV 50BKQCG5JY+DXfpTFGqmgZ1qJrMd6jcdCEbucokQduMXZZTY+r3DxUhU3nWIbQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fWiMW59J; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 327BA75E8F for ; Fri, 8 Mar 2024 00:01:45 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1riMk3-0005gM-07; Thu, 07 Mar 2024 18:01:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1riMjz-0005fq-3l for guix-patches@gnu.org; Thu, 07 Mar 2024 18:01:32 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1riMjy-00025k-LN for guix-patches@gnu.org; Thu, 07 Mar 2024 18:01:30 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1riMkU-0003Vg-90 for guix-patches@gnu.org; Thu, 07 Mar 2024 18:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69376] [PATCH go-team] build-system/go: Allow providing additional test flags. References: <87a5noaot3.fsf@troyfigiel.com> In-Reply-To: <87a5noaot3.fsf@troyfigiel.com> Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Mar 2024 23:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69376 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69376@debbugs.gnu.org Received: via spool by 69376-submit@debbugs.gnu.org id=B69376.170985249113454 (code B ref 69376); Thu, 07 Mar 2024 23:02:02 +0000 Received: (at 69376) by debbugs.gnu.org; 7 Mar 2024 23:01:31 +0000 Received: from localhost ([127.0.0.1]:55322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riMjz-0003Uw-EX for submit@debbugs.gnu.org; Thu, 07 Mar 2024 18:01:31 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:46588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riMjw-0003Ug-R0 for 69376@debbugs.gnu.org; Thu, 07 Mar 2024 18:01:30 -0500 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-412f1ccf8d8so13724905e9.1 for <69376@debbugs.gnu.org>; Thu, 07 Mar 2024 15:00:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709852391; x=1710457191; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=2+BYuN+OZzGajmkk/zpXvbjR8k4bxBJbk4/46XNUVjU=; b=fWiMW59JuU3rfhV4J1FHe8QfW3eV8EyxuOJjgysCfuflp+LeUJQlHAHjw4wKXURGw+ vDNA91X84xwWos6r08Bh1lnLQjqHTzWzsmLq3HmUmz1Oq6sh7k8DUobcsMjWAIC8+e5d RjJoub5vOHmrhVrbTcwGMW58JTLuv1oXUXrc4oRccThBnkIEYDx2JVo8m/C8Fy8T8c4V c5wJ+YYGZ7z9k+qJsdbUyreCjgZdGYB7E7nisOb3vBGIYqI31bG8QPs7Cc6WjkxLhteO yhogY3EgwzPGK6rCCQ+IcGHqiId3XmBDSPPsiDY3pdyxCkH7aUb6jJAVa3WihZ6Z4LZD xPGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709852391; x=1710457191; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2+BYuN+OZzGajmkk/zpXvbjR8k4bxBJbk4/46XNUVjU=; b=sbM3pxCK/DsLcur6z6bFWR3fV5GcQP/k1mQFvKIMLlKa628T5sfwn7Y0vB4RoVFU+E 1Ix62yOJufbVgUi+Rw3mIaeCBoE5FqFnItvhbrrfcUtNYquLuC37yfifXXcNH5B2Gxej IITruhIqgpPLAEjjt65HYrZmPKhT+YYkhioG2/dADYmDbG/+zqfwfCLMAEndw1xoy/uT yZWsqg6+fOLZtADSjpP/aDCPkCyPZH2rNKsvceyBnSxMXta90E4fgGm1vn90ctO+92tt nRuGIi4o94O5TO/amAMXpuDvCDGbq0352F+50D2jTQSNFKuv/XGDGSwTbRivgM22hUHD sizw== X-Gm-Message-State: AOJu0Yy0J6r2QkL1nK8FjV/498y/BsOIBU/ufBmNtR6PPCwuLK9x9bvs yBpKourL9pEEJGEdQsa5ec+O2ECq35T72lfDXDr/Gtdp3z47DowRe0bo3nq5ivzMJQ== X-Google-Smtp-Source: AGHT+IEGQ3ZL+hodWZ0BTIJ4OrSsy52jr2V9SOcmuOIeUVSEqzjTjsWFtm0qpZ6Onzit0jmUE7Y2DQ== X-Received: by 2002:a05:600c:3491:b0:413:1786:e257 with SMTP id a17-20020a05600c349100b004131786e257mr210227wmq.37.1709852391106; Thu, 07 Mar 2024 14:59:51 -0800 (PST) Received: from guxtil (cpc100856-bagu15-2-0-cust368.1-3.cable.virginm.net. [82.25.93.113]) by smtp.gmail.com with ESMTPSA id p19-20020a05600c419300b0041294d015fbsm3870503wmh.40.2024.03.07.14.59.50 for <69376@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 14:59:50 -0800 (PST) From: Sharlatan Hellseher Date: Thu, 07 Mar 2024 22:59:38 +0000 Message-ID: <87cys54pid.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.77 X-Spam-Score: -6.77 X-Migadu-Queue-Id: 327BA75E8F X-Migadu-Scanner: mx11.migadu.com X-TUID: nkMOhnouzdnU --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Troy, Thank you for the work! The patch looks reasonable. Does it allow us to run all available tests as we discussed in ? One nitpick about this section: =2D-8<---------------cut here---------------start------------->8--- +;; go test builds a test binary (or multiple binaries), vets the code and = then +;; runs the test binary. Build, test and test binary flags can be provided= as +;; test-flags. See "go help test" and "go help testflag" for more details. =2D-8<---------------cut here---------------end--------------->8--- It is a good material for documentation section, how about to move it from this comment and compile a proper documentation note describing #:test-flags for go-build-system? Something like this: =2D-8<---------------cut here---------------start------------->8--- #:test-flags is added. The default is '(). These flags are passed as arguments to the test command. Note that flags for verbose output is always enabled on supported backends. =2D-8<---------------cut here---------------end--------------->8--- Sourced from WDYT? =2D- Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmXqRtoACgkQdtcnv/Ys 0rXTag/+Ombeg5CKHNO2q3hukk33hlQrXCg/tzBGhKgfKxfS0j+OGzk3Tyn6ky+A X9q0uooSb/i0rhsdYJp84C098KhI+Vpu+MjG8/RttHNLtQmbYRqZ8aJIv/XeGzHs om4gkcL+wC114vSIf2Me30S2ygsOjUmuZv+0gisnc2HYjkvBWiNeo9RT5C+gYbf5 VMlStAP1beCeAqkHhj4kQXD7i08bOh0RpDmk+LMvrdxOp4KL4f6VTYlPKHXIm6IY BD1UnrEs3eBdnsx02szWTfqzNTSwRdchSYZQgZx6A0TJdI3KJvetstRNyC0n3giO unkL+HHPx11a4D2oOqUM87dI2IKiG/uAVDw21JggyzX733qj3KaQGc8DrCP/npk2 0Tt19bLGiIWgdkm94XZ9N1GHmjPJ2YB9Rdk+AHP36uR/Ln0HNKX11/HGNQUeHXha fabPy0rvrul2XtSLY73YWq4iJGpPGlGbTPFx4PFOrpq+/TxyyZgoC38Plu0vOyrj bI+a6AOMa39TJO6/Az1VtQzuxmLvSp76SwN4qeNOUBzQWQMb8npTVkBgde3ZIhav ruOyxkJb9q3tIXuIpo5izqO+qlY9prgE+WFCNIEdu0MzI9hhT3OugoL+9ZeeGD0n 3/xbgh5U43p2ei0VvlKhvL8t4JvXq8XEJwgfG+zG8ckIwGA3Spc= =F9R7 -----END PGP SIGNATURE----- --=-=-=--