all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 71640@debbugs.gnu.org
Subject: [bug#71640] yt-dlp: Update to 2024-05-27
Date: Sun, 23 Jun 2024 21:58:13 -0400	[thread overview]
Message-ID: <87cyo79k5m.fsf_-_@gmail.com> (raw)
In-Reply-To: <79fa17151ff834161b71e2dbffe853ddff29a66d.1718763195.git.leo@famulari.name> (Leo Famulari's message of "Tue, 18 Jun 2024 22:13:15 -0400")

Hi,

Leo Famulari <leo@famulari.name> writes:

> * gnu/packages/video.scm (yt-dlp): Update to 2024.05.27.
> [build-system]: Use PYPROJECT-BUILD-SYSTEM.
> [arguments]: Remove the custom build phase 'fix-the-data-directories', because
> There is no longer a setup.py file to be amended.
> [inputs]: Add PYTHON-REQUESTS-NEXT and PYTHON-URLLIB3-NEXT.
> [native-inputs]: Add PYTHON-HATCHLING.
>
> Change-Id: I0c9e609817071346ca85d1f0966cf8994b2da2c5
> ---
>  gnu/packages/video.scm | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 76e4a8a02f..e3c20693fc 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -3137,7 +3137,7 @@ (define-public youtube-dl
>  (define-public yt-dlp
>    (package
>      (name "yt-dlp")
> -    (version "2023.10.13")
> +    (version "2024.05.27")
>      (source
>       (origin
>         (method git-fetch)
> @@ -3146,8 +3146,8 @@ (define-public yt-dlp
>               (commit version)))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32 "1cy8cpqwq6yfsbrnln3qqp9lsjckn20m6w7b890ha7jahyir5m1n"))))
> -    (build-system python-build-system)
> +        (base32 "13j6vg0kxfw3hppq7gzbz2d72g415071gh5arkwzj902rh0c7777"))))
> +    (build-system pyproject-build-system)
>      (arguments
>       `(#:tests? ,(not (%current-target-system))
>         #:phases
> @@ -3176,14 +3176,6 @@ (define-public yt-dlp
>                         "PYTHON=python"
>                         "yt-dlp"
>                         "completions"))))
> -         (add-before 'install 'fix-the-data-directories
> -           (lambda* (#:key outputs #:allow-other-keys)
> -             (let ((prefix (assoc-ref outputs "out")))
> -               (substitute* "setup.py"
> -                 (("'etc/")
> -                  (string-append "'" prefix "/etc/"))
> -                 (("'share/")
> -                  (string-append "'" prefix "/share/"))))))
>           (replace 'check
>             (lambda* (#:key tests? #:allow-other-keys)
>               (when tests?
> @@ -3192,6 +3184,8 @@ (define-public yt-dlp
>                    python-certifi
>                    python-mutagen
>                    python-pycryptodomex
> +                  python-requests-next ; TODO Remove this special package
> +                  python-urllib3-next  ; TODO Remove this one too

That's OK only because that's an application and these inputs are not
propagated.  I'm a bit worried the '-next' variants may be used by
packagers elsewhere, but I guess this means we should give the
python-team branch a spin.

Also, I see you haven't used inheritance anywhere; I guess that's to
make the transition to the latest package as painful as possible
(simply deleting the old definitions).

-- 
Thanks,
Maxim




  reply	other threads:[~2024-06-24  2:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19  1:45 [bug#71640] yt-dlp: Update to 2024-05-27 Leo Famulari
2024-06-19  2:13 ` [bug#71640] [PATCH 1/6] gnu: yt-dlp: Don't inherit from youtube-dl Leo Famulari
2024-06-19  2:13   ` [bug#71640] [PATCH 2/6] gnu: Add python-requests 2.31.0 Leo Famulari
2024-06-19  2:13   ` [bug#71640] [PATCH 3/6] gnu: Add python-urllib3 1.26.17 Leo Famulari
2024-06-19  2:13   ` [bug#71640] [PATCH 4/6] gnu: python-pytest-sanic: Further relax the websockets version requirements Leo Famulari
2024-06-19  2:13   ` [bug#71640] [PATCH 5/6] gnu: python-websockets: Update to 12.0 Leo Famulari
2024-06-24  2:00     ` [bug#71640] yt-dlp: Update to 2024-05-27 Maxim Cournoyer
2024-06-27 17:07       ` Leo Famulari
2024-06-19  2:13   ` [bug#71640] [PATCH 6/6] gnu: yt-dlp: Update to 2024.05.27 Leo Famulari
2024-06-24  1:58     ` Maxim Cournoyer [this message]
2024-06-27 17:05       ` [bug#71640] yt-dlp: Update to 2024-05-27 Leo Famulari
2024-06-29  0:27         ` Maxim Cournoyer
2024-07-04  1:48           ` bug#71640: " Leo Famulari
2024-06-24  2:03   ` [bug#71640] " Maxim Cournoyer
2024-07-01 12:19 ` [bug#71640] Deprecation Andreas Enge
2024-07-04  0:36   ` Leo Famulari
2024-07-04  0:49     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyo79k5m.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=71640@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.