From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id SPJ2CDSKm2ZPFAAAqHPOHw:P1 (envelope-from ) for ; Sat, 20 Jul 2024 09:58:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id SPJ2CDSKm2ZPFAAAqHPOHw (envelope-from ) for ; Sat, 20 Jul 2024 11:58:12 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721469491; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=QKPZW5i+R8sr+g1+RuUPUBUzQCopMjOo1lMInKM0tx4=; b=Z3wLXFSDiWK9Wl0euuw4rwvrHsbZ7o60J6InlmQHl0qoks+Sf+3ofhiJGX8QUm/q1y6QCA 03/RVjI5t5TykLacaGffu8qHks469lT/iNwbIOM7RF4qEK38pQRa+Ebx5V8o8JZJqw5q/8 XHtWp4HPzxoI6JHvyBnSnYDOl5sg4O/Xz07YDEVTKPTsq+inV/1naVpftpQvu8E8CGmEZ+ 5sG6PMnPb4MwTBmFe6oUQMnFna/fpSzw6nxCFA5Fwy2m+pqKbLfAApObWtIGK1F2rXfSUT fYGLBUAoZZjQ6R1M7I0DWRfcgZjTTJekJj8Il1k8fVT5DQX8TlUc2YFuU49Hiw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721469491; a=rsa-sha256; cv=none; b=MGQodXIDJCKowHJUOuNEnf+Jt4PC9lMuAr3rQ16CrNo/GM80kvrWc6ZmpOgdMWE/Ub5oKR fyh7dUwgcaSnj9jH64cqSXegrtJCawUZfW007AcGmHHwTqeMpjopu286o0brKA5SeAAyVM NnSpDE/Z6SDTc5PIZvD8s2ojkdiV0eoeAid+4VfPSXjfsa3Ni+NT4M1K3Xps+B4MvAxi3+ o7vjeA6Wv61gCbFs+G1+liJuWPH3x/7P2Z3yA0dKVViSUuxRnQOf0wQFVL9xG9EoZ5av/Y VwLb2Y2qLS0ss4kh5UvqDEtdKM8AEP6T706rdqmSpxElY3q0WcPr1Y7cTb+mlA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DBC2073BA7 for ; Sat, 20 Jul 2024 11:58:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sV6qp-0004V7-Gn; Sat, 20 Jul 2024 05:58:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sV6qo-0004Ui-C2 for guix-patches@gnu.org; Sat, 20 Jul 2024 05:58:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sV6qo-0004RX-4B for guix-patches@gnu.org; Sat, 20 Jul 2024 05:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sV6qo-0008TP-7S for guix-patches@gnu.org; Sat, 20 Jul 2024 05:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72106] [PATCH v2 2/5] gnu: klee: Enable the test suite. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Jul 2024 09:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72106 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: soeren@soeren-tempel.net Cc: 72106@debbugs.gnu.org, liliana.prikler@gmail.com Received: via spool by 72106-submit@debbugs.gnu.org id=B72106.172146942632482 (code B ref 72106); Sat, 20 Jul 2024 09:58:02 +0000 Received: (at 72106) by debbugs.gnu.org; 20 Jul 2024 09:57:06 +0000 Received: from localhost ([127.0.0.1]:51805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV6pu-0008Rq-9l for submit@debbugs.gnu.org; Sat, 20 Jul 2024 05:57:06 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:52812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV6ps-0008RK-7I for 72106@debbugs.gnu.org; Sat, 20 Jul 2024 05:57:04 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 9D70DAAE; Sat, 20 Jul 2024 11:56:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jw6haIuG87OL; Sat, 20 Jul 2024 11:56:58 +0200 (CEST) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 27F9B865; Sat, 20 Jul 2024 11:56:58 +0200 (CEST) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (soeren@soeren-tempel.net's message of "Sun, 14 Jul 2024 20:25:25 +0200") References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> Date: Sat, 20 Jul 2024 11:56:57 +0200 Message-ID: <87cyn8qtcm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -6.91 X-Migadu-Queue-Id: DBC2073BA7 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -6.91 X-TUID: dFM2OWV0N/Mx Hello S=C3=B6ren, soeren@soeren-tempel.net skribis: > (,(string-append lib "/klee/runtime/")))= ))))) > #:configure-flags > - #~(list (string-append "-DLLVMCC=3D" > + #~(list "-DENABLE_UNIT_TESTS=3DON" > + "-DENABLE_SYSTEM_TESTS=3DON" > + (string-append "-DGTEST_SRC_DIR=3D" > + (assoc-ref %build-inputs "googletest")) > + (string-append "-DGTEST_INCLUDE_DIR=3D" > + (assoc-ref %build-inputs "googletest") "/goo= gletest/include") I would replace (assoc-ref =E2=80=A6) by: #+(package-source googletest) > - (inputs (list bash-minimal klee-uclibc gperftools sqlite z3 python py= thon-tabulate)) > + (inputs > + `(("bash-minimal" ,bash-minimal) > + ("klee-uclibc" ,klee-uclibc) > + ("gperftools" ,gperftools) > + ("sqlite" ,sqlite) > + ("z3" ,z3) > + ("python", python) > + ("python-tabulate" ,python-tabulate) > + ("googletest" ,(package-source googletest)))) =E2=80=A6 and leave =E2=80=98googletest=E2=80=99 out of =E2=80=98inputs=E2= =80=99 entirely, keeping the concise input list without labels. (I think we shouldn=E2=80=99t reintroduce input labels; the goal has always been to remove them.) WDYT? Besides, to answer Liliana, Googletest is often used as a =E2=80=9Csource library=E2=80=9D like you=E2=80=99re doing here; there are quite a few othe= r packages that do that in Guix already, as you explained. That=E2=80=99s OK. Thanks, Ludo=E2=80=99.