From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55716) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqAUC-0001X6-0r for guix-patches@gnu.org; Sat, 11 Jan 2020 01:43:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqAUA-0002Ui-AA for guix-patches@gnu.org; Sat, 11 Jan 2020 01:43:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49297) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iqAUA-0002Ti-4L for guix-patches@gnu.org; Sat, 11 Jan 2020 01:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iqAUA-0001q9-1j for guix-patches@gnu.org; Sat, 11 Jan 2020 01:43:02 -0500 Subject: [bug#38865] [PATCH] add package definition for liquid-dsp-1.3.2 Resent-Message-ID: Message-ID: <87c412487b95a94fcbb7b9cbc133ddb1bd9b7819.camel@librehacker.com> From: Christopher Howard Date: Fri, 10 Jan 2020 21:42:54 -0900 In-Reply-To: <87tv52n4ae.fsf@gnu.org> References: <937849de433222cab5f2da618529ce3aad559546.camel@librehacker.com> <87d0bss243.fsf@gnu.org> <87tv52n4ae.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-QSXTB1IAP1GW2TW3vCbL" MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Brett Gilio , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: evan.straw99@gmail.com, 38865@debbugs.gnu.org --=-QSXTB1IAP1GW2TW3vCbL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit I went ahead and attached the updated patch as originally requested, in case it is needed. I copied in the description the other uploader had used since that seemed much better. One difference between my definition and the other one, is that I include fftw and fftwf as package inputs. fftw is an optional dependency of liquid-dsp, which I think does not change the API of liquid-dsp, but does affects the backend performance. As far as sdr.scm vs. ham-radio.scm: I am a licensed ham radio operator (US General Class), but nevertheless SDR and DSP are really not exclusive to ham radio. Liquid DSP, e.g., could be used in a lot of non-licensed or commercial-licensed applications (referring to the frequency license). -- Christopher Howard p: +1 (907) 374-0257 w: https://librehacker.com social: https://gnusocial.club/librehacker gpg: ADDEAADE5D607C8D (keys.gnupg.net) On Fri, 2020-01-10 at 19:57 -0600, Brett Gilio wrote: > Ludovic Courtès writes: > > > Hi, > > > > Christopher Howard skribis: > > > > > Patch is attached for a new package definition. It passed all > > > guix lint > > > checks, except that I received an error from guix lint that it > > > could > > > not find the CVE json URL. Package builds and passes all tests on > > > x86- > > > 64. > > > > Oh, the CVE error is weird; could you paste it? > > > > > From 3c8ccf400dbbf23191b958dfdcef986d1927719c Mon Sep 17 00:00:00 > > > 2001 > > > From: Christopher Howard > > > Date: Wed, 1 Jan 2020 19:58:25 -0900 > > > Subject: [PATCH] Adds new package liquid-dsp > > > > > > --- > > > gnu/packages/liquid-dsp.scm | 53 > > > +++++++++++++++++++++++++++++++++++++ > > > > Could you provide a commit log? (See > > < > > https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html> > > ;.) > > > > Overall the patch LGTM; minor comments: > > > > > --- /dev/null > > > +++ b/gnu/packages/liquid-dsp.scm > > > > Packages are usually grouped together in a file that reflect the > > category they belong to. Would it make sense to call this file > > ‘sdr.scm’, and it would eventually include other packages related > > to > > software-defined ratio, or perhaps dsp.scm? > > > > > +(define-public liquid-dsp > > > + (package > > > + (name "liquid-dsp") > > > + (version "1.3.2") > > > + (source > > > + (origin (method git-fetch) > > > + (uri (git-reference > > > + (url (string-append " > > > https://github.com/jgaeddert/liquid-dsp.git")) > > > > No need for ‘string-append’ here. :-) > > > > > + (synopsis "Signal processing library for software-defined > > > radios written in C") > > > > I’d dropped “written in C” from the synopsis. > > > > > + (description > > > + "Liquid DSP provides a set of extensible DSP modules that > > > do not > > ^ > > Please write: “@dfn{digital signal processing} (DSP) modules”, for > > clarity. > > > > > +rely on external dependencies or cumbersome frameworks") > > > > Please add a period at the end. Bonus point if you can expound a > > bit. > > > > Could you send an updated patch? > > > > Thank you! > > > > Ludo’. > > > > > > > > > > There is also a liquid-dsp patch in #38842 by Evan Straw (cc). > --=-QSXTB1IAP1GW2TW3vCbL Content-Disposition: attachment; filename="0001-gnu-Add-liquid-dsp.patch" Content-Type: text/x-patch; name="0001-gnu-Add-liquid-dsp.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAwMDY0YzYxZTc4ODRjNmY3ZDYzNTZkZmEyMmIwNDI3OWJjNDYwYjJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RvcGhlciBIb3dhcmQgPGNocmlzdG9waGVyQGxpYnJl aGFja2VyLmNvbT4KRGF0ZTogRnJpLCAxMCBKYW4gMjAyMCAyMToxOToyNCAtMDkwMApTdWJqZWN0 OiBbUEFUQ0hdIGdudTogQWRkIGxpcXVpZC1kc3AuCgoqIGdudS9wYWNrYWdlcy9zZHIuc2NtIChs aXF1aWQtZHNwKTogTmV3IHZhcmlhYmxlCi0tLQogZ251L3BhY2thZ2VzL3Nkci5zY20gfCA1OCAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5n ZWQsIDU4IGluc2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCBnbnUvcGFja2FnZXMvc2Ry LnNjbQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9zZHIuc2NtIGIvZ251L3BhY2thZ2VzL3Nk ci5zY20KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMC4uZjZjOTA1MDUwMwot LS0gL2Rldi9udWxsCisrKyBiL2dudS9wYWNrYWdlcy9zZHIuc2NtCkBAIC0wLDAgKzEsNTggQEAK Kzs7OyBHTlUgR3VpeCAtLS0gRnVuY3Rpb25hbCBwYWNrYWdlIG1hbmFnZW1lbnQgZm9yIEdOVQor Ozs7IENvcHlyaWdodCDCqSAyMDE5IENocmlzdG9waGVyIEhvd2FyZCA8Y2hyaXN0b3BoZXJAbGli cmVoYWNrZXIuY29tPgorOzs7Cis7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCis7 OzsKKzs7OyBHTlUgR3VpeCBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IgbW9kaWZ5IGl0Cis7OzsgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJh bCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKzs7OyB0aGUgRnJlZSBTb2Z0d2FyZSBG b3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQKKzs7OyB5 b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCis7OzsKKzs7OyBHTlUgR3VpeCBpcyBkaXN0 cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLCBidXQKKzs7OyBXSVRI T1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCis7 OzsgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAg U2VlIHRoZQorOzs7IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMu Cis7OzsKKzs7OyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZQorOzs7IGFsb25nIHdpdGggR05VIEd1aXguICBJZiBub3QsIHNl ZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisKKyhkZWZpbmUtbW9kdWxlIChnbnUg cGFja2FnZXMgc2RyKQorICAjOnVzZS1tb2R1bGUgKChndWl4IGxpY2Vuc2VzKSAjOnByZWZpeCBs aWNlbnNlOikKKyAgIzp1c2UtbW9kdWxlIChndWl4IHBhY2thZ2VzKQorICAjOnVzZS1tb2R1bGUg KGd1aXggdXRpbHMpCisgICM6dXNlLW1vZHVsZSAoZ3VpeCBkb3dubG9hZCkKKyAgIzp1c2UtbW9k dWxlIChndWl4IGdpdC1kb3dubG9hZCkKKyAgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3Rl bSBnbnUpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzKQorICAjOnVzZS1tb2R1bGUgKGdu dSBwYWNrYWdlcyBhbGdlYnJhKQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBhdXRvdG9v bHMpKQorCisoZGVmaW5lLXB1YmxpYyBsaXF1aWQtZHNwCisgIChwYWNrYWdlCisgICAgKG5hbWUg ImxpcXVpZC1kc3AiKQorICAgICh2ZXJzaW9uICIxLjMuMiIpCisgICAgKHNvdXJjZQorICAgICAo b3JpZ2luIChtZXRob2QgZ2l0LWZldGNoKQorICAgICAgICAgICAgICh1cmkgKGdpdC1yZWZlcmVu Y2UKKyAgICAgICAgICAgICAgICAgICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vamdhZWRkZXJ0 L2xpcXVpZC1kc3AuZ2l0IikKKyAgICAgICAgICAgICAgICAgICAoY29tbWl0IChzdHJpbmctYXBw ZW5kICJ2IiB2ZXJzaW9uKSkpKQorICAgICAgICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxlLW5h bWUgbmFtZSB2ZXJzaW9uKSkKKyAgICAgICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgIChi YXNlMzIgIjFuNmRiZzEzcThnYTVxaGcxeWlzendseTRqajByeHFyNmYxeHdtOXdhYWx5NXo0OTN4 c2QiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAobmF0aXZl LWlucHV0cworICAgICBgKCgiYXV0b2NvbmYiICxhdXRvY29uZikpKQorICAgIChpbnB1dHMKKyAg ICAgYCgoImZmdHciICxmZnR3KQorICAgICAgICgiZmZ0d2YiICxmZnR3ZikpKQorICAgIChob21l LXBhZ2UgImh0dHBzOi8vbGlxdWlkc2RyLm9yZyIpCisgICAgKHN5bm9wc2lzICJTaWduYWwgcHJv Y2Vzc2luZyBsaWJyYXJ5IGZvciBzb2Z0d2FyZS1kZWZpbmVkIHJhZGlvcyIpCisgICAgKGRlc2Ny aXB0aW9uCisgICAgICJMaXF1aWQgRFNQIGlzIGEgQGRmbntkaWdpdGFsIHNpZ25hbCBwcm9jZXNz aW5nfSAoRFNQKSBsaWJyYXJ5IGRlc2lnbmVkCitzcGVjaWZpY2FsbHkgZm9yIHNvZnR3YXJlLWRl ZmluZWQgcmFkaW9zIG9uIGVtYmVkZGVkIHBsYXRmb3Jtcy4gIFRoZSBhaW0gaXMgdG8KK3Byb3Zp ZGUgYSBsaWdodHdlaWdodCBEU1AgbGlicmFyeSB0aGF0IGRvZXMgbm90IHJlbHkgb24gYSBteXJp YWQgb2YgZXh0ZXJuYWwKK2RlcGVuZGVuY2llcyBvciBwcm9wcmlldGFyeSBhbmQgb3RoZXJ3aXNl IGN1bWJlcnNvbWUgZnJhbWV3b3Jrcy4gIEFsbCBzaWduYWwKK3Byb2Nlc3NpbmcgZWxlbWVudHMg YXJlIGRlc2lnbmVkIHRvIGJlIGZsZXhpYmxlLCBzY2FsYWJsZSwgYW5kIGR5bmFtaWMsCitpbmNs dWRpbmcgZmlsdGVycywgZmlsdGVyIGRlc2lnbiwgb3NjaWxsYXRvcnMsIG1vZGVtcywgc3luY2hy b25pemVycywgY29tcGxleAorbWF0aGVtYXRpY2FsIG9wZXJhdGlvbnMsIGFuZCBtdWNoIG1vcmUu IikKKyAgICAobGljZW5zZSBsaWNlbnNlOmV4cGF0KSkpCi0tIAoyLjI0LjEKCg== --=-QSXTB1IAP1GW2TW3vCbL--