From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add dfu-programmer
Date: Mon, 29 Sep 2014 18:09:26 +0200
Message-ID: <87bnpyv26h.fsf@gnu.org>
References: <CAFtzXzN8U88Pu=1yyH_VMjPP7ExmvQJc4x7LEbx5WeGJMKqCDQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43876)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XYdW3-0008TB-Jf
	for Guix-devel@gnu.org; Mon, 29 Sep 2014 12:09:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XYdVy-00041a-Hz
	for Guix-devel@gnu.org; Mon, 29 Sep 2014 12:09:35 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:41387)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XYdVy-00040B-6v
	for Guix-devel@gnu.org; Mon, 29 Sep 2014 12:09:30 -0400
In-Reply-To: <CAFtzXzN8U88Pu=1yyH_VMjPP7ExmvQJc4x7LEbx5WeGJMKqCDQ@mail.gmail.com>
	(Manolis Ragkousis's message of "Mon, 29 Sep 2014 13:46:04 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>

Manolis Ragkousis <manolis837@gmail.com> skribis:

> From 8f0da7d367be1995f8980992a647adedd85d2f1c Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Mon, 29 Sep 2014 13:27:30 +0300
> Subject: [PATCH] gnu: Add dfu-programmer
>
> * gnu/packages/dfu-programmer.scm: New file
> * gnu-system.am (GNU_SYSTEM_MODULES): Add dfu-programmer.scm
> * gnu/packages/patches/dfu-programmer-fix-libusb.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.

As discussed on #guix, it might be good to move it to a =E2=80=98flashing-t=
ools=E2=80=99
module or something?

> +    (home-page "http://dfu-programmer.github.io/")
> +    (synopsis "Dfu-programmer for Atmel chips")

Rather =E2=80=9CDevice firmware update programmer for Atmel chips=E2=80=9D.

> +    (description
> +     "Dfu-programmer is a multi-platform command-line programmer for Atm=
el (8051, AVR, XMEGA & AVR32)
> + chips with a USB bootloader supporting ISP")

Please wrap lines to less than 80 chars.

> +--- a/src/dfu-device.h
> ++++ b/src/dfu-device.h
> +@@ -6,7 +6,7 @@
> + #endif
> + #include <stdint.h>
> + #ifdef HAVE_LIBUSB_1_0
> +-#include <libusb.h>
> ++#include <libusb-1.0/libusb.h>

I think the bug is rather that pkg-config is missing, because libusb.pc
has this line:

  Cflags: -I${includedir}/libusb-1.0

Could you try adding it as a native input and report back?

Thanks,
Ludo=E2=80=99.