Re: [PATCH] gnu: Add dfu-programmer

[ludo@gnu.org (Ludovic Courtès)]

Manolis Ragkousis <manolis837@gmail.com> skribis:

> From 8f0da7d367be1995f8980992a647adedd85d2f1c Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Mon, 29 Sep 2014 13:27:30 +0300
> Subject: [PATCH] gnu: Add dfu-programmer
>
> * gnu/packages/dfu-programmer.scm: New file
> * gnu-system.am (GNU_SYSTEM_MODULES): Add dfu-programmer.scm
> * gnu/packages/patches/dfu-programmer-fix-libusb.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.

As discussed on #guix, it might be good to move it to a ‘flashing-tools’
module or something?

> +    (home-page "http://dfu-programmer.github.io/")
> +    (synopsis "Dfu-programmer for Atmel chips")

Rather “Device firmware update programmer for Atmel chips”.

> +    (description
> +     "Dfu-programmer is a multi-platform command-line programmer for Atmel (8051, AVR, XMEGA & AVR32)
> + chips with a USB bootloader supporting ISP")

Please wrap lines to less than 80 chars.

> +--- a/src/dfu-device.h
> ++++ b/src/dfu-device.h
> +@@ -6,7 +6,7 @@
> + #endif
> + #include <stdint.h>
> + #ifdef HAVE_LIBUSB_1_0
> +-#include <libusb.h>
> ++#include <libusb-1.0/libusb.h>

I think the bug is rather that pkg-config is missing, because libusb.pc
has this line:

  Cflags: -I${includedir}/libusb-1.0

Could you try adding it as a native input and report back?

Thanks,
Ludo’.