Andreas Enge <andreas@enge.fr> writes:

> Hello!
>
> On Sat, Nov 01, 2014 at 11:48:46AM -0400, David Thompson wrote:
>> +            (uri (string-append "mirror://sourceforge/freeimage/Source%20Distribution/"
>> +                                version "/FreeImage"
>> +                                (string-join (string-split version #\.) "")
>> +                                ".zip"))
>
> This looks a bit longer than the 80 characters limit.

The first argument to string append goes over, but that's okay IMO
because it is a single atom.  In any case, I just added a newline after
string-append and the issue goes away.

>
>> +                'unpack
>> +                (lambda* (#:key source #:allow-other-keys)
>> +                  (and (zero? (system* "unzip" source))
>> +                       (chdir "FreeImage")))
>
> I wonder if this should not be moved to the standard unpack phase. Can we
> determine the file format and use the appropriate tool, unzip or tar,
> automatically? (Assuming that there are no .tar.zip out there, of
> course.)

I've been thinking about this, too.  I don't think I would like the GNU
build system to depend on unzip since very few packages require it and
it's not a format that GNU uses, but maybe a procedure that replaced the
standard unpack phase with one that uses unzip would be nice.  I think
that work could/should be saved for a future patch.

Updated patch attached.  Thanks for the review!