From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: [PATCH 1/2] gnu: Add vte. Date: Mon, 15 Dec 2014 18:50:04 +0800 Message-ID: <87bnn5mbkz.fsf@gmail.com> References: <1418535265-17233-1-git-send-email-iyzsong@gmail.com> <874msyfhob.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0TEL-0004QA-32 for guix-devel@gnu.org; Mon, 15 Dec 2014 05:50:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0TEG-0008WF-E3 for guix-devel@gnu.org; Mon, 15 Dec 2014 05:50:20 -0500 Received: from mail-pd0-x229.google.com ([2607:f8b0:400e:c02::229]:35006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0TEG-0008VQ-2b for guix-devel@gnu.org; Mon, 15 Dec 2014 05:50:16 -0500 Received: by mail-pd0-f169.google.com with SMTP id z10so11543938pdj.0 for ; Mon, 15 Dec 2014 02:50:14 -0800 (PST) In-Reply-To: <874msyfhob.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Thompson , guix-devel@gnu.org David Thompson writes: > =E5=AE=8B=E6=96=87=E6=AD=A6 writes: > >> * gnu/packages/gnome.scm (vte, vte-0): New variables. >> --- >> gnu/packages/gnome.scm | 57 +++++++++++++++++++++++++++++++++++++++++++= ++++++- >> 1 file changed, 56 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm >> index 5d84f4e..7087727 100644 >> --- a/gnu/packages/gnome.scm >> +++ b/gnu/packages/gnome.scm >> @@ -47,7 +47,8 @@ >> #:use-module (gnu packages gl) >> #:use-module (gnu packages compression) >> #:use-module (gnu packages xorg) >> - #:use-module (gnu packages xdisorg)) >> + #:use-module (gnu packages xdisorg) >> + #:use-module (gnu packages ncurses)) >>=20=20 >> (define-public brasero >> (package >> @@ -1324,3 +1325,57 @@ language features to GNOME developers without imp= osing any additional runtime >> requirements and without using a different ABI compared to applications= and >> libraries written in C.") >> (license license:lgpl2.1+))) >> + >> +(define-public vte >> + (package >> + (name "vte") >> + (version "0.38.2") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "mirror://gnome/sources/" name "/" >> + (version-major+minor version) "/" >> + name "-" version ".tar.xz")) >> + (sha256 >> + (base32 >> + "1rbxrigff9yszbgdw0gw4c2saz4d1hbbpz21phzxx14w49wvmnmj")= ))) >> + (build-system gnu-build-system) >> + (native-inputs >> + `(("pkg-config" ,pkg-config) >> + ("intltool" ,intltool) >> + ("vala" ,vala) >> + ("gobject-introspection" ,gobject-introspection) >> + ("glib" ,glib "bin") ; for glib-genmarshal, etc. >> + ("xmllint" ,libxml2))) >> + (propagated-inputs >> + `(("gtk+" ,gtk+))) ; required by libvte-2.91.pc >> + (home-page "http://www.gnome.org/") >> + (synopsis "Virtual Terminal Emulator") >> + (description >> + "VTE is a library (libvte) implementing a terminal emulator widget= for >> +GTK+, and a minimal sample application (vte) using that. Vte is mainly= used in >> +gnome-terminal, but can also be used to embed a console/terminal in gam= es, >> +editors, IDEs, etc.") >> + (license license:lgpl2.1+))) >> + >> +;; stable version for gtk2, required by xfce4-terminal. >> +(define-public vte-0 > > Maybe call this one 'vte-gtk2'? 'vte-0' isn't very descriptive. Basically, I intend to use the version of pc file, for example, I have libwnck-1, which has libwnck-1.0.pc. Yes, this does make sense, but 'vte-gtk2' is look like another package, how about 'vte/gtk+-2'? > >> + (package (inherit vte) >> + (name "vte") >> + (version "0.28.2") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "mirror://gnome/sources/" name "/" >> + (version-major+minor version) "/" >> + name "-" version ".tar.xz")) >> + (sha256 >> + (base32 >> + "1bmhahkf8wdsra9whd3k5l5z4rv7r58ksr8mshzajgq2ma0hpkw6")= ))) >> + (arguments >> + '(#:configure-flags '("--disable-python"))) >> + (native-inputs >> + `(("pkg-config" ,pkg-config) >> + ("intltool" ,intltool) >> + ("glib" ,glib "bin"))) ; for glib-genmarshal, etc. >> + (propagated-inputs >> + `(("gtk+" ,gtk+-2) ; required by libvte.pc >> + ("ncurses" ,ncurses))))) ; required by libvte.la >> --=20 >> 2.1.2 >> >> > > Looks good otherwise! > > --=20 > David Thompson > Web Developer - Free Software Foundation - http://fsf.org > GPG Key: 0FF1D807 > Support the FSF: https://fsf.org/donate