From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add bowtie.
Date: Wed, 17 Dec 2014 21:41:52 +0100
Message-ID: <87bnn2huun.fsf@gnu.org>
References: <idjwq5r5xr6.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33800)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y1LQ0-0004WM-1p
	for guix-devel@gnu.org; Wed, 17 Dec 2014 15:42:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y1LPu-0006Wv-KE
	for guix-devel@gnu.org; Wed, 17 Dec 2014 15:42:00 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:51137)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Y1LPu-0006Wp-D4
	for guix-devel@gnu.org; Wed, 17 Dec 2014 15:41:54 -0500
In-Reply-To: <idjwq5r5xr6.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Tue, 16 Dec 2014 18:07:41 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 713bb1145ff901c4069f2fadb210d8eb842981da Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 16 Dec 2014 17:52:44 +0100
> Subject: [PATCH] gnu: Add bowtie
>
> * gnu/packages/bioinformatics.scm (bowtie): New variable.

[...]

> +        'patch-makefile
> +        (lambda _
> +          (substitute* "Makefile"
> +            (("^CC =3D .*$") (string-append "CC =3D " (which "gcc")))
> +            (("^CPP =3D .*$") (string-append "CPP =3D " (which "g++")))
> +            ;; replace BUILD_HOST and BUILD_TIME for deterministic build
> +            (("-DBUILD_HOST=3D.*") "-DBUILD_HOST=3D\"\\\"guix\\\"\"")
> +            (("-DBUILD_TIME=3D.*") "-DBUILD_TIME=3D\"\\\"0\\\"\"")))

Could you make this a =E2=80=98snippet=E2=80=99?  It suffices to write =E2=
=80=9CCC =3D gcc=E2=80=9D and
=E2=80=9CCPP =3D g++=E2=80=9D.  That way, running =E2=80=98guix build -S bo=
wtie=E2=80=99 will return
source that=E2=80=99s closer to what we=E2=80=99re using.

> +    (license license:gpl3)))

>From a quick glance, this should be =E2=80=98gpl3+=E2=80=99 (source file he=
aders carry
the =E2=80=9Cor any later version=E2=80=9D phrase.)

Could you post an updated patch?

TIA,
Ludo=E2=80=99.