From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: Add urwid Date: Sun, 01 Feb 2015 21:32:17 -0500 Message-ID: <87bnlddowe.fsf@netris.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI6oJ-00052x-Cq for guix-devel@gnu.org; Sun, 01 Feb 2015 21:32:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YI6oG-0008AE-63 for guix-devel@gnu.org; Sun, 01 Feb 2015 21:32:23 -0500 Received: from world.peace.net ([50.252.239.5]:58552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI6oG-00088k-0Q for guix-devel@gnu.org; Sun, 01 Feb 2015 21:32:20 -0500 In-Reply-To: (Omar Radwan's message of "Sun, 1 Feb 2015 16:14:39 -0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Omar Radwan Cc: guix-devel Omar Radwan writes: > From 7d65731aaec1b3dbca9364bc2b0f18c9fc9992e5 Mon Sep 17 00:00:00 2001 > From: Omar Radwan > Date: Sun, 1 Feb 2015 14:43:59 -0800 > Subject: [PATCH] gnu: Add urwid Minor nits: add a period above, and: > * gnu/packages/python.scm(urwid) New variable. This should be: * gnu/packages/python.scm (urwid): New variable. (add missing space and colon) > --- > gnu/packages/python.scm | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index 4b30695..19016b4 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -5,7 +5,7 @@ > ;;; Copyright =C3=82=C2=A9 2014 Mark H Weaver > ;;; Copyright =C3=82=C2=A9 2014 Eric Bavier > ;;; Copyright =C3=82=C2=A9 2014, 2015 Federico Beffa > -;;; > +;;; Copyright =C3=82=C2=A9 2015 Omar Radwan =20 > ;;; This file is part of GNU Guix. Please keep the blank line below the copyright notices. More importantly, the encoding of the "=C2=A9" is getting munged somewhere, so this patch won't apply cleanly. > ;;; > ;;; GNU Guix is free software; you can redistribute it and/or modify it > @@ -2848,3 +2848,28 @@ and written in Python.") >=20=20 > (define-public python2-html5lib > (package-with-python2 python-html5lib)) > + > + > +(define-public urwid > + (package > + (name "urwid") > + (version "1.3.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > +"https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.g= z/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz")) ;;upstream can't b= e used because Pypi don't have ETag headers in qoutes How about this instead: (uri (list (string-append "https://pypi.python.org/packages/source/u/urwid/urwid-" version ".tar.gz") ;; Downloading from the upstream URI above fails due to an ;; invalid ETag header. "https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urw= id-1.3.0.tar.gz/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz")) This first tries to download from the canonical upstream URL, in case they fix their ETag headers, but falls back to the Fedora mirror. > + (sha256 > + (base32 > + "18mb0yy94sjc434rd61m2sfnw27sa0nyrszpj5a9r9zh7fnlzw19")))) > + (build-system python-build-system) > + (inputs `(("python-2" ,python-2) > + > + ("python2-setuptools" ,python2-setuptools))) When using 'python-build-system', instead of adding python-2 as an input, we should do this instead: (arguments `(#:python ,python-2)) And 'python2-setuptools' should be a native-input: (native-inputs `(("python2-setuptools" ,python2-setuptools))) > + (home-page "urwid.org/") This should be a valid URL; in this case: (home-page "http://urwid.org") > + (synopsis "Console user interface library for Python") > + (description > + "Urwid is a console user interface library for python. It includes = many features useful for text > +console application") Double-space between sentences, keep lines < 80 columns, and add an "s" and period at the end, e.g.: (description "Urwid is a console user interface library for python. It includes ma= ny features useful for text console applications.") > + (license lgpl2.1))) > + Can you send an updated patch? Thanks! Mark